)]}'
{"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2130c3d13e285ffaeb3c7d78638cde51b4627b38","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027config_drive\u0027: None,"},{"line_number":56,"context_line":"            \u0027system_metadata\u0027: {},"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        self.test_image_meta \u003d {"},{"line_number":59,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_562d94fc","line":58,"updated":"2015-07-01 11:39:56.000000000","message":"why not create the object here?","commit_id":"be715ad553b17c8a4bb1cc3deb74363cc174c371"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"090d6faa22d9147dbaf228ebc57d5a9dab3cf295","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027config_drive\u0027: None,"},{"line_number":56,"context_line":"            \u0027system_metadata\u0027: {},"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        self.test_image_meta \u003d {"},{"line_number":59,"context_line":"            \u0027disk_format\u0027: \u0027raw\u0027,"},{"line_number":60,"context_line":"        }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_377c781e","line":58,"in_reply_to":"ba3cc151_562d94fc","updated":"2015-07-01 17:20:29.000000000","message":"No particular reason - I was just following the pattern we use for Instance already.","commit_id":"be715ad553b17c8a4bb1cc3deb74363cc174c371"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5a97aeebcf996b45e51a040dc138866c8e2c561f","unresolved":false,"context_lines":[{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":1008,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":1009,"context_line":"        image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        guest \u003d self._host.get_guest(instance)"},{"line_number":1012,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_4c752562","line":1009,"updated":"2015-06-09 13:32:33.000000000","message":"Hmm, would be cool if objects.Instance had an image_meta property that could be referenced instead of calling a objects.ImageMeta.from_instance() class method.","commit_id":"ed501f7c2af9029a0b3fa01b445e3c6666d5e2ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"39e53da027bc164fba003d08300abfc96b73dd2d","unresolved":false,"context_lines":[{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":1008,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":1009,"context_line":"        image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        guest \u003d self._host.get_guest(instance)"},{"line_number":1012,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_3d25315b","line":1009,"in_reply_to":"3afb71cf_4c576558","updated":"2015-06-10 16:42:22.000000000","message":"++","commit_id":"ed501f7c2af9029a0b3fa01b445e3c6666d5e2ec"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ccf7442d39cd1ae40c10f14410c567c5ea17d1ac","unresolved":false,"context_lines":[{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":1008,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":1009,"context_line":"        image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        guest \u003d self._host.get_guest(instance)"},{"line_number":1012,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_4c576558","line":1009,"in_reply_to":"3afb71cf_4c752562","updated":"2015-06-09 13:38:46.000000000","message":"So cool in fact that I have another patch following which will do exactly that. It will also let us remove the \u0027image_meta\u0027 property from almost all virt driver methods.","commit_id":"ed501f7c2af9029a0b3fa01b445e3c6666d5e2ec"}]}