)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9a1c1d93f6d376cbd4e16c9405663e998e037618","unresolved":false,"context_lines":[{"line_number":655,"context_line":"        \"\"\"Try to re-schedule the build or re-raise the original build error to"},{"line_number":656,"context_line":"        error out the instance."},{"line_number":657,"context_line":"        \"\"\""},{"line_number":658,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":659,"context_line":"        instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":660,"context_line":"        rescheduled \u003d False"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F12o%3D","side":"PARENT","line":658,"updated":"2013-01-02 19:22:37.000000000","message":"Am I missing something about why this needed to be moved up to the caller? Should be equivalent, right?","commit_id":"fff67a693a947c2d99c710682c999493558ea6f5"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"08b621c2b7334d9c8e9b136b8fc5ec147282ec4a","unresolved":false,"context_lines":[{"line_number":655,"context_line":"        \"\"\"Try to re-schedule the build or re-raise the original build error to"},{"line_number":656,"context_line":"        error out the instance."},{"line_number":657,"context_line":"        \"\"\""},{"line_number":658,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":659,"context_line":"        instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":660,"context_line":"        rescheduled \u003d False"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F1yw%3D","side":"PARENT","line":658,"in_reply_to":"AAAAM3%2F%2F12o%3D","updated":"2013-01-02 19:43:31.000000000","message":"Basically because it made the unit testing work.  When I added code to my test that called sys.exc_info() the same call above here returned None.  \n\nI don\u0027t understand why that would be the case, but passing the exception tuple in explicitly seems harmless.","commit_id":"fff67a693a947c2d99c710682c999493558ea6f5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5d72bf2020e9cb043e05cf9374d5696208fce8ba","unresolved":false,"context_lines":[{"line_number":655,"context_line":"        \"\"\"Try to re-schedule the build or re-raise the original build error to"},{"line_number":656,"context_line":"        error out the instance."},{"line_number":657,"context_line":"        \"\"\""},{"line_number":658,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":659,"context_line":"        instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":660,"context_line":"        rescheduled \u003d False"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FyyI%3D","side":"PARENT","line":658,"in_reply_to":"AAAAM3%2F%2F1yw%3D","updated":"2013-01-04 21:10:52.000000000","message":"Yeah, if you\u0027re not in an exception handler, sys.exc_info() will return None, so if you call _reschedule_or_reraise() directly from a test, you get None.","commit_id":"fff67a693a947c2d99c710682c999493558ea6f5"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5d72bf2020e9cb043e05cf9374d5696208fce8ba","unresolved":false,"context_lines":[{"line_number":6079,"context_line":"            raise test.TestingException(\"Original\")"},{"line_number":6080,"context_line":"        except Exception:"},{"line_number":6081,"context_line":"            # not re-scheduling, should raise the original build error:"},{"line_number":6082,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":6083,"context_line":"            self.assertRaises(test.TestingException,"},{"line_number":6084,"context_line":"                    self.compute._reschedule_or_reraise, self.context,"},{"line_number":6085,"context_line":"                    self.instance, exc_info, None, None, None, False, None, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FyxM%3D","line":6082,"updated":"2013-01-04 21:10:52.000000000","message":"Heh.  OK, this is…clever, but I\u0027d just drop the try/except and go with something like:\n\n    exc_info \u003d (TestingException, TestingException(\"Original\"), None)\n\n(I don\u0027t think you\u0027re using the traceback information, are you?  Maybe it gets used by logging code or something?  If so, just ignore me; synthesizing traceback info probably isn\u0027t worth it :)","commit_id":"6afae496d2314ca6900f6f9709d093aa6bb7f29d"}]}