)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e73641b9c839576a0de88651127ed5f19d61033e","unresolved":false,"context_lines":[{"line_number":831,"context_line":"                except db_exc.DBReferenceError:"},{"line_number":832,"context_line":"                    # NOTE(melwitt): This will happen if we instance.save()"},{"line_number":833,"context_line":"                    # before an instance record has been created and FK"},{"line_number":834,"context_line":"                    # constraint fails."},{"line_number":835,"context_line":"                    raise exception.InstanceNotFound(instance_id\u003dself.uuid)"},{"line_number":836,"context_line":"            elif field in changes:"},{"line_number":837,"context_line":"                if (field \u003d\u003d \u0027cell_name\u0027 and self[field] is not None and"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_618631bb","line":834,"updated":"2015-06-05 00:52:50.000000000","message":"I\u0027d prefer strongly if you could mention in the above comment that this situation would only occur in the case where a parent cell DB had created the instance record and the user deletes the instance almost immediately, before the scheduler has picked a compute node to place the instance on. In that case, a broadcast is sent to all child cells to delete the instance, and the child cells will not have learned of the instance.","commit_id":"f8816beddbfe71a2307a743288dc6d1b0335eaef"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4d2d5980108d0ce9ccb60904f748cac5cd206b0c","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        error \u003d db_exc.DBReferenceError(\u0027table\u0027, \u0027constraint\u0027, \u0027key\u0027,"},{"line_number":500,"context_line":"                                        \u0027key_table\u0027)"},{"line_number":501,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":502,"context_line":"        fields_with_save_methods \u003d [field for field in instance.fields"},{"line_number":503,"context_line":"                                    if field !\u003d \u0027tags\u0027]"},{"line_number":504,"context_line":"        for field in fields_with_save_methods:"},{"line_number":505,"context_line":"            if isinstance(instance.fields[field], fields.ObjectField):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d9515f10","line":502,"range":{"start_line":502,"start_character":8,"end_line":502,"end_character":32},"updated":"2015-06-04 22:19:38.000000000","message":"This is kinda misleading since it\u0027s really just \"fields other than tags\". If you put the isinstance call in here then it would save you a nesting level below and be more accurate I think.","commit_id":"c6654ad7bd98db42931393389c70590542de7374"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"09c046a96dccedeb1415523b0194fab1efc322f4","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        error \u003d db_exc.DBReferenceError(\u0027table\u0027, \u0027constraint\u0027, \u0027key\u0027,"},{"line_number":500,"context_line":"                                        \u0027key_table\u0027)"},{"line_number":501,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":502,"context_line":"        fields_with_save_methods \u003d [field for field in instance.fields"},{"line_number":503,"context_line":"                                    if field !\u003d \u0027tags\u0027]"},{"line_number":504,"context_line":"        for field in fields_with_save_methods:"},{"line_number":505,"context_line":"            if isinstance(instance.fields[field], fields.ObjectField):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_59f68fd8","line":502,"range":{"start_line":502,"start_character":8,"end_line":502,"end_character":32},"in_reply_to":"3afb71cf_d9515f10","updated":"2015-06-04 22:27:44.000000000","message":"That was my intention but I messed up making the list be that. Will fix","commit_id":"c6654ad7bd98db42931393389c70590542de7374"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"86e67df0e53ad7cbeb637c31ea859352c3528a37","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        def has_save_method(field):"},{"line_number":504,"context_line":"            return isinstance(instance.fields[field],"},{"line_number":505,"context_line":"                              fields.ObjectField) and field !\u003d \u0027tags\u0027"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        fields_with_save_methods \u003d [field for field in instance.fields"},{"line_number":508,"context_line":"                                    if has_save_method(field)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_e1ba21c0","line":505,"updated":"2015-06-05 00:44:11.000000000","message":"Why not tags?","commit_id":"f8816beddbfe71a2307a743288dc6d1b0335eaef"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e73641b9c839576a0de88651127ed5f19d61033e","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        def has_save_method(field):"},{"line_number":504,"context_line":"            return isinstance(instance.fields[field],"},{"line_number":505,"context_line":"                              fields.ObjectField) and field !\u003d \u0027tags\u0027"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        fields_with_save_methods \u003d [field for field in instance.fields"},{"line_number":508,"context_line":"                                    if has_save_method(field)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_219039ec","line":505,"in_reply_to":"3afb71cf_e1ba21c0","updated":"2015-06-05 00:52:50.000000000","message":"Chatted on IRC... please \"robustify\" :)","commit_id":"f8816beddbfe71a2307a743288dc6d1b0335eaef"}]}