)]}'
{"nova/objects/virt_cpu_topology.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df24dd39c64f762286f5c50a712762a32f5257c2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027id\u0027: fields.IntegerField(),"},{"line_number":51,"context_line":"        \u0027cpu\u0027: fields.IntegerField(),"},{"line_number":52,"context_line":"        \u0027state\u0027: fields.IntegerField(),"},{"line_number":53,"context_line":"        \u0027time\u0027: fields.IntegerField(),"},{"line_number":54,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_cdbac1c0","line":53,"updated":"2015-06-04 20:36:46.000000000","message":"Might be nice to put some comments above to indicate precisely what the fields mean... as it stands, it\u0027s not entirely clear.","commit_id":"7b2914af4a09e7b2dfa17e98d6c1de8fe4b47267"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7023bf30702638829cc9748fc422ce8fd46c71de","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027id\u0027: fields.IntegerField(),"},{"line_number":51,"context_line":"        \u0027cpu\u0027: fields.IntegerField(),"},{"line_number":52,"context_line":"        \u0027state\u0027: fields.IntegerField(),"},{"line_number":53,"context_line":"        \u0027time\u0027: fields.IntegerField(),"},{"line_number":54,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_3f2cc949","line":53,"in_reply_to":"3afb71cf_cdbac1c0","updated":"2015-06-05 07:47:13.000000000","message":"Sure I will do.","commit_id":"7b2914af4a09e7b2dfa17e98d6c1de8fe4b47267"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8e3fa786a4e601f6998e7dbd31a7327da7f9aa63","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027state\u0027: fields.IntegerField(),"},{"line_number":57,"context_line":"        # The cpu time used in nanoseconds"},{"line_number":58,"context_line":"        \u0027time\u0027: fields.IntegerField(),"},{"line_number":59,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_e5afc27b","line":59,"updated":"2015-06-05 09:09:17.000000000","message":"I don\u0027t really think this should be living here. This is representing a libvirt specific struct format and is never used anywhere outside the libvirt driver. It isn\u0027t something that\u0027ll ever be persisted in the database as is, nor used by any other hypervisor drivers in Nova. So I think it should just be a plain python class in nova/virt/libvirt/guest.py  ie  GuestVCPUInfo","commit_id":"e8eddca7c4c70d5c632460ee4630272b5300a80f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"116f2e87f89418da4250cee3f6b88820616f7b10","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027state\u0027: fields.IntegerField(),"},{"line_number":57,"context_line":"        # The cpu time used in nanoseconds"},{"line_number":58,"context_line":"        \u0027time\u0027: fields.IntegerField(),"},{"line_number":59,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_905baa54","line":59,"in_reply_to":"3afb71cf_6593d2fb","updated":"2015-06-05 09:44:24.000000000","message":"The guideline is that if the data structure is visible to the base class API nova/virt/driver.py as input parameters or return values, then we should use NovaObjects. For stuff used internally by the virt drivers then there\u0027s no benefit in general.","commit_id":"e8eddca7c4c70d5c632460ee4630272b5300a80f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4eb28d9b28947a3e6067f6bc920ef3e2eae01e2b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u0027state\u0027: fields.IntegerField(),"},{"line_number":57,"context_line":"        # The cpu time used in nanoseconds"},{"line_number":58,"context_line":"        \u0027time\u0027: fields.IntegerField(),"},{"line_number":59,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_6593d2fb","line":59,"in_reply_to":"3afb71cf_e5afc27b","updated":"2015-06-05 09:19:15.000000000","message":"I expected to force sharing same structures between drivers but at least we can still move it if necessary in the future. I will do the change, thank you.","commit_id":"e8eddca7c4c70d5c632460ee4630272b5300a80f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df24dd39c64f762286f5c50a712762a32f5257c2","unresolved":false,"context_lines":[{"line_number":4674,"context_line":"        for dom in self._host.list_instance_domains():"},{"line_number":4675,"context_line":"            try:"},{"line_number":4676,"context_line":"                # TODO(sahid): list_instance_domains should"},{"line_number":4677,"context_line":"                # return Guest objects."},{"line_number":4678,"context_line":"                vcpus \u003d libvirt_guest.Guest(dom).get_vcpus_info()"},{"line_number":4679,"context_line":"                if vcpus is not None:"},{"line_number":4680,"context_line":"                    total +\u003d len(list(vcpus))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_2dc83574","line":4677,"updated":"2015-06-04 20:36:46.000000000","message":"And be renamed to get_guests() :)","commit_id":"7b2914af4a09e7b2dfa17e98d6c1de8fe4b47267"}]}