)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9476fe8a475c8650571b2a2a9967ebaa625a00a9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    id\u003dvcpu[0], cpu\u003dvcpu[3], state\u003dvcpu[1], time\u003dvcpu[2])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def erase_instance_config(self):"},{"line_number":165,"context_line":"        \"\"\"Undefine a domain.\"\"\""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            self._domain.undefineFlags("},{"line_number":168,"context_line":"                libvirt.VIR_DOMAIN_UNDEFINE_MANAGED_SAVE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ad34254a","line":165,"updated":"2015-06-04 20:41:13.000000000","message":"How about naming this either delete_configuration() or remove_configuration()? I think \"erase\" introduces a verb that we really don\u0027t use anywhere else in the code base, versus delete and remove are both used often.","commit_id":"0c8a1c5d4fff382d0b0a17ffce485dcc2b7e7d7e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9bbc5c9fa9b4711a7337458ea78eab054e163584","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    id\u003dvcpu[0], cpu\u003dvcpu[3], state\u003dvcpu[1], time\u003dvcpu[2])"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def erase_instance_config(self):"},{"line_number":165,"context_line":"        \"\"\"Undefine a domain.\"\"\""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            self._domain.undefineFlags("},{"line_number":168,"context_line":"                libvirt.VIR_DOMAIN_UNDEFINE_MANAGED_SAVE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_9fe4dd0d","line":165,"in_reply_to":"3afb71cf_ad34254a","updated":"2015-06-05 07:49:04.000000000","message":"Yes I was not sure about the name. In Host we have a method called write_instance_config to define a domain I try to be coherent but it was not a success.\n\nI will call it delete_configuration. Thanks","commit_id":"0c8a1c5d4fff382d0b0a17ffce485dcc2b7e7d7e"}]}