)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ea92500c2372d9d4a8bc36d3f5bc5b9c4a778e85","unresolved":false,"context_lines":[{"line_number":3051,"context_line":"            instance.save("},{"line_number":3052,"context_line":"                expected_task_state\u003dtask_states.UPDATING_PASSWORD)"},{"line_number":3053,"context_line":"        except NotImplementedError:"},{"line_number":3054,"context_line":"            LOG.debug(\u0027set_admin_password is not implemented \u0027"},{"line_number":3055,"context_line":"                      \u0027by this driver or guest instance.\u0027,"},{"line_number":3056,"context_line":"                      instance\u003dinstance)"},{"line_number":3057,"context_line":"            instance.task_state \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c2c58f8e","line":3054,"updated":"2015-08-18 16:33:00.000000000","message":"I think this one has to stay a warning, as it basically means an API call failed to work.","commit_id":"44e9643545844e4d62706d759b189248fbd3cfc0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e0d01f83f0b43745c5cacf338e44b908caac2b3b","unresolved":false,"context_lines":[{"line_number":3051,"context_line":"            instance.save("},{"line_number":3052,"context_line":"                expected_task_state\u003dtask_states.UPDATING_PASSWORD)"},{"line_number":3053,"context_line":"        except NotImplementedError:"},{"line_number":3054,"context_line":"            LOG.debug(\u0027set_admin_password is not implemented \u0027"},{"line_number":3055,"context_line":"                      \u0027by this driver or guest instance.\u0027,"},{"line_number":3056,"context_line":"                      instance\u003dinstance)"},{"line_number":3057,"context_line":"            instance.task_state \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cfe5dda8","line":3054,"in_reply_to":"fa1b9901_821b171b","updated":"2015-08-27 08:39:50.000000000","message":"Done","commit_id":"44e9643545844e4d62706d759b189248fbd3cfc0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"960959685cc10ff87057cae566bb1b200c0eb0f2","unresolved":false,"context_lines":[{"line_number":3051,"context_line":"            instance.save("},{"line_number":3052,"context_line":"                expected_task_state\u003dtask_states.UPDATING_PASSWORD)"},{"line_number":3053,"context_line":"        except NotImplementedError:"},{"line_number":3054,"context_line":"            LOG.debug(\u0027set_admin_password is not implemented \u0027"},{"line_number":3055,"context_line":"                      \u0027by this driver or guest instance.\u0027,"},{"line_number":3056,"context_line":"                      instance\u003dinstance)"},{"line_number":3057,"context_line":"            instance.task_state \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_821b171b","line":3054,"in_reply_to":"fa1b9901_c2c58f8e","updated":"2015-08-18 16:36:29.000000000","message":"Agreed.","commit_id":"44e9643545844e4d62706d759b189248fbd3cfc0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"960959685cc10ff87057cae566bb1b200c0eb0f2","unresolved":false,"context_lines":[{"line_number":5500,"context_line":"                # NOTE(PhilDay): Record that its not supported so we can"},{"line_number":5501,"context_line":"                # skip fast on future calls rather than waste effort getting"},{"line_number":5502,"context_line":"                # the list of instances."},{"line_number":5503,"context_line":"                LOG.debug(\"Bandwidth usage not supported by \""},{"line_number":5504,"context_line":"                          \"hypervisor.\")"},{"line_number":5505,"context_line":"                self._bw_usage_supported \u003d False"},{"line_number":5506,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_22afab95","line":5503,"updated":"2015-08-18 16:36:29.000000000","message":"This is only logged once so you could change it to INFO, that doesn\u0027t seem like a big deal.  We should arguably not be running this periodic task by default since the implementation in the driver backend is optional so therefore the task should be optional.  But that would be a separate change and probably a deprecation period.","commit_id":"44e9643545844e4d62706d759b189248fbd3cfc0"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e65c98d3aeb0630a0f6927dcc1ce0355ce7adb04","unresolved":false,"context_lines":[{"line_number":5500,"context_line":"                # NOTE(PhilDay): Record that its not supported so we can"},{"line_number":5501,"context_line":"                # skip fast on future calls rather than waste effort getting"},{"line_number":5502,"context_line":"                # the list of instances."},{"line_number":5503,"context_line":"                LOG.debug(\"Bandwidth usage not supported by \""},{"line_number":5504,"context_line":"                          \"hypervisor.\")"},{"line_number":5505,"context_line":"                self._bw_usage_supported \u003d False"},{"line_number":5506,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5dc88422","line":5503,"in_reply_to":"fa1b9901_22afab95","updated":"2015-08-18 17:01:32.000000000","message":"How crazy would it be to replace the \"NotImplementedError\" by a \"pass\" in the driver interface? It seems to be an optional interface method. And maybe push the responsibility to log that it is not implemented down to the driver interface, which could also ensure that this type of information gets only logged once (at INFO level)?","commit_id":"44e9643545844e4d62706d759b189248fbd3cfc0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e0d01f83f0b43745c5cacf338e44b908caac2b3b","unresolved":false,"context_lines":[{"line_number":5500,"context_line":"                # NOTE(PhilDay): Record that its not supported so we can"},{"line_number":5501,"context_line":"                # skip fast on future calls rather than waste effort getting"},{"line_number":5502,"context_line":"                # the list of instances."},{"line_number":5503,"context_line":"                LOG.debug(\"Bandwidth usage not supported by \""},{"line_number":5504,"context_line":"                          \"hypervisor.\")"},{"line_number":5505,"context_line":"                self._bw_usage_supported \u003d False"},{"line_number":5506,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6a811f4a","line":5503,"in_reply_to":"fa1b9901_5dc88422","updated":"2015-08-27 08:39:50.000000000","message":"I have changed to INFO","commit_id":"44e9643545844e4d62706d759b189248fbd3cfc0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7099d4e87e06defc3187165b5a11de0dca4edc85","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                  \u0027%(db_state)s.\u0027,"},{"line_number":1147,"context_line":"                  {\u0027drv_state\u0027: drv_state, \u0027db_state\u0027: db_state},"},{"line_number":1148,"context_line":"                  instance\u003dinstance)"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        if expect_running and CONF.resume_guests_state_on_host_boot:"},{"line_number":1151,"context_line":"            LOG.info(_LI(\u0027Rebooting instance after nova-compute restart.\u0027),"},{"line_number":1152,"context_line":"                     instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b2032db8","line":1149,"updated":"2015-08-27 10:16:34.000000000","message":"here","commit_id":"92bd03f6493cc37f2ee2d8aa4cc5a4f9d1534d4f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3d10fea63fa6cdf48c3b2d984dd0b8b079c584f","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                  \u0027%(db_state)s.\u0027,"},{"line_number":1147,"context_line":"                  {\u0027drv_state\u0027: drv_state, \u0027db_state\u0027: db_state},"},{"line_number":1148,"context_line":"                  instance\u003dinstance)"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        if expect_running and CONF.resume_guests_state_on_host_boot:"},{"line_number":1151,"context_line":"            LOG.info(_LI(\u0027Rebooting instance after nova-compute restart.\u0027),"},{"line_number":1152,"context_line":"                     instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_594800cc","line":1149,"in_reply_to":"da20952f_9a76c5d5","updated":"2015-10-09 19:24:02.000000000","message":"I think he was just pointing out the usage of CONF.resume_guests_state_on_host_boot here.","commit_id":"92bd03f6493cc37f2ee2d8aa4cc5a4f9d1534d4f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"80364d63edffaf934099e14e0336b43540c0860d","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                  \u0027%(db_state)s.\u0027,"},{"line_number":1147,"context_line":"                  {\u0027drv_state\u0027: drv_state, \u0027db_state\u0027: db_state},"},{"line_number":1148,"context_line":"                  instance\u003dinstance)"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        if expect_running and CONF.resume_guests_state_on_host_boot:"},{"line_number":1151,"context_line":"            LOG.info(_LI(\u0027Rebooting instance after nova-compute restart.\u0027),"},{"line_number":1152,"context_line":"                     instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_9a76c5d5","line":1149,"in_reply_to":"da20952f_b2032db8","updated":"2015-08-30 14:01:48.000000000","message":"i am not sure that i understand the comment here.","commit_id":"92bd03f6493cc37f2ee2d8aa4cc5a4f9d1534d4f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7099d4e87e06defc3187165b5a11de0dca4edc85","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"                    context, instance, net_info, block_device_info)"},{"line_number":1160,"context_line":"            except NotImplementedError:"},{"line_number":1161,"context_line":"                LOG.debug(\u0027Hypervisor driver does not support \u0027"},{"line_number":1162,"context_line":"                          \u0027resume guests\u0027, instance\u003dinstance)"},{"line_number":1163,"context_line":"            except Exception:"},{"line_number":1164,"context_line":"                # NOTE(vish): The instance failed to resume, so we set the"},{"line_number":1165,"context_line":"                #             instance to error and attempt to continue."}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_32b4fdf0","line":1162,"updated":"2015-08-27 10:16:34.000000000","message":"if we take a look at the configuration of resume_guests_state_on_host_boot:\n, it\u0027s default to False, which means user need to set to True to make it work, while they set it , they didn\u0027t get a warning it\u0027s not supported at all..... I think we should still set to WARNING here","commit_id":"92bd03f6493cc37f2ee2d8aa4cc5a4f9d1534d4f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"80364d63edffaf934099e14e0336b43540c0860d","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"                    context, instance, net_info, block_device_info)"},{"line_number":1160,"context_line":"            except NotImplementedError:"},{"line_number":1161,"context_line":"                LOG.debug(\u0027Hypervisor driver does not support \u0027"},{"line_number":1162,"context_line":"                          \u0027resume guests\u0027, instance\u003dinstance)"},{"line_number":1163,"context_line":"            except Exception:"},{"line_number":1164,"context_line":"                # NOTE(vish): The instance failed to resume, so we set the"},{"line_number":1165,"context_line":"                #             instance to error and attempt to continue."}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_5a010d05","line":1162,"in_reply_to":"da20952f_32b4fdf0","updated":"2015-08-30 14:01:48.000000000","message":"Done","commit_id":"92bd03f6493cc37f2ee2d8aa4cc5a4f9d1534d4f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0d2c839ee88f28a37c5b5ca5dfe3dd1140bdca","unresolved":false,"context_lines":[{"line_number":6176,"context_line":"                            # disable starting the instance"},{"line_number":6177,"context_line":"                            self.driver.set_bootable(instance, False)"},{"line_number":6178,"context_line":"                        except NotImplementedError:"},{"line_number":6179,"context_line":"                            LOG.debug(\"set_bootable is not implemented \""},{"line_number":6180,"context_line":"                                      \"for the current driver\")"},{"line_number":6181,"context_line":"                        # and power it off"},{"line_number":6182,"context_line":"                        self.driver.power_off(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_f93c6ce2","line":6179,"updated":"2015-10-09 19:29:32.000000000","message":"I\u0027ve never noticed this virt driver method before, only xenapi supports it, so yeah, debug is good here.","commit_id":"0d9e3b9dc120153772410402aa8ecac3043965f6"}]}