)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd3bc8f976c752a4d4c7c39defa872e679c9a831","unresolved":false,"context_lines":[{"line_number":4703,"context_line":"                  devices information"},{"line_number":4704,"context_line":"        \"\"\""},{"line_number":4705,"context_line":"        # Bail early if we know we can\u0027t support `listDevices` to avoid"},{"line_number":4706,"context_line":"        # repeated warnings within a periodic task"},{"line_number":4707,"context_line":"        if not getattr(self, \u0027_list_devices_supported\u0027, True):"},{"line_number":4708,"context_line":"            return jsonutils.dumps([])"},{"line_number":4709,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ad59c590","line":4706,"updated":"2015-06-04 20:43:38.000000000","message":"See how it\u0027s used here also.","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd3bc8f976c752a4d4c7c39defa872e679c9a831","unresolved":false,"context_lines":[{"line_number":4734,"context_line":""},{"line_number":4735,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4736,"context_line":"            if self._host.has_version(ver):"},{"line_number":4737,"context_line":"                if not getattr(self, \u0027_bad_libvirt_numa_version_warn\u0027, False):"},{"line_number":4738,"context_line":"                    LOG.warn(_LW(\u0027You are running with libvirt version %s \u0027"},{"line_number":4739,"context_line":"                                 \u0027which is known to have broken NUMA support. \u0027"},{"line_number":4740,"context_line":"                                 \u0027Consider patching or updating libvirt on \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_0d7459fb","line":4737,"updated":"2015-06-04 20:43:38.000000000","message":"It\u0027s used here.  This is a common pattern.  The flag is set after we warn the first time so that we don\u0027t log a warning every time this is called, which is all the time.","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"65add99461189a960bc8c6bb69b8e487202ca6eb","unresolved":false,"context_lines":[{"line_number":4734,"context_line":""},{"line_number":4735,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4736,"context_line":"            if self._host.has_version(ver):"},{"line_number":4737,"context_line":"                if not getattr(self, \u0027_bad_libvirt_numa_version_warn\u0027, False):"},{"line_number":4738,"context_line":"                    LOG.warn(_LW(\u0027You are running with libvirt version %s \u0027"},{"line_number":4739,"context_line":"                                 \u0027which is known to have broken NUMA support. \u0027"},{"line_number":4740,"context_line":"                                 \u0027Consider patching or updating libvirt on \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_65aab21b","line":4737,"in_reply_to":"3afb71cf_0d7459fb","updated":"2015-06-05 09:20:02.000000000","message":"ok, understood.","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"03a552e04f40d4414b40a89b4e674f5c8d530e8d","unresolved":false,"context_lines":[{"line_number":4740,"context_line":"                                 \u0027Consider patching or updating libvirt on \u0027"},{"line_number":4741,"context_line":"                                 \u0027this host if you need NUMA support.\u0027),"},{"line_number":4742,"context_line":"                             self._version_to_string("},{"line_number":4743,"context_line":"                                BAD_LIBVIRT_NUMA_VERSIONS))"},{"line_number":4744,"context_line":"                    self._bad_libvirt_numa_version_warn \u003d True"},{"line_number":4745,"context_line":"                return False"},{"line_number":4746,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8ef85ec6","line":4743,"range":{"start_line":4743,"start_character":32,"end_line":4743,"end_character":57},"updated":"2015-08-08 00:15:33.000000000","message":"Did you mean to use a list here? It will print like this \"(1, 2, 9, 2)\" Did you mean to pass \"ver\" instead?","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"669d72d2e661ae77ee0de5f4b2e5162fe7305d34","unresolved":false,"context_lines":[{"line_number":4740,"context_line":"                                 \u0027Consider patching or updating libvirt on \u0027"},{"line_number":4741,"context_line":"                                 \u0027this host if you need NUMA support.\u0027),"},{"line_number":4742,"context_line":"                             self._version_to_string("},{"line_number":4743,"context_line":"                                BAD_LIBVIRT_NUMA_VERSIONS))"},{"line_number":4744,"context_line":"                    self._bad_libvirt_numa_version_warn \u003d True"},{"line_number":4745,"context_line":"                return False"},{"line_number":4746,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ed6788e8","line":4743,"in_reply_to":"1a4dcd0f_8ef85ec6","updated":"2015-08-10 07:33:26.000000000","message":"+1\n\nAlso you can add something like this:\n\n    .... \"You can\u0027t use following libvirt versions: %s\",  \n    self._version_to_string(BAD_LIBVIRT_NUMA_VERSIONS) .....","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e669cd0d41286448d75451851eae74585ced7009","unresolved":false,"context_lines":[{"line_number":4740,"context_line":"                                 \u0027Consider patching or updating libvirt on \u0027"},{"line_number":4741,"context_line":"                                 \u0027this host if you need NUMA support.\u0027),"},{"line_number":4742,"context_line":"                             self._version_to_string("},{"line_number":4743,"context_line":"                                BAD_LIBVIRT_NUMA_VERSIONS))"},{"line_number":4744,"context_line":"                    self._bad_libvirt_numa_version_warn \u003d True"},{"line_number":4745,"context_line":"                return False"},{"line_number":4746,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_176ffa2b","line":4743,"in_reply_to":"1a4dcd0f_8ef85ec6","updated":"2015-08-11 19:42:56.000000000","message":"Gah, nice catch, it\u0027s a list of tuples.  I was doing this based on some similar calls but those were just straight tuples, I need to use ver here. Thanks!","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c155d70c2c3c8cb265b554f665e26c41770c7791","unresolved":false,"context_lines":[{"line_number":4741,"context_line":"                                 \u0027this host if you need NUMA support.\u0027),"},{"line_number":4742,"context_line":"                             self._version_to_string("},{"line_number":4743,"context_line":"                                BAD_LIBVIRT_NUMA_VERSIONS))"},{"line_number":4744,"context_line":"                    self._bad_libvirt_numa_version_warn \u003d True"},{"line_number":4745,"context_line":"                return False"},{"line_number":4746,"context_line":""},{"line_number":4747,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_4c4bdc2a","line":4744,"range":{"start_line":4744,"start_character":25,"end_line":4744,"end_character":55},"updated":"2015-06-04 16:46:16.000000000","message":"where is this used?\nis this just for a unit test?","commit_id":"b1bc809640503ec382da5e87a400f65591d692dc"}]}