)]}'
{"id":"openstack%2Fnova~18864","triplet_id":"openstack%2Fnova~master~If1334256680e7075598f00ce153cf6f021cc720f","project":"openstack/nova","branch":"master","topic":"bp/libvirt-spice","hashtags":[],"change_id":"If1334256680e7075598f00ce153cf6f021cc720f","subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","status":"MERGED","created":"2013-01-03 13:31:53.000000000","updated":"2013-01-17 11:59:14.000000000","submitted":"2013-01-17 11:59:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d6e0d2cd612433074f0222d6f2729b67e6bf5416","_number":18864,"virtual_id_number":18864,"owner":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":1,"date":"2013-01-16 10:51:49.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2013-01-17 11:59:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"recommended":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":1,"date":"2013-01-16 14:57:13.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2013-01-16 16:07:00.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2013-01-17 11:23:30.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-01-16 15:40:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"date":"2013-01-16 14:57:13.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"date":"2013-01-16 16:07:00.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2013-01-17 11:23:30.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-03 15:11:50.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-01-07 17:00:07.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2013-01-07 17:00:18.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2013-01-16 10:51:49.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-01-16 14:57:13.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-01-16 16:07:00.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-01-17 11:23:30.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2013-01-17 11:59:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b07e0f58bc686580b1d0632bba46238c90a50e94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-03 13:55:25.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18864/1/check/gate-nova-docs/10628 : SUCCESS\n- http://logs.openstack.org/18864/1/check/gate-nova-pep8/15938 : SUCCESS\n- http://logs.openstack.org/18864/1/check/gate-nova-python26/12076 : SUCCESS\n- http://logs.openstack.org/18864/1/check/gate-nova-python27/12148 : SUCCESS\n- http://logs.openstack.org/18864/1/check/gate-tempest-devstack-vm/23988 : SUCCESS\n- http://logs.openstack.org/18864/1/check/gate-devstack-vm-quantum/491 : SUCCESS (non-voting)\n- http://logs.openstack.org/18864/1/check/gate-nova-pylint/5044 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"ee607d0c4e2e328a480050ee42d5edb3c3370647","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-03 13:55:54.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/58720\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/58718\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/58719\n","accounts_in_message":[],"_revision_number":1},{"id":"2cc603f53b255badbc99455c747285124a905fdf","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-01-03 15:11:50.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nquestion, though I realize this is a refactor, it seems this is inconsistent.","accounts_in_message":[],"_revision_number":1},{"id":"cf58ef1e10602e58cc4b3c503ff84d8c453a5c93","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-04 14:33:45.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"8a0b2b6092bd08a37a1a3464d233bc19b2542567","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-07 13:59:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"29d1573e563734ee48e5b2f1ef2d8313b6a36b37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-07 14:16:47.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18864/2/check/gate-nova-docs/11024 : FAILURE\n- http://logs.openstack.org/18864/2/check/gate-nova-pep8/16333 : FAILURE\n- http://logs.openstack.org/18864/2/check/gate-nova-python26/12487 : FAILURE\n- http://logs.openstack.org/18864/2/check/gate-nova-python27/12542 : FAILURE\n- http://logs.openstack.org/18864/2/check/gate-tempest-devstack-vm/24656 : FAILURE\n- http://logs.openstack.org/18864/2/check/gate-devstack-vm-quantum/1223 : FAILURE (non-voting)\n- http://logs.openstack.org/18864/2/check/gate-nova-pylint/5358 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"d5f6ee411d3a471c9bd0f309c33916fb21b76e93","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-07 14:32:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"02880caf391c312225a846350cef713f0362f819","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-07 14:45:45.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18864/3/check/gate-nova-docs/11031 : FAILURE\n- http://logs.openstack.org/18864/3/check/gate-nova-pep8/16341 : FAILURE\n- http://logs.openstack.org/18864/3/check/gate-nova-python26/12493 : FAILURE\n- http://logs.openstack.org/18864/3/check/gate-nova-python27/12551 : FAILURE\n- http://logs.openstack.org/18864/3/check/gate-tempest-devstack-vm/24663 : FAILURE\n- http://logs.openstack.org/18864/3/check/gate-devstack-vm-quantum/1232 : FAILURE (non-voting)\n- http://logs.openstack.org/18864/3/check/gate-nova-pylint/5368 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"9640e42fbca8477e477ab6040eddd7a0519fa198","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-07 15:20:58.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7cb2799ec7515a997fb1eea233b1f196125eb0f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-07 15:36:18.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18864/4/check/gate-nova-docs/11038 : SUCCESS\n- http://logs.openstack.org/18864/4/check/gate-nova-pep8/16348 : FAILURE\n- http://logs.openstack.org/18864/4/check/gate-nova-python26/12500 : SUCCESS\n- http://logs.openstack.org/18864/4/check/gate-nova-python27/12558 : SUCCESS\n- http://logs.openstack.org/18864/4/check/gate-tempest-devstack-vm/24674 : FAILURE\n- http://logs.openstack.org/18864/4/check/gate-devstack-vm-quantum/1244 : FAILURE (non-voting)\n- http://logs.openstack.org/18864/4/check/gate-nova-pylint/5375 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"bef58129f5e74e38adfbac3f6ab1f57b4b226608","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-01-07 17:00:18.000000000","message":"Patch Set 4:\n\nHmm, we\u0027re trying really hard to avoid installing dependencies from URLs like this\n\nIt\u0027s obviously painful for packagers but I think it gives the CI folks pain too, maybe Monty can elaborate\n\nHow about you ask the maintainer to publish to pypi?\n\nIt\u0027s annoying that this is blocking you, so if you can find even a hacky way to allow pylint to run if websockify isn\u0027t available, then you can proceed and we can file a \"missing dependency\" bug to track the problem","accounts_in_message":[],"_revision_number":4},{"id":"430a773f7999f8a80740967cc6fa901f11c7b80e","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-07 18:51:08.000000000","message":"Patch Set 4:\n\nI\u0027ve come to the conclusion that getting it on pypy is the only way to make this work. AFAICT it is impossible to have everything work correctly via a URI with the way OpenStack deals with this.","accounts_in_message":[],"_revision_number":4},{"id":"c39ba5a8881e5d29f39fa847f5ada0ca8d7a511e","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-09 12:54:15.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7479ed6d9b09266bc281a4d7768041f881af940c","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-09 12:54:52.000000000","message":"Patch Set 5: Work In Progress\n\nMarking WIP until we can get the websockify PIP sorted","accounts_in_message":[],"_revision_number":5},{"id":"0abd747219824a6862cf823b7de4b15fb7068741","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-09 13:18:35.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18864/5/check/gate-nova-docs/11560 : SUCCESS\n- http://logs.openstack.org/18864/5/check/gate-nova-pep8/16870 : SUCCESS\n- http://logs.openstack.org/18864/5/check/gate-nova-python26/13029 : FAILURE\n- http://logs.openstack.org/18864/5/check/gate-nova-python27/13080 : FAILURE\n- http://logs.openstack.org/18864/5/check/gate-tempest-devstack-vm/25396 : FAILURE\n- http://logs.openstack.org/18864/5/check/gate-devstack-vm-quantum/2015 : SUCCESS (non-voting)\n- http://logs.openstack.org/18864/5/check/gate-nova-pylint/5758 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"845c519ac9378a0143b36598dad2a0c54bd2d0d4","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-10 14:58:24.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"03ee826e7b366af2fd479c7e2d56e5ec133fddf0","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-10 15:35:18.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nSmokeStack Results (patch set 6):\n\tUnit Failed:Nova tests failed.  http://smokestack.openstack.org/?go\u003d/jobs/61893\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/61891\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/61892\n","accounts_in_message":[],"_revision_number":6},{"id":"fb24fe1c15130af2ebdad311a8e3fecc9572a70c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 15:37:30.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18864/6/check/gate-nova-docs/11855 : SUCCESS\n- http://logs.openstack.org/18864/6/check/gate-nova-pep8/17161 : SUCCESS\n- http://logs.openstack.org/18864/6/check/gate-nova-python26/13323 : FAILURE\n- http://logs.openstack.org/18864/6/check/gate-nova-python27/13370 : FAILURE\n- http://logs.openstack.org/18864/6/check/gate-tempest-devstack-vm/25852 : SUCCESS\n- http://logs.openstack.org/18864/6/check/gate-devstack-vm-quantum/2493 : SUCCESS (non-voting)\n- http://logs.openstack.org/18864/6/check/gate-nova-pylint/5903 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"cce323368bdb4883f1ebc0ff48db05c280e0754d","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-10 15:38:16.000000000","message":"Patch Set 6: Work In Progress","accounts_in_message":[],"_revision_number":6},{"id":"02d3176d409ef90f38c314be8c0d4484abe7d003","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-15 19:16:29.000000000","message":"Patch Set 6:\n\nwebsockify is now available for regular pip install usage, so I\u0027ll update this","accounts_in_message":[],"_revision_number":6},{"id":"65d4a79598f9546ce461e707156140a2f4248ca2","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-15 21:45:05.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"0914b3788793f230db566a94fba0b51ff969c444","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-15 22:49:15.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/18864/7/check/gate-nova-docs/12457 : SUCCESS\n- http://logs.openstack.org/18864/7/check/gate-nova-pep8/17763 : SUCCESS\n- http://logs.openstack.org/18864/7/check/gate-nova-python26/13921 : SUCCESS\n- http://logs.openstack.org/18864/7/check/gate-nova-python27/13971 : SUCCESS\n- http://logs.openstack.org/18864/7/check/gate-tempest-devstack-vm/26898 : SUCCESS\n- http://logs.openstack.org/18864/7/check/gate-devstack-vm-quantum/3773 : SUCCESS (non-voting)\n- http://logs.openstack.org/18864/7/check/gate-nova-pylint/6372 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"e91023fc21bd226a6a976216759529f80094a243","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-16 10:20:16.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"143b1c4e8bf14ac34ef2b2fb8d31ccde4a714e9a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-16 10:51:49.000000000","message":"Patch Set 8: Works for me\n\nSmokeStack Results (patch set 8):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/64319\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/64317\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/64318\n","accounts_in_message":[],"_revision_number":8},{"id":"4a7ced0af9c1e80a7006684a8b61672fade8e3b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-16 11:02:27.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/18864/8/check/gate-nova-docs/12498 : SUCCESS\n- http://logs.openstack.org/18864/8/check/gate-nova-pep8/17804 : SUCCESS\n- http://logs.openstack.org/18864/8/check/gate-nova-python26/13962 : SUCCESS\n- http://logs.openstack.org/18864/8/check/gate-nova-python27/14012 : SUCCESS\n- http://logs.openstack.org/18864/8/check/gate-tempest-devstack-vm/26981 : SUCCESS\n- http://logs.openstack.org/18864/8/check/gate-devstack-vm-quantum/3888 : SUCCESS (non-voting)\n- http://logs.openstack.org/18864/8/check/gate-nova-pylint/6412 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"c818f1262601d0e7bbf7e8e1527e7d5f52b1136b","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-01-16 14:57:13.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\nHmm, so this introduces a new pre-req that before was only optional if you ran the console thing or something?","accounts_in_message":[],"_revision_number":8},{"id":"5c2886c7fb42b8221009958df4ac8446c7a7e122","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-01-16 15:40:26.000000000","message":"Patch Set 8:\n\nI don\u0027t think it hugely changes the situation wrt deps. Arguably it is a bug that websockify was never included as a dep before, because it meant that any devstack install was broken wrt novnc server. So for people using devstack this fixes a bug and doesn\u0027t cause them any additional install pain, since websockify is now available via the regular pip install process.  For people deploying from RPMS/Debs, the distro vendor will have taken care of adding a websockify deps in their packages, and splitting the novnc server into a separate package if they wanted it to be optional for users. This is a long winded way of saying that I don\u0027t think people will notice, let alone complain, about this addition.","accounts_in_message":[],"_revision_number":8},{"id":"7736e63c39df87b3903efb4cd27a7496c7189854","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-01-16 16:07:00.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"39d1a934c3456e1e99c7d5a3b5cc85c86ea5770e","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2013-01-17 11:23:30.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\nThanks for the care taken on the websockify dependency","accounts_in_message":[],"_revision_number":8},{"id":"cd7d1d9bfe5578848124cde77968824e9338011b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-17 11:23:33.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"dd58e112a2a18acd83670a58b01bd1a322bcdaca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-17 11:59:11.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/18864/8/gate/gate-nova-docs/12598 : SUCCESS\n- http://logs.openstack.org/18864/8/gate/gate-nova-pep8/17904 : SUCCESS\n- http://logs.openstack.org/18864/8/gate/gate-nova-python26/14062 : SUCCESS\n- http://logs.openstack.org/18864/8/gate/gate-nova-python27/14112 : SUCCESS\n- http://logs.openstack.org/18864/8/gate/gate-tempest-devstack-vm/27176 : SUCCESS\n- http://logs.openstack.org/18864/8/gate/gate-devstack-vm-quantum/4139 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"f64a6f611dd42bdb54151f076ebb9ad5cc085c79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-17 11:59:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"e71e8c2a8902acb59dc95e4ea3521e09ae50aa7d","revisions":{"79cb2aea616e92671085df3b32187dee57b428c1":{"kind":"REWORK","_number":1,"created":"2013-01-03 13:31:53.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/1"}}},"commit":{"parents":[{"commit":"515364cbb9ee8fb9b93f8a0ea14955110e5299d4","subject":"Add common config options for SPICE graphics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/515364cbb9ee8fb9b93f8a0ea14955110e5299d4"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 11:01:33.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/79cb2aea616e92671085df3b32187dee57b428c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/79cb2aea616e92671085df3b32187dee57b428c1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"515364cbb9ee8fb9b93f8a0ea14955110e5299d4","is_merged_in_target_branch":false,"change_id":"I8e817530908c6fee0781b92dc9e27010951b4540","change_number":18304,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"},"dbbfde72a5a5c23e0a6598593dd40da79e83cae0":{"kind":"REWORK","_number":2,"created":"2013-01-07 13:59:52.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/2"}}},"commit":{"parents":[{"commit":"9a88ea8517605a87acbdb23c9b9be98eb15e56f0","subject":"Add common config options for SPICE graphics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9a88ea8517605a87acbdb23c9b9be98eb15e56f0"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-07 10:56:13.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dbbfde72a5a5c23e0a6598593dd40da79e83cae0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dbbfde72a5a5c23e0a6598593dd40da79e83cae0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9a88ea8517605a87acbdb23c9b9be98eb15e56f0","is_merged_in_target_branch":false,"change_id":"I8e817530908c6fee0781b92dc9e27010951b4540","change_number":18304,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"ce300ee38c5bd632a99ea8565db8a3a9ee0fd21e":{"kind":"REWORK","_number":3,"created":"2013-01-07 14:32:36.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/3"}}},"commit":{"parents":[{"commit":"5fdcd8d8b9cabf61198e88fa9bc3faafea7bed48","subject":"Add common config options for SPICE graphics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5fdcd8d8b9cabf61198e88fa9bc3faafea7bed48"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-07 14:31:10.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ce300ee38c5bd632a99ea8565db8a3a9ee0fd21e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ce300ee38c5bd632a99ea8565db8a3a9ee0fd21e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5fdcd8d8b9cabf61198e88fa9bc3faafea7bed48","is_merged_in_target_branch":false,"change_id":"I8e817530908c6fee0781b92dc9e27010951b4540","change_number":18304,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"120e2ee3b2d6b10de840e956e0300d2a7f4b7d91":{"kind":"REWORK","_number":4,"created":"2013-01-07 15:20:58.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/4"}}},"commit":{"parents":[{"commit":"5fdcd8d8b9cabf61198e88fa9bc3faafea7bed48","subject":"Add common config options for SPICE graphics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5fdcd8d8b9cabf61198e88fa9bc3faafea7bed48"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-07 15:20:17.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/120e2ee3b2d6b10de840e956e0300d2a7f4b7d91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/120e2ee3b2d6b10de840e956e0300d2a7f4b7d91"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5fdcd8d8b9cabf61198e88fa9bc3faafea7bed48","is_merged_in_target_branch":false,"change_id":"I8e817530908c6fee0781b92dc9e27010951b4540","change_number":18304,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"b8b73847fe4e7c16e3aea127565565aed84c2c4e":{"kind":"REWORK","_number":5,"created":"2013-01-09 12:54:15.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/5"}}},"commit":{"parents":[{"commit":"aa943179d5e50ccb3658ed88288d127f2c42f90a","subject":"Expose a get_spice_console RPC API method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/aa943179d5e50ccb3658ed88288d127f2c42f90a"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-09 11:40:18.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8b73847fe4e7c16e3aea127565565aed84c2c4e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8b73847fe4e7c16e3aea127565565aed84c2c4e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"aa943179d5e50ccb3658ed88288d127f2c42f90a","is_merged_in_target_branch":false,"change_id":"Iab9d3dfc3564a122a8cd2b53d34fdcc725bfa29b","change_number":18866,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"dee57620216ce5b65f19c7bbe5d9c665fb51154e":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2013-01-10 14:58:24.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/6"}}},"commit":{"parents":[{"commit":"98ddc967bb2c0099e5fffaef00a4b8cadb562496","subject":"Expose a get_spice_console RPC API method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/98ddc967bb2c0099e5fffaef00a4b8cadb562496"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-10 14:57:13.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dee57620216ce5b65f19c7bbe5d9c665fb51154e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dee57620216ce5b65f19c7bbe5d9c665fb51154e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"98ddc967bb2c0099e5fffaef00a4b8cadb562496","is_merged_in_target_branch":false,"change_id":"Iab9d3dfc3564a122a8cd2b53d34fdcc725bfa29b","change_number":18866,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"48fdc0a13a9e9f1fb29356781b9d3d5dbcd7b68a":{"kind":"REWORK","_number":7,"created":"2013-01-15 21:45:05.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/7"}}},"commit":{"parents":[{"commit":"c712614744cccccd51678fc86910e46ad6077e4c","subject":"Add support for configuring SPICE graphics with libvirt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c712614744cccccd51678fc86910e46ad6077e4c"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-15 21:44:35.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/48fdc0a13a9e9f1fb29356781b9d3d5dbcd7b68a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/48fdc0a13a9e9f1fb29356781b9d3d5dbcd7b68a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c712614744cccccd51678fc86910e46ad6077e4c","is_merged_in_target_branch":false,"change_id":"Ic7fbfd636455aba5bf881b6a1925fd4561edfd15","change_number":18306,"patch_set_number":11,"change_status":"MERGED"}],"branch":"refs/heads/master"},"e71e8c2a8902acb59dc95e4ea3521e09ae50aa7d":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2013-01-16 10:20:16.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/64/18864/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/18864/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/18864/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/18864/8"}}},"commit":{"parents":[{"commit":"c215b5ec79516111456dfc2a63fa0facf5946ab0","subject":"Add support for configuring SPICE graphics with libvirt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c215b5ec79516111456dfc2a63fa0facf5946ab0"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-03 10:52:40.000000000","tz":0},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-01-16 10:19:37.000000000","tz":0},"subject":"Pull NovaWebSocketProxy class out of nova-novncproxy binary","message":"Pull NovaWebSocketProxy class out of nova-novncproxy binary\n\nTo allow sharing of proxy code between nova-novncproxy and\nnova-spicehtml5proxy, pull the NovaWebSocketProxy class\nout of nova-novncproxy into a new nova/console/websocketproxy.py\nfile\n\nAdds previously missing websockify dep to pip-requires.\n\nBlueprint: libvirt-spice\nChange-Id: If1334256680e7075598f00ce153cf6f021cc720f\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e71e8c2a8902acb59dc95e4ea3521e09ae50aa7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e71e8c2a8902acb59dc95e4ea3521e09ae50aa7d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c215b5ec79516111456dfc2a63fa0facf5946ab0","is_merged_in_target_branch":true,"change_id":"Ic7fbfd636455aba5bf881b6a1925fd4561edfd15","change_number":18306,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}