)]}'
{"bin/nova-spicehtml5proxy":[{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8f5a54e7ef7ee31f8f3f97eaba2254820e57ee37","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"opts \u003d ["},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027record\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fzmk%3D","line":33,"updated":"2013-01-04 14:09:15.000000000","message":"i dont think this confgiuration option is \"descriptive\" enough maybe something the spicehtml5proxy_record.","commit_id":"da0460d3a9354f3ad3838a3bdf4ab315f3f43f8a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2adc5440cff792720bb714e276a5c3dcd90d37b1","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"opts \u003d ["},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027record\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fzks%3D","line":33,"in_reply_to":"AAAAM3%2F%2Fzmk%3D","updated":"2013-01-04 14:32:50.000000000","message":"These are not configuration options that live in /etc/nova/nova.conf. They are command line arguments to the binary. As such naming them \u0027--spicehtml5proxy_record\u0027 would be hideously verbose\n\nNB, these names all match the same in nova-novncproxy for sake of consistency, so we should not diverge","commit_id":"da0460d3a9354f3ad3838a3bdf4ab315f3f43f8a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8f5a54e7ef7ee31f8f3f97eaba2254820e57ee37","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027record\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":37,"context_line":"                default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d\u0027Become a daemon (background process)\u0027),"},{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Fzmc%3D","line":36,"updated":"2013-01-04 14:09:15.000000000","message":"ditto","commit_id":"da0460d3a9354f3ad3838a3bdf4ab315f3f43f8a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8f5a54e7ef7ee31f8f3f97eaba2254820e57ee37","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":37,"context_line":"                default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d\u0027Become a daemon (background process)\u0027),"},{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FzmY%3D","line":39,"updated":"2013-01-04 14:09:15.000000000","message":"ditto","commit_id":"da0460d3a9354f3ad3838a3bdf4ab315f3f43f8a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8f5a54e7ef7ee31f8f3f97eaba2254820e57ee37","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Source is ipv6\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027cert\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027self.pem\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027SSL certificate file\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027key\u0027,"},{"line_number":49,"context_line":"               default\u003dNone,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FzmU%3D","line":46,"updated":"2013-01-04 14:09:15.000000000","message":"ditto","commit_id":"da0460d3a9354f3ad3838a3bdf4ab315f3f43f8a"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"8f5a54e7ef7ee31f8f3f97eaba2254820e57ee37","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027key\u0027,"},{"line_number":49,"context_line":"               default\u003dNone,"},{"line_number":50,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":52,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027spicehtml5proxy_host\u0027,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FzmQ%3D","line":51,"updated":"2013-01-04 14:09:15.000000000","message":"ditto","commit_id":"da0460d3a9354f3ad3838a3bdf4ab315f3f43f8a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"31bc6da693ec17b93668ebbe251892965bd78327","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u0027\u0027\u0027"},{"line_number":20,"context_line":"Websocket proxy that is compatible with OpenStack Nova"},{"line_number":21,"context_line":"SPICE HTML5 consoles. Leverages websockify.py by Joel Martin"},{"line_number":22,"context_line":"\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import os"},{"line_number":25,"context_line":"import sys"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAM3%2F%2FjFo%3D","line":22,"updated":"2013-01-16 14:58:52.000000000","message":"I think docstrings are supposed to be \"\"\" not \u0027\u0027\u0027. Surprised we don\u0027t have a hacking.py check for that...","commit_id":"eab051ec68bdc8792dddb63c9231ece11ab06037"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f9434ddcc4d5037bcf05ef01b0c955c44145e46a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u0027\u0027\u0027"},{"line_number":20,"context_line":"Websocket proxy that is compatible with OpenStack Nova"},{"line_number":21,"context_line":"SPICE HTML5 consoles. Leverages websockify.py by Joel Martin"},{"line_number":22,"context_line":"\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import os"},{"line_number":25,"context_line":"import sys"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAM3%2F%2FjEY%3D","line":22,"in_reply_to":"AAAAM3%2F%2FjE0%3D","updated":"2013-01-16 15:11:15.000000000","message":"Oh, duh :)\n\nOkay, I guess I\u0027ll let you slide on this, but can you fix if these fail to merge?","commit_id":"eab051ec68bdc8792dddb63c9231ece11ab06037"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"9d6e8990752f3ce00d106d58da8c2775e8312555","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u0027\u0027\u0027"},{"line_number":20,"context_line":"Websocket proxy that is compatible with OpenStack Nova"},{"line_number":21,"context_line":"SPICE HTML5 consoles. Leverages websockify.py by Joel Martin"},{"line_number":22,"context_line":"\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import os"},{"line_number":25,"context_line":"import sys"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAM3%2F%2FjBk%3D","line":22,"in_reply_to":"AAAAM3%2F%2FjEY%3D","updated":"2013-01-16 15:28:37.000000000","message":"Sure, otherwise I\u0027ll post a followup patch to fix both this \u0026 the existing nova-novncproxy flaw","commit_id":"eab051ec68bdc8792dddb63c9231ece11ab06037"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6bc5959123a28e3bef73cacb3472ca2ca0b86e1e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u0027\u0027\u0027"},{"line_number":20,"context_line":"Websocket proxy that is compatible with OpenStack Nova"},{"line_number":21,"context_line":"SPICE HTML5 consoles. Leverages websockify.py by Joel Martin"},{"line_number":22,"context_line":"\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import os"},{"line_number":25,"context_line":"import sys"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAM3%2F%2FjE0%3D","line":22,"in_reply_to":"AAAAM3%2F%2FjFo%3D","updated":"2013-01-16 15:07:09.000000000","message":"Heh, copy+paste from nova-novncproxy which has the same flaw","commit_id":"eab051ec68bdc8792dddb63c9231ece11ab06037"}]}
