)]}'
{"nova/tests/unit/virt/libvirt/test_guest.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b3f9c6161954789d019f3260a4872adb5dc8d51b","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def test_attach_device(self):"},{"line_number":187,"context_line":"        domain \u003d mock.MagicMock()"},{"line_number":188,"context_line":"        conf \u003d mock.MagicMock()"},{"line_number":189,"context_line":"        conf.to_xml.return_value \u003d \"\u003c/xml\u003e\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        guest \u003d libvirt_guest.Guest(domain)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_77d44446","line":188,"updated":"2015-06-09 00:31:45.000000000","message":"I think it\u0027s better to use Mock(spec\u003d) instead of MagicMock whenever possible, since MagicMock will allow any method call in the tested code to succeed without error.","commit_id":"69111aff51c0b2b09faee25e11400ef9a5d7cc05"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"09b3133f31f6ad3e6505a1b2c2222da127219c6e","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def test_attach_device(self):"},{"line_number":187,"context_line":"        domain \u003d mock.MagicMock()"},{"line_number":188,"context_line":"        conf \u003d mock.MagicMock()"},{"line_number":189,"context_line":"        conf.to_xml.return_value \u003d \"\u003c/xml\u003e\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        guest \u003d libvirt_guest.Guest(domain)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_3048f3cb","line":188,"in_reply_to":"3afb71cf_77d44446","updated":"2015-06-09 15:32:22.000000000","message":"Sure I will update the code, thanks.","commit_id":"69111aff51c0b2b09faee25e11400ef9a5d7cc05"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39e053f66e13aeed59c9014cf55217a5bb19f2b2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        :param live: A bool to indicate whether it affect the guest"},{"line_number":188,"context_line":"                     in running state"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        flags \u003d persistent and libvirt.VIR_DOMAIN_AFFECT_CONFIG or 0"},{"line_number":191,"context_line":"        flags |\u003d live and libvirt.VIR_DOMAIN_AFFECT_LIVE or 0"},{"line_number":192,"context_line":"        self._domain.attachDeviceFlags(conf.to_xml(), flags\u003dflags)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_cf5b99f5","line":190,"updated":"2015-06-07 12:44:37.000000000","message":"Is libvirt.VIR_DOMAIN_AFFECT_CONFIG a bit mask or a bit or a Boolean value?\nMy understanding is that it is a bit. The logic here does not seem right. But then again maybe I do not understand.\nDo we have specific tests for this?","commit_id":"c9571993167c5bc5b6e67958b717be887ea235f6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2248e7f7471d060521d90b5168696ddc7a6bf925","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        :param live: A bool to indicate whether it affect the guest"},{"line_number":188,"context_line":"                     in running state"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        flags \u003d persistent and libvirt.VIR_DOMAIN_AFFECT_CONFIG or 0"},{"line_number":191,"context_line":"        flags |\u003d live and libvirt.VIR_DOMAIN_AFFECT_LIVE or 0"},{"line_number":192,"context_line":"        self._domain.attachDeviceFlags(conf.to_xml(), flags\u003dflags)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_27a6c910","line":190,"in_reply_to":"3afb71cf_cf5b99f5","updated":"2015-06-08 07:08:41.000000000","message":"Flags is a bit mask [1], you can find tests here [2] for all possible value we support.\n\n  1. https://github.com/libvirt/libvirt/blob/c4d27bdddf23e4026c2b96ff8dfc8a1dec3b8d29/include/libvirt/libvirt-domain.h#L256\n  2. https://review.openstack.org/#/c/188763/2/nova/tests/unit/virt/libvirt/test_guest.py,cm","commit_id":"c9571993167c5bc5b6e67958b717be887ea235f6"}]}