)]}'
{"nova/compute/api.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"b95134c6fd1a369e4b284eedb2d83d0ef7e7a3eb","unresolved":false,"context_lines":[{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"            bdm.instance_uuid \u003d instance_uuid"},{"line_number":1209,"context_line":"            bdm.update_or_create()"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"    def _validate_bdm(self, context, instance, instance_type, all_mappings):"},{"line_number":1212,"context_line":"        def _subsequent_list(l):"},{"line_number":1213,"context_line":"            return all(el + 1 \u003d\u003d l[i + 1] for i, el in enumerate(l[:-1]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a8f2d898","line":1210,"updated":"2015-06-15 11:19:18.000000000","message":"The method is named \u0027validate\u0027, but now it also modifies the bdm. Is it acceptable for Nova?","commit_id":"f28cba82a9db23f9ab98f6f21522dd6d18affbea"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"290e9be1c9fa73aa16bbf681acfd29467e1348c5","unresolved":false,"context_lines":[{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"            bdm.instance_uuid \u003d instance_uuid"},{"line_number":1209,"context_line":"            bdm.update_or_create()"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"    def _validate_bdm(self, context, instance, instance_type, all_mappings):"},{"line_number":1212,"context_line":"        def _subsequent_list(l):"},{"line_number":1213,"context_line":"            return all(el + 1 \u003d\u003d l[i + 1] for i, el in enumerate(l[:-1]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_96d05855","line":1210,"in_reply_to":"fa32b979_a8f2d898","updated":"2015-06-29 18:56:51.000000000","message":"I noticed this whan I was coding it up and thought it\u0027s fine, but let me re-examine that","commit_id":"f28cba82a9db23f9ab98f6f21522dd6d18affbea"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"b95134c6fd1a369e4b284eedb2d83d0ef7e7a3eb","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"            elif snapshot_id is not None:"},{"line_number":1256,"context_line":"                try:"},{"line_number":1257,"context_line":"                    snap \u003d self.volume_api.get_snapshot(context, snapshot_id)"},{"line_number":1258,"context_line":"                    bdm.volume_size \u003d snap.get(\u0027size\u0027)"},{"line_number":1259,"context_line":"                except exception.CinderConnectionFailed:"},{"line_number":1260,"context_line":"                    raise"},{"line_number":1261,"context_line":"                except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_884fd491","line":1258,"updated":"2015-06-15 11:19:18.000000000","message":"We can set 100Gb size for a 10Gb snapshot to increase the size of produced volume. So you should take into consideration specified volume_size.","commit_id":"f28cba82a9db23f9ab98f6f21522dd6d18affbea"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"290e9be1c9fa73aa16bbf681acfd29467e1348c5","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"            elif snapshot_id is not None:"},{"line_number":1256,"context_line":"                try:"},{"line_number":1257,"context_line":"                    snap \u003d self.volume_api.get_snapshot(context, snapshot_id)"},{"line_number":1258,"context_line":"                    bdm.volume_size \u003d snap.get(\u0027size\u0027)"},{"line_number":1259,"context_line":"                except exception.CinderConnectionFailed:"},{"line_number":1260,"context_line":"                    raise"},{"line_number":1261,"context_line":"                except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3694ec89","line":1258,"in_reply_to":"fa32b979_884fd491","updated":"2015-06-29 18:56:51.000000000","message":"Good point!","commit_id":"f28cba82a9db23f9ab98f6f21522dd6d18affbea"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"b95134c6fd1a369e4b284eedb2d83d0ef7e7a3eb","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        mappings \u003d block_device_obj.block_device_make_list_from_dicts("},{"line_number":925,"context_line":"                self.context, mappings)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        # Make sure it passes at first"},{"line_number":928,"context_line":"        self.compute_api._validate_bdm(self.context, instance,"},{"line_number":929,"context_line":"                                       instance_type, mappings)"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_3957fc03","line":927,"updated":"2015-06-15 11:19:18.000000000","message":"how do you check that volume_size is set in mappings?","commit_id":"f28cba82a9db23f9ab98f6f21522dd6d18affbea"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"290e9be1c9fa73aa16bbf681acfd29467e1348c5","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        mappings \u003d block_device_obj.block_device_make_list_from_dicts("},{"line_number":925,"context_line":"                self.context, mappings)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        # Make sure it passes at first"},{"line_number":928,"context_line":"        self.compute_api._validate_bdm(self.context, instance,"},{"line_number":929,"context_line":"                                       instance_type, mappings)"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_16cbe854","line":927,"in_reply_to":"fa32b979_3957fc03","updated":"2015-06-29 18:56:51.000000000","message":"We don\u0027t :(\n\nWill add it","commit_id":"f28cba82a9db23f9ab98f6f21522dd6d18affbea"}]}