)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8a21d7f1d7ecd25aa14d7a99c1202695930092b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This is required for backwards compatibility due to:"},{"line_number":18,"context_line":"https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L288"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Which is also a bug. That should be hw_disk_bus."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ibb93636d767862470ebd704e3e23ec04e8a1f1ff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_61f5cac9","line":20,"updated":"2015-06-08 09:25:12.000000000","message":"With the except of \u0027ide\u0027 those constants are referring to different models of SCSI controller, so it is not right to represent them using hw_disk_bus.\n\nI think the complication here is that the vmware_adaptertype property doesn\u0027t map 1:1 to either hw_disk_bus or hw_scsi_model - it maps to a combination of both.\n\nTo handle this, I think we\u0027d have to remove vmware_adaptertype from the _legacy_property_map dict, and add some custom code in _set_attr_from_legacy_names() to handle it. Something like this \n\n  vmware_adaptertype \u003d image_props(\"vmware_adaptertype\", None)\n  if vmware_adaptertype \u003d\u003d \"ide\":\n       setattr(\"hw_disk_bus\", \"ide\")\n  else if vmware_adaptertype is not None:\n       setattr(\"hw_disk_bus\", \"scsi\")\n       setattr(\"hw_scsi_model\", vmware_adaptertype)","commit_id":"b89eb592cca2eae3c6e0a5ec74f2a700d394c11e"}],"nova/objects/fields.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8a21d7f1d7ecd25aa14d7a99c1202695930092b1","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    IDE \u003d \"ide\""},{"line_number":351,"context_line":"    LSILOGIC \u003d \"lsilogic\""},{"line_number":352,"context_line":"    LSILOGICSAS \u003d \"lsilogicsas\""},{"line_number":353,"context_line":"    PARAVIRTUAL \u003d \"paravirtual\""},{"line_number":354,"context_line":"    SATA \u003d \"sata\""},{"line_number":355,"context_line":"    SCSI \u003d \"scsi\""},{"line_number":356,"context_line":"    USB \u003d \"usb\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_a10ce23b","line":353,"updated":"2015-06-08 09:25:12.000000000","message":"All 4 of these things you are adding are models of SCSI controller, which are dealt with in the SCSIModel field.","commit_id":"b89eb592cca2eae3c6e0a5ec74f2a700d394c11e"}]}