)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8562a4e97070ed08639ddadaf6ed6df9bd43756e","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        instance \u003d objects.Instance(context, uuid\u003dinstance_uuid, **kwargs)"},{"line_number":720,"context_line":"        instance.obj_reset_changes([\u0027uuid\u0027])"},{"line_number":721,"context_line":"        instance.save()"},{"line_number":722,"context_line":"        self._update_resource_tracker(context, instance)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def _set_instance_error_state(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c16d9e05","line":721,"updated":"2015-06-08 09:50:36.000000000","message":"Sorry, I don\u0027t see any test cases that cover this new logic. Add a new test case and assert save() called, it make sense, the new test case will prove the save() instead of conductor to update instance.","commit_id":"69f9291de81162f28da80f711da405c0e8868ca2"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"14654eee2a5cffb5a26c1a83625b60562546cf27","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        instance \u003d objects.Instance(context, uuid\u003dinstance_uuid, **kwargs)"},{"line_number":720,"context_line":"        instance.obj_reset_changes([\u0027uuid\u0027])"},{"line_number":721,"context_line":"        instance.save()"},{"line_number":722,"context_line":"        self._update_resource_tracker(context, instance)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def _set_instance_error_state(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_549c9c0e","line":721,"in_reply_to":"3afb71cf_c16d9e05","updated":"2015-06-09 07:15:40.000000000","message":"Done","commit_id":"69f9291de81162f28da80f711da405c0e8868ca2"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"636b26f9c1061bf9497805102177d6ab44696a6f","unresolved":false,"context_lines":[{"line_number":717,"context_line":"            rt \u003d self._get_resource_tracker(instance.node)"},{"line_number":718,"context_line":"            rt.update_usage(context, instance)"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    def _instance_update(self, context, instance_uuid, **kwargs):"},{"line_number":721,"context_line":"        \"\"\"Update an instance in the database using kwargs as value.\"\"\""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        instance \u003d objects.Instance(context, uuid\u003dinstance_uuid, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_a4727a0f","line":720,"updated":"2015-08-06 10:54:51.000000000","message":"Since almost all callers (except one) have instance object, probably it make sense to change instance_uuid arg to instance object?","commit_id":"ee615c120fd82e8729540295356f92f58965efc6"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a97cd0d27ccc5b1428e92808454d9db22520bf0e","unresolved":false,"context_lines":[{"line_number":717,"context_line":"            rt \u003d self._get_resource_tracker(instance.node)"},{"line_number":718,"context_line":"            rt.update_usage(context, instance)"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    def _instance_update(self, context, instance_uuid, **kwargs):"},{"line_number":721,"context_line":"        \"\"\"Update an instance in the database using kwargs as value.\"\"\""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        instance \u003d objects.Instance(context, uuid\u003dinstance_uuid, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_49fb5447","line":720,"in_reply_to":"1a4dcd0f_a4727a0f","updated":"2015-08-07 11:21:39.000000000","message":"Looks like everything has been converted to objects since I originally wrote this. Is there anything that still sends dicts? Not from what I can tell. I\u0027ll make the necessary changes.","commit_id":"ee615c120fd82e8729540295356f92f58965efc6"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"636b26f9c1061bf9497805102177d6ab44696a6f","unresolved":false,"context_lines":[{"line_number":720,"context_line":"    def _instance_update(self, context, instance_uuid, **kwargs):"},{"line_number":721,"context_line":"        \"\"\"Update an instance in the database using kwargs as value.\"\"\""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        instance \u003d objects.Instance(context, uuid\u003dinstance_uuid, **kwargs)"},{"line_number":724,"context_line":"        instance.obj_reset_changes([\u0027uuid\u0027])"},{"line_number":725,"context_line":"        instance.save()"},{"line_number":726,"context_line":"        self._update_resource_tracker(context, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_27b74cf6","line":723,"updated":"2015-08-06 10:54:51.000000000","message":"conductor\u0027s instance_update restricts allowed field set to update. But this allows any modification. Is this difference important?","commit_id":"ee615c120fd82e8729540295356f92f58965efc6"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a97cd0d27ccc5b1428e92808454d9db22520bf0e","unresolved":false,"context_lines":[{"line_number":720,"context_line":"    def _instance_update(self, context, instance_uuid, **kwargs):"},{"line_number":721,"context_line":"        \"\"\"Update an instance in the database using kwargs as value.\"\"\""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        instance \u003d objects.Instance(context, uuid\u003dinstance_uuid, **kwargs)"},{"line_number":724,"context_line":"        instance.obj_reset_changes([\u0027uuid\u0027])"},{"line_number":725,"context_line":"        instance.save()"},{"line_number":726,"context_line":"        self._update_resource_tracker(context, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_897abcbb","line":723,"in_reply_to":"1a4dcd0f_27b74cf6","updated":"2015-08-07 11:21:39.000000000","message":"I don\u0027t think so. The instance object does all the required checking.","commit_id":"ee615c120fd82e8729540295356f92f58965efc6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7b8e5c46bcc545cd6cb9ed7570fa1d77bba177d2","unresolved":false,"context_lines":[{"line_number":732,"context_line":"            rt \u003d self._get_resource_tracker(instance.get(\u0027node\u0027))"},{"line_number":733,"context_line":"            rt.update_usage(context, instance)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def _instance_update(self, context, instance_uuid, **kwargs):"},{"line_number":736,"context_line":"        \"\"\"Update an instance in the database using kwargs as value.\"\"\""},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        instance_ref \u003d self.conductor_api.instance_update(context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_c8946544","side":"PARENT","line":735,"updated":"2015-08-31 08:25:28.000000000","message":"I would rather we removed this method, I think, but no need to muddle that up with this change.","commit_id":"0b4fd46d87b51105e2d27c73906a8666e65a13a9"}]}