)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"00b549631e390a1b3baea21dea5f840c6a874926","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Only Windows instances are affected by this fix. If an instance lacks this"},{"line_number":15,"context_line":"property, it will behave as it did previously with a default \"cores-per-socket\""},{"line_number":16,"context_line":"value of 1."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I0672a9e2ce65c408bd8c50563fd9300094c30137"},{"line_number":19,"context_line":"Co-Authored-By: John Garbutt \u003cjohn@johngarbutt.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_7f95d630","line":17,"updated":"2015-06-10 20:10:23.000000000","message":"I guess opening a bug in launchpad or blueprint can be useful to follow it. It\u0027s a good feature for Windows users.","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"}],"nova/tests/unit/virt/xenapi/test_vm_utils.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"401e4725f25d39bea0ef2c0d910bb505c639c0c9","unresolved":false,"context_lines":[{"line_number":2217,"context_line":"            \u0027recommendations\u0027: \u0027\u0027,"},{"line_number":2218,"context_line":"            \u0027ha_always_run\u0027: False}"},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"        session.call_xenapi.assert_called_with(\u0027VM.create\u0027, expected_vm_rec)"},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":""},{"line_number":2223,"context_line":"    def _test_create_vm_record(self, mock_extract_flavor, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_a17f9e13","line":2220,"updated":"2015-06-11 09:30:40.000000000","message":"Can we not extract the arguments and just check platform_dict[\u0027cores-per-socket\u0027]?  Otherwise it makes this test more flaky than it needs to be if other changes occur in the VM record","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"5b2afcc67f43f0273cd1b26f8c37f7bc92b32c78","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     \u0027viridian\u0027: viridian, \u0027timeoffset\u0027: \u00270\u0027}"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # note(blitz) only Windows instances are affected by \u0027cores-per-socket\u0027"},{"line_number":258,"context_line":"    if instance[\u0027os_type\u0027] \u003d\u003d \u0027windows\u0027:"},{"line_number":259,"context_line":"        cores_per_socket \u003d 1"},{"line_number":260,"context_line":"        # note(blitz) read \u0027hw_cpu_max_sockets\u0027 from the instance\u0027s metadata,"},{"line_number":261,"context_line":"        # and if it exists, set the cores_per_socket accordingly"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_a6d0ffc9","line":258,"updated":"2015-06-10 13:04:52.000000000","message":"Why should this apply only to Windows?  I would think that if it\u0027s set on an image it should apply no matter the OS.","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"00b549631e390a1b3baea21dea5f840c6a874926","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     \u0027viridian\u0027: viridian, \u0027timeoffset\u0027: \u00270\u0027}"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # note(blitz) only Windows instances are affected by \u0027cores-per-socket\u0027"},{"line_number":258,"context_line":"    if instance[\u0027os_type\u0027] \u003d\u003d \u0027windows\u0027:"},{"line_number":259,"context_line":"        cores_per_socket \u003d 1"},{"line_number":260,"context_line":"        # note(blitz) read \u0027hw_cpu_max_sockets\u0027 from the instance\u0027s metadata,"},{"line_number":261,"context_line":"        # and if it exists, set the cores_per_socket accordingly"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_bffd8eb2","line":258,"in_reply_to":"3afb71cf_247bd5c2","updated":"2015-06-10 20:10:23.000000000","message":"I\u0027m agreed with you, the document does not explicitly explain why we cannot do this on guest based on linux :/","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":11864,"name":"Ben Roble","email":"ben.roble@rackspace.com","username":"broble"},"change_message_id":"b5f27cde3685487e8622857fc14417f9193ecf19","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     \u0027viridian\u0027: viridian, \u0027timeoffset\u0027: \u00270\u0027}"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # note(blitz) only Windows instances are affected by \u0027cores-per-socket\u0027"},{"line_number":258,"context_line":"    if instance[\u0027os_type\u0027] \u003d\u003d \u0027windows\u0027:"},{"line_number":259,"context_line":"        cores_per_socket \u003d 1"},{"line_number":260,"context_line":"        # note(blitz) read \u0027hw_cpu_max_sockets\u0027 from the instance\u0027s metadata,"},{"line_number":261,"context_line":"        # and if it exists, set the cores_per_socket accordingly"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c3e63e43","line":258,"in_reply_to":"3afb71cf_a6d0ffc9","updated":"2015-06-10 17:43:51.000000000","message":"Per XenServer this property only applies to Windows instances http://support.citrix.com/article/CTX126524","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"401e4725f25d39bea0ef2c0d910bb505c639c0c9","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     \u0027viridian\u0027: viridian, \u0027timeoffset\u0027: \u00270\u0027}"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # note(blitz) only Windows instances are affected by \u0027cores-per-socket\u0027"},{"line_number":258,"context_line":"    if instance[\u0027os_type\u0027] \u003d\u003d \u0027windows\u0027:"},{"line_number":259,"context_line":"        cores_per_socket \u003d 1"},{"line_number":260,"context_line":"        # note(blitz) read \u0027hw_cpu_max_sockets\u0027 from the instance\u0027s metadata,"},{"line_number":261,"context_line":"        # and if it exists, set the cores_per_socket accordingly"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_a1fb1e78","line":258,"in_reply_to":"3afb71cf_bffd8eb2","updated":"2015-06-11 09:30:40.000000000","message":"This setting applies to _ALL_ HVM guests.  Historically only Windows guests have been supported in HVM mode but as of 6.5 we also support some Linux guests.\nos_type does not have to equal Windows; check vm_mode.get_from_instance(instance) \u003d\u003d vm_mode.HVM","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6396815b2c18f23274bd8606182d6220f3d66e98","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     \u0027viridian\u0027: viridian, \u0027timeoffset\u0027: \u00270\u0027}"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # note(blitz) only Windows instances are affected by \u0027cores-per-socket\u0027"},{"line_number":258,"context_line":"    if instance[\u0027os_type\u0027] \u003d\u003d \u0027windows\u0027:"},{"line_number":259,"context_line":"        cores_per_socket \u003d 1"},{"line_number":260,"context_line":"        # note(blitz) read \u0027hw_cpu_max_sockets\u0027 from the instance\u0027s metadata,"},{"line_number":261,"context_line":"        # and if it exists, set the cores_per_socket accordingly"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_247bd5c2","line":258,"in_reply_to":"3afb71cf_c3e63e43","updated":"2015-06-10 19:56:51.000000000","message":"That seems odd.  Do you know what happens if it\u0027s set for a linux guest?","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"00b549631e390a1b3baea21dea5f840c6a874926","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        cores_per_socket \u003d 1"},{"line_number":260,"context_line":"        # note(blitz) read \u0027hw_cpu_max_sockets\u0027 from the instance\u0027s metadata,"},{"line_number":261,"context_line":"        # and if it exists, set the cores_per_socket accordingly"},{"line_number":262,"context_line":"        maxsockets \u003d int(instance.get(\"system_metadata\", {})"},{"line_number":263,"context_line":"                         .get(\"image_hw_cpu_max_sockets\", -1))"},{"line_number":264,"context_line":"        if maxsockets !\u003d -1 and flavor.vcpus \u003e maxsockets:"},{"line_number":265,"context_line":"            cores_per_socket \u003d int(math.ceil(flavor.vcpus / float(maxsockets)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_df8f2a73","line":262,"updated":"2015-06-10 20:10:23.000000000","message":"A work is in progress to rework image metadata. Please use:\n\n  image_meta \u003d objects.ImageMeta.from_instance(instance)\n\nAlso you need to update the new object to add attribute you just have introduced \"hw_cpu_max_sockets\"","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"00b549631e390a1b3baea21dea5f840c6a874926","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        maxsockets \u003d int(instance.get(\"system_metadata\", {})"},{"line_number":263,"context_line":"                         .get(\"image_hw_cpu_max_sockets\", -1))"},{"line_number":264,"context_line":"        if maxsockets !\u003d -1 and flavor.vcpus \u003e maxsockets:"},{"line_number":265,"context_line":"            cores_per_socket \u003d int(math.ceil(flavor.vcpus / float(maxsockets)))"},{"line_number":266,"context_line":"        platform_dict[\u0027cores-per-socket\u0027] \u003d str(cores_per_socket)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    rec \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_dfc72a62","line":265,"updated":"2015-06-10 20:10:23.000000000","message":"We should to verify if the number of core per sockets is asymmetric.","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"401e4725f25d39bea0ef2c0d910bb505c639c0c9","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        maxsockets \u003d int(instance.get(\"system_metadata\", {})"},{"line_number":263,"context_line":"                         .get(\"image_hw_cpu_max_sockets\", -1))"},{"line_number":264,"context_line":"        if maxsockets !\u003d -1 and flavor.vcpus \u003e maxsockets:"},{"line_number":265,"context_line":"            cores_per_socket \u003d int(math.ceil(flavor.vcpus / float(maxsockets)))"},{"line_number":266,"context_line":"        platform_dict[\u0027cores-per-socket\u0027] \u003d str(cores_per_socket)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    rec \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_813dc22c","line":265,"in_reply_to":"3afb71cf_dfc72a62","updated":"2015-06-11 09:30:40.000000000","message":"I _think_ we may fail to boot if the vcpus is not an exact multiple of the cores_per_socket.\nIs there validation elsewhere that image_hw_cpu_max_sockets and flavor.vcpus are compatible?","commit_id":"7c7465f1748981729d727c1715ad52d40fe2b812"}]}