)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ed00ef44f5a6c9cc9caa973eae9722c09dd669c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: update swap volume to use Guest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit updates the method _swap_volume to make it"},{"line_number":10,"context_line":"passing a object Gest and then use object GuestBlock"},{"line_number":11,"context_line":"to deal with block device operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ida12d8b3612ac489b029be24a324b52d6947d042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_2cbdc3d7","line":10,"updated":"2015-06-18 16:12:48.000000000","message":"s/passing a object Gest/pass a Guest object/","commit_id":"21a692d7eaf3f8d4ee7377cef1bacf7f108a192c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ed00ef44f5a6c9cc9caa973eae9722c09dd669c3","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    def _swap_volume(self, guest, disk_path, new_path, resize_to):"},{"line_number":1097,"context_line":"        \"\"\"Swap existing disk with a new block device.\"\"\""},{"line_number":1098,"context_line":"        gblock \u003d guest.get_guest_block(disk_path)"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        # Save a copy of the domain\u0027s persistent XML file"},{"line_number":1101,"context_line":"        xml \u003d guest.get_xml_desc(dump_inactive\u003dTrue, dump_sensitive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2cb943cc","line":1098,"updated":"2015-06-18 16:12:48.000000000","message":"how about this instead?\n\n dev \u003d guest.get_block_device(disk_path)","commit_id":"21a692d7eaf3f8d4ee7377cef1bacf7f108a192c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ed00ef44f5a6c9cc9caa973eae9722c09dd669c3","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"            #             domains, so we need to temporarily undefine it."},{"line_number":1113,"context_line":"            #             If any part of this block fails, the domain is"},{"line_number":1114,"context_line":"            #             re-defined regardless."},{"line_number":1115,"context_line":"            if guest._domain.isPersistent():"},{"line_number":1116,"context_line":"                guest.delete_configuration()"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"            # Start copy with VIR_DOMAIN_REBASE_REUSE_EXT flag to"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8cd5efe5","line":1115,"updated":"2015-06-18 16:12:48.000000000","message":"How about adding a patch that adds an is_persistent() method to the Guest object?","commit_id":"21a692d7eaf3f8d4ee7377cef1bacf7f108a192c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"833a70ff1ef787aefc8be31168f0216a074dd0a6","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"            #             domains, so we need to temporarily undefine it."},{"line_number":1113,"context_line":"            #             If any part of this block fails, the domain is"},{"line_number":1114,"context_line":"            #             re-defined regardless."},{"line_number":1115,"context_line":"            if guest._domain.isPersistent():"},{"line_number":1116,"context_line":"                guest.delete_configuration()"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"            # Start copy with VIR_DOMAIN_REBASE_REUSE_EXT flag to"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cf77053a","line":1115,"in_reply_to":"fa32b979_8cd5efe5","updated":"2015-06-22 12:37:07.000000000","message":"Done - I have reorderer patches","commit_id":"21a692d7eaf3f8d4ee7377cef1bacf7f108a192c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ed00ef44f5a6c9cc9caa973eae9722c09dd669c3","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"            # allow writing to existing external volume file"},{"line_number":1120,"context_line":"            gblock.rebase(new_path, copy\u003dTrue, reuse_ext\u003dTrue)"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"            while self._wait_for_block_job(guest._domain, disk_path):"},{"line_number":1123,"context_line":"                time.sleep(0.5)"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"            gblock.job_abort(pivot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_ec6b5bef","line":1122,"updated":"2015-06-18 16:12:48.000000000","message":"Instead of passing the guest._domain internal object, how about modifying the _wait_for_block_job() method to accept a Guest object and modifying the Guest object as needed to supply the information that _wait_for_block_job() needs?","commit_id":"21a692d7eaf3f8d4ee7377cef1bacf7f108a192c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"833a70ff1ef787aefc8be31168f0216a074dd0a6","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"            # allow writing to existing external volume file"},{"line_number":1120,"context_line":"            gblock.rebase(new_path, copy\u003dTrue, reuse_ext\u003dTrue)"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"            while self._wait_for_block_job(guest._domain, disk_path):"},{"line_number":1123,"context_line":"                time.sleep(0.5)"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"            gblock.job_abort(pivot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cf906551","line":1122,"in_reply_to":"fa32b979_ec6b5bef","updated":"2015-06-22 12:37:07.000000000","message":"Yes I have a patch to address this, i will add a todo note","commit_id":"21a692d7eaf3f8d4ee7377cef1bacf7f108a192c"}]}