)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"62a0c228833f16d90cdacc96fa298f65fbf47a66","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        self._guest._domain.blockResize(self._disk, size_kb)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def wait_for_job(self, abort_on_error\u003dFalse, wait_for_job_clean\u003dFalse):"},{"line_number":311,"context_line":"        \"\"\"Wait for libvirt block job to complete."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        Libvirt may return either cur\u003d\u003dend or an empty dict when"},{"line_number":314,"context_line":"        the job is complete, depending on whether the job has been"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6ff17d94","line":311,"updated":"2015-06-18 16:27:25.000000000","message":"This construct implies that there can only ever be a single job executing against a block device in a guest at any one time. Is this a correct assumption to make? If not, perhaps it would be better to refactor this interface to look more like:\n\n dev \u003d guest.get_block_device(path)\n job \u003d dev.rebase()\n # Do some stuff...\n result \u003d job.join()  # or job.wait()\n # Do something with result...","commit_id":"2bfdb76045426f0f14c631dfedacbc6364270074"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"701993e380c1bb5ee0510e62fc5f3ff112556bdc","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        self._guest._domain.blockResize(self._disk, size_kb)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def wait_for_job(self, abort_on_error\u003dFalse, wait_for_job_clean\u003dFalse):"},{"line_number":311,"context_line":"        \"\"\"Wait for libvirt block job to complete."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        Libvirt may return either cur\u003d\u003dend or an empty dict when"},{"line_number":314,"context_line":"        the job is complete, depending on whether the job has been"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a0e73611","line":311,"in_reply_to":"fa32b979_6ff17d94","updated":"2015-06-22 10:42:44.000000000","message":"It\u0027s not possible to performs several jobs is a same time. As you can see on the driver we always call \"abort_job\" before we execute a new job on the block like a rebase.","commit_id":"2bfdb76045426f0f14c631dfedacbc6364270074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8a243ff5b540e8ac6e1c65889239c965b89e01bf","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        \"\"\"Resizes block device to Kib size.\"\"\""},{"line_number":317,"context_line":"        self._guest._domain.blockResize(self._disk, size_kb)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def wait_for_job(self, abort_on_error\u003dFalse, wait_for_job_clean\u003dFalse):"},{"line_number":320,"context_line":"        \"\"\"Wait for libvirt block job to complete."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        Libvirt may return either cur\u003d\u003dend or an empty dict when"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_9c571626","line":319,"updated":"2015-07-06 14:15:46.000000000","message":"nit: would be nice to docstring the params.","commit_id":"fb9e7468aa0b0c54d3975677550c9a67270379d9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79057f93b231949ba29ba83c50b3327a4a774121","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        \"\"\"Resizes block device to Kib size.\"\"\""},{"line_number":317,"context_line":"        self._guest._domain.blockResize(self._disk, size_kb)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def wait_for_job(self, abort_on_error\u003dFalse, wait_for_job_clean\u003dFalse):"},{"line_number":320,"context_line":"        \"\"\"Wait for libvirt block job to complete."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        Libvirt may return either cur\u003d\u003dend or an empty dict when"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_b7f0f3ca","line":319,"in_reply_to":"ba3cc151_9c571626","updated":"2015-07-06 14:24:24.000000000","message":"Yes sure I will do.","commit_id":"fb9e7468aa0b0c54d3975677550c9a67270379d9"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"b2537c4576581fac9625e310e8ed87f3ba69f97b","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                  False if completed"},{"line_number":336,"context_line":"        \"\"\""},{"line_number":337,"context_line":"        status \u003d self.get_job_info()"},{"line_number":338,"context_line":"        if status \u003d\u003d -1 and abort_on_error:"},{"line_number":339,"context_line":"            msg \u003d _(\u0027libvirt error while requesting blockjob info.\u0027)"},{"line_number":340,"context_line":"            raise exception.NovaException(msg)"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_d7de29d9","line":338,"updated":"2015-07-09 11:18:45.000000000","message":"am I reading this wrong? status will either be a None or an instnace of BlockDeviceJobInfo - this is probably a bug and the one that we are also not testing for. tests too shallow?","commit_id":"ab85cdb4584f99ce20ec5c09ed09ab2c73860117"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e73a512f5f25302672a38cb6dcd82818613062d5","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                  False if completed"},{"line_number":336,"context_line":"        \"\"\""},{"line_number":337,"context_line":"        status \u003d self.get_job_info()"},{"line_number":338,"context_line":"        if status \u003d\u003d -1 and abort_on_error:"},{"line_number":339,"context_line":"            msg \u003d _(\u0027libvirt error while requesting blockjob info.\u0027)"},{"line_number":340,"context_line":"            raise exception.NovaException(msg)"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_8444ea46","line":338,"in_reply_to":"ba3cc151_d7de29d9","updated":"2015-07-09 13:06:19.000000000","message":"You are right, i will update this and add more tests.","commit_id":"ab85cdb4584f99ce20ec5c09ed09ab2c73860117"}]}