)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"9c33e5cbe02991eeda586083651d557950ca2209","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        def _set_vcpu_weight():"},{"line_number":446,"context_line":"            inst_type \u003d db.instance_type_get(ctx, instance.instance_type_id)"},{"line_number":447,"context_line":"            vcpu_weight \u003d inst_type.get(\"vcpu_weight\")"},{"line_number":448,"context_line":"            if vcpu_weight is not None:"},{"line_number":449,"context_line":"                LOG.debug(_(\"Setting VCPU weight\"))"},{"line_number":450,"context_line":"                self._session.call_xenapi(\"VM.add_to_VCPUs_params\", vm_ref,"},{"line_number":451,"context_line":"                        \"weight\", vcpu_weight)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F8Q4%3D","line":448,"updated":"2011-11-28 21:07:12.000000000","message":"Minor nit, but you could just say\n\n  if not vcpu_weight:\n\nSince None is considered false.","commit_id":"79fc7e4fc64fa654e829541323ab7c62495044b3"},{"author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"change_message_id":"dc3c8491fb898f78fe51f52d0beb21175b60dc10","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        def _set_vcpu_weight():"},{"line_number":446,"context_line":"            inst_type \u003d db.instance_type_get(ctx, instance.instance_type_id)"},{"line_number":447,"context_line":"            vcpu_weight \u003d inst_type.get(\"vcpu_weight\")"},{"line_number":448,"context_line":"            if vcpu_weight is not None:"},{"line_number":449,"context_line":"                LOG.debug(_(\"Setting VCPU weight\"))"},{"line_number":450,"context_line":"                self._session.call_xenapi(\"VM.add_to_VCPUs_params\", vm_ref,"},{"line_number":451,"context_line":"                        \"weight\", vcpu_weight)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2F98%3D","line":448,"in_reply_to":"AAAACn%2F%2F8Q4%3D","updated":"2011-11-30 19:57:15.000000000","message":"Yes, but I didn\u0027t want to worry about what happened if vcpu_weight \u003d\u003d 0, so Iet that go through in case that was what the admin actually meant.","commit_id":"79fc7e4fc64fa654e829541323ab7c62495044b3"}]}