)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e317ca0d54137bb56d8893f543df47a4ba713fa5","unresolved":false,"context_lines":[{"line_number":2114,"context_line":"        except Exception as exc:"},{"line_number":2115,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":2116,"context_line":"                if not isinstance(exc, (exception.InstanceNotFound,"},{"line_number":2117,"context_line":"                    exception.UnexpectedDeletingTaskStateError)):"},{"line_number":2118,"context_line":"                    LOG.exception(_LE(\u0027Instance failed to spawn\u0027),"},{"line_number":2119,"context_line":"                                  instance\u003dinstance)"},{"line_number":2120,"context_line":"                # Make sure the async call finishes"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_47357244","line":2117,"updated":"2015-06-12 15:40:48.000000000","message":"Indent the condition for visual separation between the condition and the code, i.e.:\n\n    if not isinstance(exc, (exception.InstanceNotFound,\n            exception.UnexpectedDeletingTaskStateError)):\n        LOG.exception(_LE(\u0027Instance failed to spawn\u0027),\n                      instance\u003dinstance)","commit_id":"572ac7265e12337d37ce2785ad2c0e05e6c954c3"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e317ca0d54137bb56d8893f543df47a4ba713fa5","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"                                                    instance_uuid\u003di_uuid)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"                if (not CONF.neutron.allow_duplicate_networks and"},{"line_number":1099,"context_line":"                    request.network_id in instance_on_net_ids):"},{"line_number":1100,"context_line":"                    raise exception.NetworkDuplicated("},{"line_number":1101,"context_line":"                        network_id\u003drequest.network_id)"},{"line_number":1102,"context_line":"                instance_on_net_ids.append(request.network_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_470c5294","line":1099,"updated":"2015-06-12 15:40:48.000000000","message":"Again, please indent the condition another 4 spaces for visual differentiation…","commit_id":"572ac7265e12337d37ce2785ad2c0e05e6c954c3"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e317ca0d54137bb56d8893f543df47a4ba713fa5","unresolved":false,"context_lines":[{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if ((\u0027requested_networks\u0027 not in kwargs or"},{"line_number":478,"context_line":"             kwargs[\u0027requested_networks\u0027].as_tuples() \u003d\u003d [(None, None, None)])"},{"line_number":479,"context_line":"            and len(nets) \u003e 1):"},{"line_number":480,"context_line":"            self.mox.ReplayAll()"},{"line_number":481,"context_line":"            return api"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_47d1f2cc","line":479,"updated":"2015-06-12 15:40:48.000000000","message":"Another case where I\u0027d like to see the condition more deeply indented…","commit_id":"572ac7265e12337d37ce2785ad2c0e05e6c954c3"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e317ca0d54137bb56d8893f543df47a4ba713fa5","unresolved":false,"context_lines":[{"line_number":2925,"context_line":"            mock.patch.object(client.Client, \u0027list_ports\u0027,"},{"line_number":2926,"context_line":"                              side_effect\u003d_fake_list_ports),"},{"line_number":2927,"context_line":"            mock.patch.object(client.Client, \u0027show_quota\u0027,"},{"line_number":2928,"context_line":"                              return_value\u003d{\u0027quota\u0027: {\u0027port\u0027: 1}})):"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"            self.assertRaises(exception.PortLimitExceeded,"},{"line_number":2931,"context_line":"                              self.api.validate_networks,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_a7f9c64f","line":2928,"updated":"2015-06-12 15:40:48.000000000","message":"Any chance of indenting the arguments to contextlib.nested() to visually set it off from the self.assertRaises()?","commit_id":"572ac7265e12337d37ce2785ad2c0e05e6c954c3"}]}
