)]}'
{"nova/tests/unit/virt/libvirt/test_guest.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5d76c4aaf7bbab5f8d9277dfe7ca23df1555081a","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        guest \u003d libvirt_guest.Guest(domain)"},{"line_number":320,"context_line":"        guest.has_persistent_configuration()"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertTrue(domain.isPersistent())"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_2189a1c9","line":322,"updated":"2015-07-01 14:56:30.000000000","message":"This should be removed. We don\u0027t want to assert this :) We instead want to assert that guest.has_persistent_configuration() returns True :)","commit_id":"2a4a65241dd836eaef13559042014989f6d3ddbf"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0fca33d520757ebd1f12559ebff411688059263d","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        guest \u003d libvirt_guest.Guest(domain)"},{"line_number":320,"context_line":"        guest.has_persistent_configuration()"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        self.assertTrue(domain.isPersistent())"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_6c222f54","line":322,"in_reply_to":"ba3cc151_2189a1c9","updated":"2015-07-01 20:40:08.000000000","message":"ah ah ! yes right :)","commit_id":"2a4a65241dd836eaef13559042014989f6d3ddbf"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b7463005c90043c9347e9f8c017dc3f7d9077bb2","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                pass"},{"line_number":182,"context_line":"            self._domain.undefine()"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def with_persistent_configuration(self):"},{"line_number":185,"context_line":"        \"\"\"Whether domain config is persistly stored on the host.\"\"\""},{"line_number":186,"context_line":"        return self._domain.isPersistent()"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_afdea5da","line":184,"updated":"2015-06-18 16:28:42.000000000","message":"\"with\" is generally used when using a context manager. This is not the case here, so I would name this method \"is_persistent\" or \"has_persistent_configuration\".","commit_id":"1d3a64708dbe7e2e426f5fd2a91aea3d597747ba"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b4480776d04b928e63797d015c05e81050217164","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self._domain.undefine()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def has_persistent_configuration(self):"},{"line_number":183,"context_line":"        \"\"\"Whether domain config is persistly stored on the host.\"\"\""},{"line_number":184,"context_line":"        return self._domain.isPersistent()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def attach_device(self, conf, persistent\u003dFalse, live\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_fd81a04e","line":183,"updated":"2015-06-29 07:34:49.000000000","message":"persistly: not sure what that us. Do you want to say that the domain is persistent on the host?","commit_id":"4a29b5b46a97fb030cb2e56f687f5a13c3980a74"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7e6d00115ea8e8bbdd07cae2ce97448b1474379","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self._domain.undefine()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def has_persistent_configuration(self):"},{"line_number":183,"context_line":"        \"\"\"Whether domain config is persistly stored on the host.\"\"\""},{"line_number":184,"context_line":"        return self._domain.isPersistent()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def attach_device(self, conf, persistent\u003dFalse, live\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_db6ffd90","line":183,"in_reply_to":"ba3cc151_b23a5ecc","updated":"2015-06-29 12:03:14.000000000","message":"The problem is the word persistly - there is no such thing. Just write what you have written in the comment above","commit_id":"4a29b5b46a97fb030cb2e56f687f5a13c3980a74"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cd29d602698e8e12a101894f37a0836e7e3e2ce1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self._domain.undefine()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def has_persistent_configuration(self):"},{"line_number":183,"context_line":"        \"\"\"Whether domain config is persistly stored on the host.\"\"\""},{"line_number":184,"context_line":"        return self._domain.isPersistent()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def attach_device(self, conf, persistent\u003dFalse, live\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b23a5ecc","line":183,"in_reply_to":"ba3cc151_fd81a04e","updated":"2015-06-29 10:29:00.000000000","message":"No, no i want to say that the configuration (xml) of the domain is stored on the host","commit_id":"4a29b5b46a97fb030cb2e56f687f5a13c3980a74"}]}