)]}'
{"nova/db/sqlalchemy/api_migrations/migrate_repo/versions/003_host_mapping.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c22c34abaf9ae7055af92f1b8c2531fcaf2b8301","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":33,"context_line":"        Column(\u0027cell_id\u0027, Integer, nullable\u003dFalse),"},{"line_number":34,"context_line":"        Column(\u0027host\u0027, String(length\u003d255), nullable\u003dFalse),"},{"line_number":35,"context_line":"        UniqueConstraint(\u0027host\u0027,"},{"line_number":36,"context_line":"            name\u003d\u0027uniq_host_mappings0host\u0027),"},{"line_number":37,"context_line":"        Index(\u0027host_idx\u0027, \u0027host\u0027),"},{"line_number":38,"context_line":"        ForeignKeyConstraint(columns\u003d[\u0027cell_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_54e14ccf","line":35,"updated":"2015-06-15 20:30:49.000000000","message":"I\u0027m not sure we should require a host to be unique globally.  Within a cell, definitely.\n\nRequiring a host to be globally unique would be helpful for a future world where it may be possible to move a host between cells.  Perhaps it would be best to just require it from the start.","commit_id":"283bbe6e00546c2d1b5d9ae748b6417f608a1516"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"13a1755f935b92a7582bc8423405f47709e90fdb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":33,"context_line":"        Column(\u0027cell_id\u0027, Integer, nullable\u003dFalse),"},{"line_number":34,"context_line":"        Column(\u0027host\u0027, String(length\u003d255), nullable\u003dFalse),"},{"line_number":35,"context_line":"        UniqueConstraint(\u0027host\u0027,"},{"line_number":36,"context_line":"            name\u003d\u0027uniq_host_mappings0host\u0027),"},{"line_number":37,"context_line":"        Index(\u0027host_idx\u0027, \u0027host\u0027),"},{"line_number":38,"context_line":"        ForeignKeyConstraint(columns\u003d[\u0027cell_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f35173d9","line":35,"in_reply_to":"fa32b979_31212cfc","updated":"2015-06-16 13:18:32.000000000","message":"I can\u0027t think of a particular use for hostname to not be globally unique, I just know that it isn\u0027t currently with cellsv1 and that\u0027s been fine.  I\u0027m not against it being globally unique, just wanted a chance to discuss it before making a final decision.\n\nI can see a future reason for it to be globally unique, and no strong reason for it to go either way currently.  So this is fine for me.","commit_id":"283bbe6e00546c2d1b5d9ae748b6417f608a1516"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"fd6ccdcf8681cadf5dec759c1d210e2050d17de5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":33,"context_line":"        Column(\u0027cell_id\u0027, Integer, nullable\u003dFalse),"},{"line_number":34,"context_line":"        Column(\u0027host\u0027, String(length\u003d255), nullable\u003dFalse),"},{"line_number":35,"context_line":"        UniqueConstraint(\u0027host\u0027,"},{"line_number":36,"context_line":"            name\u003d\u0027uniq_host_mappings0host\u0027),"},{"line_number":37,"context_line":"        Index(\u0027host_idx\u0027, \u0027host\u0027),"},{"line_number":38,"context_line":"        ForeignKeyConstraint(columns\u003d[\u0027cell_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_e1645de6","line":35,"in_reply_to":"fa32b979_54e14ccf","updated":"2015-06-15 21:10:23.000000000","message":"Since we don\u0027t have \"soft delete\" in this table I don\u0027t see why the host shouldn\u0027t be globally unique. Are you thinking in some particular use case?","commit_id":"283bbe6e00546c2d1b5d9ae748b6417f608a1516"},{"author":{"_account_id":12548,"name":"Dheeraj Gupta","email":"dheeraj.gupta4@gmail.com","username":"dgupta"},"change_message_id":"075f36016120d6ccf7dc9883a5a3b2cc12f52394","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        Column(\u0027id\u0027, Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":33,"context_line":"        Column(\u0027cell_id\u0027, Integer, nullable\u003dFalse),"},{"line_number":34,"context_line":"        Column(\u0027host\u0027, String(length\u003d255), nullable\u003dFalse),"},{"line_number":35,"context_line":"        UniqueConstraint(\u0027host\u0027,"},{"line_number":36,"context_line":"            name\u003d\u0027uniq_host_mappings0host\u0027),"},{"line_number":37,"context_line":"        Index(\u0027host_idx\u0027, \u0027host\u0027),"},{"line_number":38,"context_line":"        ForeignKeyConstraint(columns\u003d[\u0027cell_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_31212cfc","line":35,"in_reply_to":"fa32b979_e1645de6","updated":"2015-06-16 04:35:13.000000000","message":"I think, given a hostname, we should unambiguously be able to tell which cell it belongs to.","commit_id":"283bbe6e00546c2d1b5d9ae748b6417f608a1516"}]}