)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df4916221683489088a275b328d86e2cef16af97","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: make host to return power state of guest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce method to make Host to return the power"},{"line_number":10,"context_line":"state of a guest and update driver to take account about"},{"line_number":11,"context_line":"it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_7a029db5","line":9,"updated":"2015-06-18 16:42:58.000000000","message":"here and above in summary line..\n\ns/to return/return/","commit_id":"fda5af0f55b96c168dafc2e0e5ade8bcd404245b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df4916221683489088a275b328d86e2cef16af97","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce method to make Host to return the power"},{"line_number":10,"context_line":"state of a guest and update driver to take account about"},{"line_number":11,"context_line":"it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4cd1970a98ab0a92e2dd6cceebf86ae849ce99b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_da1e490b","line":11,"updated":"2015-06-18 16:42:58.000000000","message":"s/take account about it/account for it/","commit_id":"fda5af0f55b96c168dafc2e0e5ade8bcd404245b"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df4916221683489088a275b328d86e2cef16af97","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                    # Code\u003d55 Error\u003dRequested operation is not valid:"},{"line_number":661,"context_line":"                    # domain is not running"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"                    state \u003d self._host.get_power_state(guest)"},{"line_number":664,"context_line":"                    if state \u003d\u003d power_state.SHUTDOWN:"},{"line_number":665,"context_line":"                        is_okay \u003d True"},{"line_number":666,"context_line":"                elif errcode \u003d\u003d libvirt.VIR_ERR_INTERNAL_ERROR:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5ac0f94f","line":663,"updated":"2015-06-18 16:42:58.000000000","message":"Should be:\n\n guest.get_power_state()","commit_id":"fda5af0f55b96c168dafc2e0e5ade8bcd404245b"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df4916221683489088a275b328d86e2cef16af97","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            id\u003dguest.id)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    def get_power_state(self, guest):"},{"line_number":922,"context_line":"        return self.get_guest_info(guest).state"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"    def _get_hardware_info(self):"},{"line_number":925,"context_line":"        \"\"\"Returns hardware information about the Node."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_9a99a17b","line":922,"updated":"2015-06-18 16:42:58.000000000","message":"This belongs as Guest.get_power_state() method.","commit_id":"fda5af0f55b96c168dafc2e0e5ade8bcd404245b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"850e41785ee9f4b02165c742caf6a731641d8721","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            id\u003dguest.id)"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    def get_power_state(self, guest):"},{"line_number":922,"context_line":"        return self.get_guest_info(guest).state"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"    def _get_hardware_info(self):"},{"line_number":925,"context_line":"        \"\"\"Returns hardware information about the Node."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_4488b722","line":922,"in_reply_to":"fa32b979_9a99a17b","updated":"2015-06-22 13:08:58.000000000","message":"I do not know... Guest needs a Host object to have this kind of information.\n\n  Guest.get_power_state(host)\n\nPlease see my comment on the previous patch and let met know your thinking","commit_id":"fda5af0f55b96c168dafc2e0e5ade8bcd404245b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df4916221683489088a275b328d86e2cef16af97","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"        self.maxMem \u003d maxMem"},{"line_number":1032,"context_line":"        self.memory \u003d memory"},{"line_number":1033,"context_line":"        self.nvcpus \u003d nvcpus"},{"line_number":1034,"context_line":"        self.cputime \u003d cputime"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5aa799bc","line":1034,"updated":"2015-06-18 16:42:58.000000000","message":"This class belongs in the guest.py module as an Info class, preferably in the Guest object class itself.","commit_id":"fda5af0f55b96c168dafc2e0e5ade8bcd404245b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a1cbdab5b98c2ae6244d6e808c557344525193f","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"        return self.get_connection().compareCPU(xmlDesc, flags)"},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"class HostInfo(object):"},{"line_number":1021,"context_line":"    def __init__(self, state, maxMem, memory, nvcpus, cputime):"},{"line_number":1022,"context_line":"        \"\"\"Runtime information for a given domain"},{"line_number":1023,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_17799f2f","line":1020,"updated":"2015-07-06 14:26:21.000000000","message":"I don\u0027t see where this object is even used in this patch?","commit_id":"c7485c6ac67a804408cf06167ea149e5acc14632"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a1cbdab5b98c2ae6244d6e808c557344525193f","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"        :param cputime: CPU time used in nanoseconds"},{"line_number":1029,"context_line":"        \"\"\""},{"line_number":1030,"context_line":"        self.state \u003d state"},{"line_number":1031,"context_line":"        self.maxMem \u003d maxMem"},{"line_number":1032,"context_line":"        self.memory \u003d memory"},{"line_number":1033,"context_line":"        self.nvcpus \u003d nvcpus"},{"line_number":1034,"context_line":"        self.cputime \u003d cputime"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_1792ff57","line":1031,"updated":"2015-07-06 14:26:21.000000000","message":"Here and the params above, please let\u0027s use lower_with_underscore instead of camelCase for variable naming.","commit_id":"c7485c6ac67a804408cf06167ea149e5acc14632"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"af319c152ec590ab8dc33dffc5789123a12e072a","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"        :param cputime: CPU time used in nanoseconds"},{"line_number":1029,"context_line":"        \"\"\""},{"line_number":1030,"context_line":"        self.state \u003d state"},{"line_number":1031,"context_line":"        self.maxMem \u003d maxMem"},{"line_number":1032,"context_line":"        self.memory \u003d memory"},{"line_number":1033,"context_line":"        self.nvcpus \u003d nvcpus"},{"line_number":1034,"context_line":"        self.cputime \u003d cputime"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_b43f8ad5","line":1031,"in_reply_to":"ba3cc151_1792ff57","updated":"2015-07-06 15:59:16.000000000","message":"Aie, i wanted to reimplement something which already exists http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/hardware.py#n198","commit_id":"c7485c6ac67a804408cf06167ea149e5acc14632"}]}