)]}'
{"nova/virt/libvirt/designer.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e90d0962542e7923037821a12d7f4651aa6de036","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                       ipv6_cidr\u003dNone):"},{"line_number":80,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":81,"context_line":"    with host backend details for traffic filtering\"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    conf.filtername \u003d name"},{"line_number":84,"context_line":"    conf.add_filter_param(\"IP\", primary_addr)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FvtM%3D","line":82,"updated":"2013-01-07 21:41:14.000000000","message":"What if the NoopFireWallDriver is used - please look at https://bugs.launchpad.net/nova/+bug/1050433.","commit_id":"1db58416ff6b1cfde328e2830b1b8ed781e8a0b1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4592e5c0f5fbce7faff04bc4dcdda85c872e6f51","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                       ipv6_cidr\u003dNone):"},{"line_number":80,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":81,"context_line":"    with host backend details for traffic filtering\"\"\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    conf.filtername \u003d name"},{"line_number":84,"context_line":"    conf.add_filter_param(\"IP\", primary_addr)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FvsE%3D","line":82,"in_reply_to":"AAAAM3%2F%2FvtM%3D","updated":"2013-01-07 21:56:57.000000000","message":"That bug report does doesn\u0027t really show any useful information :-(\n\nRegardless this method simply shouldn\u0027t be called if Nova is using the NoopFirewallDriver\u003e This isn\u0027t the case with current Nova code, but later patches in this series fix that flaw","commit_id":"1db58416ff6b1cfde328e2830b1b8ed781e8a0b1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"78471985503475a92fff06788eb2391f44e579d5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        conf.driver_name \u003d driver"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def set_vif_host_backend_bridge_config(conf, brname, tapname\u003dNone):"},{"line_number":38,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":39,"context_line":"    with host backend details for a software bridge\"\"\""},{"line_number":40,"context_line":"    conf.net_type \u003d \"bridge\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FpB0%3D","line":37,"updated":"2013-01-11 14:19:10.000000000","message":"set_vif_host_backend_bridge_config, set_vif_host_backend_ethernet_config and set_vif_host_backend_ovs_config are very similar. Why not have a generic function that receives kwargs as a parameter?","commit_id":"bcb99833e7f0c628df4e0778aee4a3bcd92588b4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"691a79a21b9483fba342b3d8e78bbc2c6accbce5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        conf.driver_name \u003d driver"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def set_vif_host_backend_bridge_config(conf, brname, tapname\u003dNone):"},{"line_number":38,"context_line":"    \"\"\"Populate a LibvirtConfigGuestInterface instance"},{"line_number":39,"context_line":"    with host backend details for a software bridge\"\"\""},{"line_number":40,"context_line":"    conf.net_type \u003d \"bridge\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FpBA%3D","line":37,"in_reply_to":"AAAAM3%2F%2FpB0%3D","updated":"2013-01-11 14:49:29.000000000","message":"I wanted to focus on clarity of the code so I prefer it this way","commit_id":"bcb99833e7f0c628df4e0778aee4a3bcd92588b4"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e90d0962542e7923037821a12d7f4651aa6de036","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestInterface()"},{"line_number":54,"context_line":"        model \u003d None"},{"line_number":55,"context_line":"        driver \u003d None"},{"line_number":56,"context_line":"        if CONF.libvirt_type in (\u0027kvm\u0027, \u0027qemu\u0027) and \\"},{"line_number":57,"context_line":"                CONF.libvirt_use_virtio_for_bridges:"},{"line_number":58,"context_line":"            model \u003d \"virtio\""},{"line_number":59,"context_line":"            # Workaround libvirt bug, where it mistakenly"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FvtA%3D","line":56,"updated":"2013-01-07 21:41:14.000000000","message":"Consider:\n      if (CONF.libvirt_type in (\u0027kvm\u0027, \u0027qemu\u0027) and\n           CONF.libvirt_use_virtio_for_bridges):\n\nCan the model and driver be set in the __init__? This will save all of the if\u0027s","commit_id":"1db58416ff6b1cfde328e2830b1b8ed781e8a0b1"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4592e5c0f5fbce7faff04bc4dcdda85c872e6f51","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestInterface()"},{"line_number":54,"context_line":"        model \u003d None"},{"line_number":55,"context_line":"        driver \u003d None"},{"line_number":56,"context_line":"        if CONF.libvirt_type in (\u0027kvm\u0027, \u0027qemu\u0027) and \\"},{"line_number":57,"context_line":"                CONF.libvirt_use_virtio_for_bridges:"},{"line_number":58,"context_line":"            model \u003d \"virtio\""},{"line_number":59,"context_line":"            # Workaround libvirt bug, where it mistakenly"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FvsA%3D","line":56,"in_reply_to":"AAAAM3%2F%2FvtA%3D","updated":"2013-01-07 21:56:57.000000000","message":"While in theory this could be done in the constructor today in the future this will definitely need to be in the get_config method, since the NIC model is going to vary for each individual VM that is launched.","commit_id":"1db58416ff6b1cfde328e2830b1b8ed781e8a0b1"}]}