)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"4d3ddd68c76d50ed89e9121db9f42dd3c026b962","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        #             FLAG defines depending on how long the get_info"},{"line_number":872,"context_line":"        #             call takes to return."},{"line_number":873,"context_line":"        for x in xrange(CONF.libvirt_wait_soft_reboot_seconds):"},{"line_number":874,"context_line":"            dom \u003d self._lookup_by_name(instance[\"name\"])"},{"line_number":875,"context_line":"            (state, _max_mem, _mem, _cpus, _t) \u003d dom.info()"},{"line_number":876,"context_line":"            state \u003d LIBVIRT_POWER_STATE[state]"},{"line_number":877,"context_line":"            new_domid \u003d dom.ID()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FuuQ%3D","line":874,"updated":"2013-01-08 13:54:04.000000000","message":"is this \"dom\" going to change from when it was looked up in line 861?","commit_id":"02afbfa5e670b9e87b859b8543276755e731534e"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"d4ca6cbb2e0b6b3447bcb595eb37aece41061138","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        #             FLAG defines depending on how long the get_info"},{"line_number":872,"context_line":"        #             call takes to return."},{"line_number":873,"context_line":"        for x in xrange(CONF.libvirt_wait_soft_reboot_seconds):"},{"line_number":874,"context_line":"            dom \u003d self._lookup_by_name(instance[\"name\"])"},{"line_number":875,"context_line":"            (state, _max_mem, _mem, _cpus, _t) \u003d dom.info()"},{"line_number":876,"context_line":"            state \u003d LIBVIRT_POWER_STATE[state]"},{"line_number":877,"context_line":"            new_domid \u003d dom.ID()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FtTs%3D","line":874,"in_reply_to":"AAAAM3%2F%2FuuQ%3D","updated":"2013-01-09 01:46:26.000000000","message":"yes?if the dom is \u0027hard reboot\u0027 by another request, the dom id will not change, so we need to get the domain object every loop to get the fresh dom id.","commit_id":"02afbfa5e670b9e87b859b8543276755e731534e"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"9f8735d23d3f847b971f3dc1a4f0e348e0a4430e","unresolved":false,"context_lines":[{"line_number":886,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":887,"context_line":"                return True"},{"line_number":888,"context_line":"            elif old_domid !\u003d new_domid:"},{"line_number":889,"context_line":"                LOG.info(_(\"Instance may has been rebooted during soft reboot,\""},{"line_number":890,"context_line":"                           \" so return now.\"), instance\u003dinstance)"},{"line_number":891,"context_line":"                return True"},{"line_number":892,"context_line":"            greenthread.sleep(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FseQ%3D","line":889,"updated":"2013-01-09 10:54:14.000000000","message":"s/may has/may have/ ?","commit_id":"02afbfa5e670b9e87b859b8543276755e731534e"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"f5a6d46dc132f29af5d020aa37e2d9b3f89c8019","unresolved":false,"context_lines":[{"line_number":886,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":887,"context_line":"                return True"},{"line_number":888,"context_line":"            elif old_domid !\u003d new_domid:"},{"line_number":889,"context_line":"                LOG.info(_(\"Instance may has been rebooted during soft reboot,\""},{"line_number":890,"context_line":"                           \" so return now.\"), instance\u003dinstance)"},{"line_number":891,"context_line":"                return True"},{"line_number":892,"context_line":"            greenthread.sleep(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fsck%3D","line":889,"in_reply_to":"AAAAM3%2F%2FseQ%3D","updated":"2013-01-09 11:07:56.000000000","message":"Done","commit_id":"02afbfa5e670b9e87b859b8543276755e731534e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5c15983c73a22b3b4d722206ce3f5a393ef0305e","unresolved":false,"context_lines":[{"line_number":883,"context_line":"            dom \u003d self._lookup_by_name(instance[\"name\"])"},{"line_number":884,"context_line":"            (state, _max_mem, _mem, _cpus, _t) \u003d dom.info()"},{"line_number":885,"context_line":"            state \u003d LIBVIRT_POWER_STATE[state]"},{"line_number":886,"context_line":"            new_domid \u003d dom.ID()"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"            if state in [power_state.SHUTDOWN,"},{"line_number":889,"context_line":"                         power_state.CRASHED]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fhf4%3D","line":886,"updated":"2013-01-17 13:11:38.000000000","message":"if we are SHUTDOWN or CRASHED what kind of value is returned here?","commit_id":"6344bff494758e0d7d7d25f43a3b56d82447441e"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"760422ae84cffd3654c8ca75006acbd168010e79","unresolved":false,"context_lines":[{"line_number":883,"context_line":"            dom \u003d self._lookup_by_name(instance[\"name\"])"},{"line_number":884,"context_line":"            (state, _max_mem, _mem, _cpus, _t) \u003d dom.info()"},{"line_number":885,"context_line":"            state \u003d LIBVIRT_POWER_STATE[state]"},{"line_number":886,"context_line":"            new_domid \u003d dom.ID()"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"            if state in [power_state.SHUTDOWN,"},{"line_number":889,"context_line":"                         power_state.CRASHED]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FgVs%3D","line":886,"in_reply_to":"AAAAM3%2F%2Fhf4%3D","updated":"2013-01-18 03:04:07.000000000","message":"If the instance is SHUTDOWN or CRASHED, the process will run into the first if \u0027state in [SHUTDOWN or CRASHED]\u0027, and the domID will be ignored(and the domID is -1 in these states), when instance in other states, the domID is unsigned int, when the instance is \u0027reboot\u0027(which means shutdown/destroy/crash and then start or just \u0027reboot/reset\u0027 in libvirt), the domID in hypervisor will increase.","commit_id":"6344bff494758e0d7d7d25f43a3b56d82447441e"},{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"61edaefb28453fdaa502a2f93c36e4ece1e09c28","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                return True"},{"line_number":897,"context_line":"            elif old_domid !\u003d new_domid:"},{"line_number":898,"context_line":"                LOG.info(_(\"Instance may have been rebooted during soft \""},{"line_number":899,"context_line":"                           \"reboot, so return now.\"), instance\u003dinstance)"},{"line_number":900,"context_line":"                return True"},{"line_number":901,"context_line":"            greenthread.sleep(1)"},{"line_number":902,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FX0M%3D","line":899,"updated":"2013-01-25 00:46:12.000000000","message":"I think this log entry should just state \"Instance soft reboot successful\"","commit_id":"6344bff494758e0d7d7d25f43a3b56d82447441e"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"fd25390603cbc3f2699a219d118e87ee65291439","unresolved":false,"context_lines":[{"line_number":896,"context_line":"                return True"},{"line_number":897,"context_line":"            elif old_domid !\u003d new_domid:"},{"line_number":898,"context_line":"                LOG.info(_(\"Instance may have been rebooted during soft \""},{"line_number":899,"context_line":"                           \"reboot, so return now.\"), instance\u003dinstance)"},{"line_number":900,"context_line":"                return True"},{"line_number":901,"context_line":"            greenthread.sleep(1)"},{"line_number":902,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FXxQ%3D","line":899,"in_reply_to":"AAAAM3%2F%2FX0M%3D","updated":"2013-01-25 01:35:15.000000000","message":"but the \u0027reboot\u0027 method already has the same log as your suggestion, then there will be two same log.","commit_id":"6344bff494758e0d7d7d25f43a3b56d82447441e"}]}