)]}'
{"nova/crypto.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"66b61c9fbc914d3e85b7de0b3d17331a934aeb0a","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    try:"},{"line_number":284,"context_line":"        # NOTE(vish): potential race condition here"},{"line_number":285,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-config\u0027, \u0027./openssl.cnf\u0027, \u0027-revoke\u0027,"},{"line_number":286,"context_line":"                      file_name, cwd\u003dca_folder(project_id))"},{"line_number":287,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-gencrl\u0027, \u0027-config\u0027, \u0027./openssl.cnf\u0027,"},{"line_number":288,"context_line":"                      \u0027-out\u0027, CONF.crl_file, cwd\u003dca_folder(project_id))"},{"line_number":289,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_df0da9e9","line":286,"updated":"2015-06-19 15:49:55.000000000","message":"I think this will raise OSError if the project_id folder is not there?\nwe didn\u0027t handle the OSError as before ,right? \n\nI think the patch should not change the original logic","commit_id":"b074cab7dc85994c4ffc4350ea1aaa889bdad1ae"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"730759bdab64b49020a9db371bad8918b60cce45","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    try:"},{"line_number":284,"context_line":"        # NOTE(vish): potential race condition here"},{"line_number":285,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-config\u0027, \u0027./openssl.cnf\u0027, \u0027-revoke\u0027,"},{"line_number":286,"context_line":"                      file_name, cwd\u003dca_folder(project_id))"},{"line_number":287,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-gencrl\u0027, \u0027-config\u0027, \u0027./openssl.cnf\u0027,"},{"line_number":288,"context_line":"                      \u0027-out\u0027, CONF.crl_file, cwd\u003dca_folder(project_id))"},{"line_number":289,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_7067e725","line":286,"in_reply_to":"fa32b979_df0da9e9","updated":"2015-06-19 18:02:14.000000000","message":"Done","commit_id":"b074cab7dc85994c4ffc4350ea1aaa889bdad1ae"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09d809f20af6a81b8b60bc3972d3637a66c01988","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # Change working dir to CA"},{"line_number":456,"context_line":"        fileutils.ensure_tree(ca_folder)"},{"line_number":457,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-batch\u0027, \u0027-out\u0027, outbound, \u0027-config\u0027,"},{"line_number":458,"context_line":"                      \u0027./openssl.cnf\u0027, \u0027-infiles\u0027, inbound, cwd\u003dca_folder)"},{"line_number":459,"context_line":"        out, _err \u003d utils.execute(\u0027openssl\u0027, \u0027x509\u0027, \u0027-in\u0027, outbound,"},{"line_number":460,"context_line":"                                  \u0027-serial\u0027, \u0027-noout\u0027, cwd\u003dca_folder)"},{"line_number":461,"context_line":"        serial \u003d out.rpartition(\u0027\u003d\u0027)[2].strip()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_07229c00","line":458,"updated":"2015-07-21 13:25:35.000000000","message":"s/ca_folder/ca_folder()/","commit_id":"c03e7e5a3563ab46dd6b5232940d8f347e586c8f"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6c594c6246403ea04609533f85fc5912eb9f63de","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # Change working dir to CA"},{"line_number":456,"context_line":"        fileutils.ensure_tree(ca_folder)"},{"line_number":457,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-batch\u0027, \u0027-out\u0027, outbound, \u0027-config\u0027,"},{"line_number":458,"context_line":"                      \u0027./openssl.cnf\u0027, \u0027-infiles\u0027, inbound, cwd\u003dca_folder)"},{"line_number":459,"context_line":"        out, _err \u003d utils.execute(\u0027openssl\u0027, \u0027x509\u0027, \u0027-in\u0027, outbound,"},{"line_number":460,"context_line":"                                  \u0027-serial\u0027, \u0027-noout\u0027, cwd\u003dca_folder)"},{"line_number":461,"context_line":"        serial \u003d out.rpartition(\u0027\u003d\u0027)[2].strip()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_1fdd00e0","line":458,"in_reply_to":"3a50d1a3_07229c00","updated":"2015-07-21 14:12:42.000000000","message":"Alex, see the line 471 in the old code. it says:\n\n    os.chdir(ca_folder)","commit_id":"c03e7e5a3563ab46dd6b5232940d8f347e586c8f"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"eaa6b672bd28a02d80112f7850586e61b0271060","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # Change working dir to CA"},{"line_number":456,"context_line":"        fileutils.ensure_tree(ca_folder)"},{"line_number":457,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-batch\u0027, \u0027-out\u0027, outbound, \u0027-config\u0027,"},{"line_number":458,"context_line":"                      \u0027./openssl.cnf\u0027, \u0027-infiles\u0027, inbound, cwd\u003dca_folder)"},{"line_number":459,"context_line":"        out, _err \u003d utils.execute(\u0027openssl\u0027, \u0027x509\u0027, \u0027-in\u0027, outbound,"},{"line_number":460,"context_line":"                                  \u0027-serial\u0027, \u0027-noout\u0027, cwd\u003dca_folder)"},{"line_number":461,"context_line":"        serial \u003d out.rpartition(\u0027\u003d\u0027)[2].strip()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_f2edec25","line":458,"in_reply_to":"3a50d1a3_07229c00","updated":"2015-07-21 13:34:30.000000000","message":"Nope, ca_folder is a kwarg to the method here.  I\u0027d argue that it should have a different name to avoid confusion such as this, but the code is correct.","commit_id":"c03e7e5a3563ab46dd6b5232940d8f347e586c8f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6510aa355cee0630e6aaea32c599106b80b4c1be","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # Change working dir to CA"},{"line_number":456,"context_line":"        fileutils.ensure_tree(ca_folder)"},{"line_number":457,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-batch\u0027, \u0027-out\u0027, outbound, \u0027-config\u0027,"},{"line_number":458,"context_line":"                      \u0027./openssl.cnf\u0027, \u0027-infiles\u0027, inbound, cwd\u003dca_folder)"},{"line_number":459,"context_line":"        out, _err \u003d utils.execute(\u0027openssl\u0027, \u0027x509\u0027, \u0027-in\u0027, outbound,"},{"line_number":460,"context_line":"                                  \u0027-serial\u0027, \u0027-noout\u0027, cwd\u003dca_folder)"},{"line_number":461,"context_line":"        serial \u003d out.rpartition(\u0027\u003d\u0027)[2].strip()"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_56e25830","line":458,"in_reply_to":"3a50d1a3_1fdd00e0","updated":"2015-07-22 12:32:03.000000000","message":"oops, sorry, my mistake","commit_id":"c03e7e5a3563ab46dd6b5232940d8f347e586c8f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"09d809f20af6a81b8b60bc3972d3637a66c01988","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-batch\u0027, \u0027-out\u0027, outbound, \u0027-config\u0027,"},{"line_number":458,"context_line":"                      \u0027./openssl.cnf\u0027, \u0027-infiles\u0027, inbound, cwd\u003dca_folder)"},{"line_number":459,"context_line":"        out, _err \u003d utils.execute(\u0027openssl\u0027, \u0027x509\u0027, \u0027-in\u0027, outbound,"},{"line_number":460,"context_line":"                                  \u0027-serial\u0027, \u0027-noout\u0027, cwd\u003dca_folder)"},{"line_number":461,"context_line":"        serial \u003d out.rpartition(\u0027\u003d\u0027)[2].strip()"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        with open(outbound, \u0027r\u0027) as crtfile:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_271d58bd","line":460,"updated":"2015-07-21 13:25:35.000000000","message":"ditto","commit_id":"c03e7e5a3563ab46dd6b5232940d8f347e586c8f"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"eaa6b672bd28a02d80112f7850586e61b0271060","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        utils.execute(\u0027openssl\u0027, \u0027ca\u0027, \u0027-batch\u0027, \u0027-out\u0027, outbound, \u0027-config\u0027,"},{"line_number":458,"context_line":"                      \u0027./openssl.cnf\u0027, \u0027-infiles\u0027, inbound, cwd\u003dca_folder)"},{"line_number":459,"context_line":"        out, _err \u003d utils.execute(\u0027openssl\u0027, \u0027x509\u0027, \u0027-in\u0027, outbound,"},{"line_number":460,"context_line":"                                  \u0027-serial\u0027, \u0027-noout\u0027, cwd\u003dca_folder)"},{"line_number":461,"context_line":"        serial \u003d out.rpartition(\u0027\u003d\u0027)[2].strip()"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        with open(outbound, \u0027r\u0027) as crtfile:"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a50d1a3_d2d1d058","line":460,"in_reply_to":"3a50d1a3_271d58bd","updated":"2015-07-21 13:34:30.000000000","message":"Ditto.","commit_id":"c03e7e5a3563ab46dd6b5232940d8f347e586c8f"}]}