)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9bc906c9ba7f1c8431365087b96147e1ff847d40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"But without message this exception is quite misleading - looks like"},{"line_number":11,"context_line":"source or source id was specified incorrectly."},{"line_number":12,"context_line":"So now this validation raises InvalidBDMFormat exception, which is"},{"line_number":13,"context_line":"quite closer to this case than invalid boor sequence."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5bba1a25d30500b000e95dcd6324fcb43138f694"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_18b0e042","line":13,"updated":"2015-06-15 17:31:51.000000000","message":"boor \u003d\u003e boot","commit_id":"1f956454443bc2a98738ea28fba946b90301804e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"869109f291583c04dd986cf46b94ae2f98a0b81a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current message this exception is quite misleading - looks like"},{"line_number":10,"context_line":"source or source id was specified incorrectly. But this exception"},{"line_number":11,"context_line":"is never rised in such case."},{"line_number":12,"context_line":"So fill message with details and raise it with correct ones."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5bba1a25d30500b000e95dcd6324fcb43138f694"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_8bd78022","line":11,"updated":"2015-06-16 18:05:30.000000000","message":"rised -\u003e raised?","commit_id":"c54c2e4c69a87f63df2e3f3d5e2ddffebb926b16"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"88de7f72dd4559640021d2368af780b88a0d5963","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current message this exception is quite misleading - looks like"},{"line_number":10,"context_line":"source or source id was specified incorrectly. But this exception"},{"line_number":11,"context_line":"is never rised in such case."},{"line_number":12,"context_line":"So fill message with details and raise it with correct ones."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5bba1a25d30500b000e95dcd6324fcb43138f694"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_44ea6175","line":11,"in_reply_to":"fa32b979_8bd78022","updated":"2015-06-18 15:17:39.000000000","message":"Done","commit_id":"c54c2e4c69a87f63df2e3f3d5e2ddffebb926b16"}],"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9bc906c9ba7f1c8431365087b96147e1ff847d40","unresolved":false,"context_lines":[{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        if 0 not in boot_indexes or not _subsequent_list(boot_indexes):"},{"line_number":1221,"context_line":"            msg \u003d _(\"Incorrect boot index\")"},{"line_number":1222,"context_line":"            raise exception.InvalidBDMFormat(details\u003dmsg)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for bdm in all_mappings:"},{"line_number":1225,"context_line":"            # NOTE(vish): For now, just make sure the volumes are accessible."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_983710b0","line":1222,"range":{"start_line":1222,"start_character":28,"end_line":1222,"end_character":44},"updated":"2015-06-15 17:31:51.000000000","message":"I do not think that this is correct. The format does not have anything to do with the BootSequence.\nCan you consider adding a reason to the boot sequence or introducing a new exception?","commit_id":"1f956454443bc2a98738ea28fba946b90301804e"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"29ba26c5aabad5c0b0a528147799138fcddc64c6","unresolved":false,"context_lines":[{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        if 0 not in boot_indexes or not _subsequent_list(boot_indexes):"},{"line_number":1221,"context_line":"            msg \u003d _(\"Incorrect boot index\")"},{"line_number":1222,"context_line":"            raise exception.InvalidBDMFormat(details\u003dmsg)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for bdm in all_mappings:"},{"line_number":1225,"context_line":"            # NOTE(vish): For now, just make sure the volumes are accessible."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5883c8cc","line":1222,"range":{"start_line":1222,"start_character":28,"end_line":1222,"end_character":44},"in_reply_to":"fa32b979_983710b0","updated":"2015-06-15 17:44:20.000000000","message":"Yes, just thought about reason for boot sequence exceptions, it will made this type of exceptions quite clearer. Will do.","commit_id":"1f956454443bc2a98738ea28fba946b90301804e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"869109f291583c04dd986cf46b94ae2f98a0b81a","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"                               and bdm.boot_index \u003e\u003d 0])"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        if 0 not in boot_indexes or not _subsequent_list(boot_indexes):"},{"line_number":1221,"context_line":"            msg \u003d _(\"Incorrect boot index\")"},{"line_number":1222,"context_line":"            raise exception.InvalidBDMBootSequence(details\u003dmsg)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for bdm in all_mappings:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8b2f80f5","line":1221,"updated":"2015-06-16 18:05:30.000000000","message":"can we print more info here e.g boot_indexes not have 0 etc?","commit_id":"c54c2e4c69a87f63df2e3f3d5e2ddffebb926b16"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"88de7f72dd4559640021d2368af780b88a0d5963","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"                               and bdm.boot_index \u003e\u003d 0])"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        if 0 not in boot_indexes or not _subsequent_list(boot_indexes):"},{"line_number":1221,"context_line":"            msg \u003d _(\"Incorrect boot index\")"},{"line_number":1222,"context_line":"            raise exception.InvalidBDMBootSequence(details\u003dmsg)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for bdm in all_mappings:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_84cdc932","line":1221,"in_reply_to":"fa32b979_8b2f80f5","updated":"2015-06-18 15:17:39.000000000","message":"I think it\u0027s unnecessary info. This exception can be raised in different cases, all of them is covered in documentation. I think it\u0027s enough to specify in which option mistake is","commit_id":"c54c2e4c69a87f63df2e3f3d5e2ddffebb926b16"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"75f921b6559cb5bc93e275d6e4a69b6337d5005f","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"                               and bdm.boot_index \u003e\u003d 0])"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        if 0 not in boot_indexes or not _subsequent_list(boot_indexes):"},{"line_number":1221,"context_line":"            msg \u003d _(\"Incorrect boot index\")"},{"line_number":1222,"context_line":"            raise exception.InvalidBDMBootSequence(details\u003dmsg)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for bdm in all_mappings:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_9e40f535","line":1221,"updated":"2015-08-06 06:10:48.000000000","message":"But it doesn\u0027t bring any useful detail. Currently the exception message already contains key phrase \u0027boot sequence\u0027. But as it is mentioned in docs, boot sequience is defined by boot index attribute.\n\nWhat if to add details about what exactly is wrong? Cases we have are:\n\n- no bdm with boot index \u003d 0\n- several bdms with the same non negative boot index (which index?)\n- a hole in boot indexes sequience (which index is missed?)","commit_id":"8173ac8f0a59b4d04d4f2870ad012757c945d9d7"}],"nova/exception.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"869109f291583c04dd986cf46b94ae2f98a0b81a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"class InvalidBDMBootSequence(InvalidBDM):"},{"line_number":229,"context_line":"    msg_fmt \u003d _(\"Block Device Mapping is Invalid: \""},{"line_number":230,"context_line":"                \"Boot sequence for the instance is \""},{"line_number":231,"context_line":"                \"not valid: %(details)s\")"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class InvalidBDMLocalsLimit(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cba9087d","line":231,"updated":"2015-06-16 18:05:30.000000000","message":"this will make the error looks like:\nBoot sequence for the instance is not valid: Incorrect boot index","commit_id":"c54c2e4c69a87f63df2e3f3d5e2ddffebb926b16"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"88de7f72dd4559640021d2368af780b88a0d5963","unresolved":false,"context_lines":[{"line_number":228,"context_line":"class InvalidBDMBootSequence(InvalidBDM):"},{"line_number":229,"context_line":"    msg_fmt \u003d _(\"Block Device Mapping is Invalid: \""},{"line_number":230,"context_line":"                \"Boot sequence for the instance is \""},{"line_number":231,"context_line":"                \"not valid: %(details)s\")"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class InvalidBDMLocalsLimit(InvalidBDM):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_24e71dad","line":231,"in_reply_to":"fa32b979_cba9087d","updated":"2015-06-18 15:17:39.000000000","message":"Yes. What is the problem with such message?","commit_id":"c54c2e4c69a87f63df2e3f3d5e2ddffebb926b16"}]}