)]}'
{"nova/tests/unit/api/openstack/compute/contrib/test_security_groups.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"814b7561e8d24a22e08af53c8f56ba6973eb0dff","unresolved":false,"context_lines":[{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Delete the security group by admin."},{"line_number":584,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/os-security-groups/2\u0027,"},{"line_number":585,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":586,"context_line":"        self.controller.delete(req, \u00272\u0027)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        # Ensure quota for security group in use is released."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_eadb094e","line":585,"updated":"2015-06-19 16:06:27.000000000","message":"If  \u00272\u0027 is sec_group.id, why do you use constant here? Is it possible that create request return sec_group with id different from 2?","commit_id":"fa8c32fdc907788a97be1f733432e5b2c3025350"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"441f5866be6bc62eafe61f499dcc2245523b22df","unresolved":false,"context_lines":[{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Delete the security group by admin."},{"line_number":584,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/os-security-groups/2\u0027,"},{"line_number":585,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":586,"context_line":"        self.controller.delete(req, \u00272\u0027)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        # Ensure quota for security group in use is released."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_fd72a410","line":585,"in_reply_to":"fa32b979_eadb094e","updated":"2015-06-23 00:53:18.000000000","message":"Actually, this url including \"2\" is not used at all on this unit test because the method \"self.controller.delet\" doesn\u0027t refer it in the code.\nSo this url is meaningless, and some guys tried to remove it on the other patch, but I will not do it on *this* patch because the patch scope leak.","commit_id":"fa8c32fdc907788a97be1f733432e5b2c3025350"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6badaa7c01d5730ca7b1e06ebf6f757bba2339e1","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        # Delete the security group by admin."},{"line_number":584,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/os-security-groups/2\u0027,"},{"line_number":585,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":586,"context_line":"        self.controller.delete(req, \u00272\u0027)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        # Ensure quota for security group in use is released."},{"line_number":589,"context_line":"        self._assert_security_groups_in_use(context.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_45d46646","line":586,"updated":"2015-06-19 16:24:49.000000000","message":"You should use sec_group.id from create response, usage of the magic constant is a bad idea.","commit_id":"fa8c32fdc907788a97be1f733432e5b2c3025350"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"441f5866be6bc62eafe61f499dcc2245523b22df","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        # Delete the security group by admin."},{"line_number":584,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/os-security-groups/2\u0027,"},{"line_number":585,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":586,"context_line":"        self.controller.delete(req, \u00272\u0027)"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        # Ensure quota for security group in use is released."},{"line_number":589,"context_line":"        self._assert_security_groups_in_use(context.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bdcadc18","line":586,"in_reply_to":"fa32b979_45d46646","updated":"2015-06-23 00:53:18.000000000","message":"Yeah, but that already exists before this patch.\nSo it is necessary to fix it on the other patch because of the patch scope.","commit_id":"fa8c32fdc907788a97be1f733432e5b2c3025350"}]}