)]}'
{"nova/network/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84935409f9908a5222b0b65b6ad8ae69f46562ba","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            self.network_rpcapi.update_dns(context, network_ids)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        net_info \u003d self.get_instance_nw_info(admin_context, instance_uuid,"},{"line_number":507,"context_line":"                                             rxtx_factor, host)"},{"line_number":508,"context_line":"        LOG.info(_LI(\"Allocated network: \u0027%s\u0027 for instance\"), net_info,"},{"line_number":509,"context_line":"                 instance_uuid\u003dinstance_uuid,"},{"line_number":510,"context_line":"                 context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c1732714","line":507,"updated":"2015-06-16 18:44:03.000000000","message":"net_info is coming back as [] when this fails:\n\nhttp://logs.openstack.org/69/190169/3/check/check-tempest-dsvm-full-glusterfs-nv/eecdc4e/logs/screen-n-net.txt.gz#_2015-06-11_14_39_50_479\n\nSo this should probably be a warning?  Or just fail network setup since things aren\u0027t going to work if there is no fixed IP associated with the instance.","commit_id":"6488d26be2cba5416399c854f225a5e0d6505be2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2829dc222b07346fbb88ef0d3d6a2d17f1f61383","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            self.network_rpcapi.update_dns(context, network_ids)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        net_info \u003d self.get_instance_nw_info(admin_context, instance_uuid,"},{"line_number":507,"context_line":"                                             rxtx_factor, host)"},{"line_number":508,"context_line":"        LOG.info(_LI(\"Allocated network: \u0027%s\u0027 for instance\"), net_info,"},{"line_number":509,"context_line":"                 instance_uuid\u003dinstance_uuid,"},{"line_number":510,"context_line":"                 context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d3e36804","line":507,"in_reply_to":"fa32b979_c1732714","updated":"2015-06-19 14:27:33.000000000","message":"Although the multinic extension allows you to add more fixed IPs to the instance so I\u0027m not sure that it\u0027s required that you have a fixed IP once you\u0027re done creating the instance:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/multinic.py#n41\n\nBut it sure seems you\u0027d assume that you\u0027d have/want/need one in 99% of cases.","commit_id":"6488d26be2cba5416399c854f225a5e0d6505be2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae16463e70b98c1f710bb76bda8ee89593b0409c","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        vifs \u003d collections.OrderedDict()"},{"line_number":603,"context_line":"        for fixed_ip in fixed_ips:"},{"line_number":604,"context_line":"            vif \u003d fixed_ip.virtual_interface"},{"line_number":605,"context_line":"            if not vif:"},{"line_number":606,"context_line":"                continue"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"            if not fixed_ip.network:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_13d550b8","line":605,"updated":"2015-06-19 14:37:29.000000000","message":"This shouldn\u0027t happen at least for the FlatDHCPManager since we attempt to create a VIF if one isn\u0027t available, or we timeout and fail.","commit_id":"6488d26be2cba5416399c854f225a5e0d6505be2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae16463e70b98c1f710bb76bda8ee89593b0409c","unresolved":false,"context_lines":[{"line_number":772,"context_line":"            except exception.VirtualInterfaceCreateException:"},{"line_number":773,"context_line":"                # Try again up to max number of attempts"},{"line_number":774,"context_line":"                pass"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"        raise exception.VirtualInterfaceMacAddressException()"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"    def add_fixed_ip_to_instance(self, context, instance_id, host, network_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f39d4c0b","line":775,"updated":"2015-06-19 14:37:29.000000000","message":"This is where we fail if we can\u0027t create a VIF for the fixed IP.","commit_id":"6488d26be2cba5416399c854f225a5e0d6505be2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae16463e70b98c1f710bb76bda8ee89593b0409c","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                              \u0027in network %(network)s on subnet %(cidr)s.\u0027 %"},{"line_number":898,"context_line":"                              {\u0027network\u0027: network[\u0027id\u0027],"},{"line_number":899,"context_line":"                               \u0027cidr\u0027: network[\u0027cidr\u0027]},"},{"line_number":900,"context_line":"                              instance\u003dinstance)"},{"line_number":901,"context_line":"                    fip \u003d objects.FixedIP.associate_pool("},{"line_number":902,"context_line":"                        context.elevated(), network[\u0027id\u0027], instance_id)"},{"line_number":903,"context_line":"                    address \u003d str(fip.address)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_73805c8c","line":900,"updated":"2015-06-19 14:37:29.000000000","message":"We should probably log this fip since get_nw_instance_info checks to see if fip.network is there and if not it skips it - we should log this and log there as well if we skip.","commit_id":"6488d26be2cba5416399c854f225a5e0d6505be2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"221d5e292539662c0c2dde5c325ebe831d50760c","unresolved":false,"context_lines":[{"line_number":904,"context_line":"                              instance\u003dinstance)"},{"line_number":905,"context_line":"                    fip \u003d objects.FixedIP.associate_pool("},{"line_number":906,"context_line":"                        context.elevated(), network[\u0027id\u0027], instance_id)"},{"line_number":907,"context_line":"                    LOG.debug(\u0027Associated instance with fixed IP: %s\u0027, fip,"},{"line_number":908,"context_line":"                              instance\u003dinstance)"},{"line_number":909,"context_line":"                    address \u003d str(fip.address)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_68430c14","line":907,"updated":"2015-06-23 16:13:31.000000000","message":"In a failure case with this logging, we see the fixed IP associated here:\n\nhttp://logs.openstack.org/42/175742/10/check/check-tempest-dsvm-nova-v21-full/2850b02/logs/screen-n-net.txt.gz#_2015-06-23_05_10_55_382\n\nNote that leased\u003dFalse and allocated\u003dFalse.","commit_id":"b536ff12ae92e728033cb81eeba9a03fd1c81a41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9a53d15c7fc5d1f6fb116f412bd014b91a71f97c","unresolved":false,"context_lines":[{"line_number":916,"context_line":"                              {\u0027network\u0027: network[\u0027id\u0027]}, instance\u003dinstance)"},{"line_number":917,"context_line":"                    vif \u003d self._add_virtual_interface(context,"},{"line_number":918,"context_line":"                        instance_id, network[\u0027id\u0027])"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"                fip.allocated \u003d True"},{"line_number":921,"context_line":"                fip.virtual_interface_id \u003d vif.id"},{"line_number":922,"context_line":"                fip.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_be8dce7d","line":919,"updated":"2015-06-23 16:50:36.000000000","message":"Ah, here is the race.  So we should try to create the vif first and just do all of this in a lock or something.","commit_id":"b536ff12ae92e728033cb81eeba9a03fd1c81a41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"221d5e292539662c0c2dde5c325ebe831d50760c","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"                        context\u003dcontext)"},{"line_number":1108,"context_line":"            return"},{"line_number":1109,"context_line":"        if not fixed_ip.leased:"},{"line_number":1110,"context_line":"            LOG.warning(_LW(\u0027IP %s released that was not leased\u0027), address,"},{"line_number":1111,"context_line":"                        context\u003dcontext, instance_uuid\u003dfixed_ip.instance_uuid)"},{"line_number":1112,"context_line":"        fixed_ip.leased \u003d False"},{"line_number":1113,"context_line":"        fixed_ip.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_685a2cf4","line":1110,"updated":"2015-06-23 16:13:31.000000000","message":"Later, note the warning on the same fixed IP here:\n\nhttp://logs.openstack.org/42/175742/10/check/check-tempest-dsvm-nova-v21-full/2850b02/logs/screen-n-net.txt.gz#_2015-06-23_05_10_55_459","commit_id":"b536ff12ae92e728033cb81eeba9a03fd1c81a41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"221d5e292539662c0c2dde5c325ebe831d50760c","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"                        context\u003dcontext, instance_uuid\u003dfixed_ip.instance_uuid)"},{"line_number":1112,"context_line":"        fixed_ip.leased \u003d False"},{"line_number":1113,"context_line":"        fixed_ip.save()"},{"line_number":1114,"context_line":"        if not fixed_ip.allocated:"},{"line_number":1115,"context_line":"            fixed_ip.disassociate()"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_88d45020","line":1114,"updated":"2015-06-23 16:13:31.000000000","message":"And then because it\u0027s not allocated yet, it\u0027s disassociated which results in get_instance_nw_info() not finding any fixed IPs to build the network info cache for the instance:\n\nhttp://logs.openstack.org/42/175742/10/check/check-tempest-dsvm-nova-v21-full/2850b02/logs/screen-n-net.txt.gz#_2015-06-23_05_10_55_731","commit_id":"b536ff12ae92e728033cb81eeba9a03fd1c81a41"}]}