)]}'
{"nova/network/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"086d1c388477a87dc1da2046ecc16a938422960d","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            network_ref \u003d objects.Network._from_db_object("},{"line_number":355,"context_line":"                context, objects.Network(), network_ref)"},{"line_number":356,"context_line":"        LOG.debug(\u0027Setting host %s for network %s\u0027, self.host,"},{"line_number":357,"context_line":"                  network_ref[\u0027uuid\u0027], context\u003dcontext)"},{"line_number":358,"context_line":"        network_ref.host \u003d self.host"},{"line_number":359,"context_line":"        network_ref.save()"},{"line_number":360,"context_line":"        return self.host"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_11ce1a2e","line":357,"updated":"2015-06-17 13:44:50.000000000","message":"This could be network_ref.uuid.","commit_id":"3fd4b1230580eb33b69fe2583c6ed182a6b8582d"}],"nova/network/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"48b4faab1c6ce86797cb2f4bf62a5d73108a291a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        version \u003d \u00271.14\u0027"},{"line_number":248,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":249,"context_line":"            version \u003d \u00271.0\u0027"},{"line_number":250,"context_line":"            network_ref \u003d jsonutils.to_primitive(network_ref)"},{"line_number":251,"context_line":"        cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":252,"context_line":"        return cctxt.call(ctxt, \u0027set_network_host\u0027, network_ref\u003dnetwork_ref)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_dac5508e","line":250,"updated":"2015-06-16 19:39:45.000000000","message":"This should be (and should have been) base.obj_to_primitive(), just to make sure we handle datetimes and such properly. When we come across instances like this, we usually fix it.","commit_id":"7da087c9415462ac31b3843c0ae580755dac2ca0"}],"nova/tests/unit/network/test_rpcapi.py":[{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"b21eff9a51eb8171b8b41caaa7f57d9d5b8581bd","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    def test_set_network_host(self):"},{"line_number":207,"context_line":"        network \u003d fake_network.fake_network_obj(context.get_admin_context())"},{"line_number":208,"context_line":"        self._test_network_api(\u0027set_network_host\u0027, rpc_method\u003d\u0027call\u0027,"},{"line_number":209,"context_line":"                               network_ref\u003dnetwork, version\u003d\u00271.14\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_rpc_setup_network_on_host(self):"},{"line_number":212,"context_line":"        self._test_network_api(\u0027rpc_setup_network_on_host\u0027, rpc_method\u003d\u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_aeadb289","line":209,"updated":"2015-06-23 10:17:25.000000000","message":"Matt, should we add another test here to call set_network_host() v1.0, which passes a network_ref dict?","commit_id":"f38f926f8327320a040d35dfe56fcb0006b8b6f1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"244ae185c581c6ac99029821e8cdfd960f2d5db0","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    def test_set_network_host(self):"},{"line_number":207,"context_line":"        network \u003d fake_network.fake_network_obj(context.get_admin_context())"},{"line_number":208,"context_line":"        self._test_network_api(\u0027set_network_host\u0027, rpc_method\u003d\u0027call\u0027,"},{"line_number":209,"context_line":"                               network_ref\u003dnetwork, version\u003d\u00271.14\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_rpc_setup_network_on_host(self):"},{"line_number":212,"context_line":"        self._test_network_api(\u0027rpc_setup_network_on_host\u0027, rpc_method\u003d\u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_2050add3","line":209,"in_reply_to":"fa32b979_aeadb289","updated":"2015-06-23 22:00:18.000000000","message":"I can look into it, I\u0027d have to mess with _test_network_api.  I guess I didn\u0027t figure it\u0027d be an issue since we don\u0027t typically test all versions in the rpc api tests, like how test_deallocate_fixed_ip is assuming it\u0027s at least version 1.12.","commit_id":"f38f926f8327320a040d35dfe56fcb0006b8b6f1"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"81133c184194eb785fb670819bd7dea4ca207712","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_set_network_host_network_object_to_primitive(self):"},{"line_number":241,"context_line":"        # Tests that the network object is converted to a primitive if it"},{"line_number":242,"context_line":"        # can\u0027t send version 1.14."},{"line_number":243,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake_user\u0027, \u0027fake_project\u0027)"},{"line_number":244,"context_line":"        network \u003d fake_network.fake_network_obj(ctxt)"},{"line_number":245,"context_line":"        network_dict \u003d objects_base.obj_to_primitive(network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_177118a8","line":242,"updated":"2015-07-22 18:20:53.000000000","message":"I think you mean version 1.15","commit_id":"266acfe6ffab796e9305a10f1ee561e9642a057b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"392dc3456a1d2c0c1acb403d058e25481a0c05b6","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_set_network_host_network_object_to_primitive(self):"},{"line_number":241,"context_line":"        # Tests that the network object is converted to a primitive if it"},{"line_number":242,"context_line":"        # can\u0027t send version 1.14."},{"line_number":243,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake_user\u0027, \u0027fake_project\u0027)"},{"line_number":244,"context_line":"        network \u003d fake_network.fake_network_obj(ctxt)"},{"line_number":245,"context_line":"        network_dict \u003d objects_base.obj_to_primitive(network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_3f198ad7","line":242,"in_reply_to":"3a50d1a3_177118a8","updated":"2015-07-22 19:39:18.000000000","message":"Gah, yes, rebase fail. Thanks.","commit_id":"266acfe6ffab796e9305a10f1ee561e9642a057b"}]}