)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"83f1818ad95d5fe736f421c55ad88e167befe778","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-03 11:17:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The oslo_incubator code was replaced by oslo.incubator library"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Author: Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":10,"context_line":"Depends-On: I305cf53bad6213c151395e93d656b53a8a28e1db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba3cc151_5cf6a75d","line":7,"updated":"2015-07-03 11:19:39.000000000","message":"code from incubator was replaced by code from incubator... it looks strange... a bit:)","commit_id":"5dec99c6660e4228078f92a0f662742394631369"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ab8b0e4ac84c11dabfc20094ff7678628663359b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-03 11:17:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The oslo_incubator code was replaced by oslo.incubator library"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Author: Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":10,"context_line":"Depends-On: I305cf53bad6213c151395e93d656b53a8a28e1db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba3cc151_5c522736","line":7,"in_reply_to":"ba3cc151_5cf6a75d","updated":"2015-07-03 11:22:27.000000000","message":"AFAICT, this is not introducing use of an oslo.incubator library. It is using an oslo.service library, so most oslo-incubator code is still present in Nova. Please fix this commit message.","commit_id":"5dec99c6660e4228078f92a0f662742394631369"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"2d50b2b5f3cb8535cf2c05d2561d6ccd34d6d54c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-03 11:17:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The oslo_incubator code was replaced by oslo.incubator library"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Author: Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":10,"context_line":"Depends-On: I305cf53bad6213c151395e93d656b53a8a28e1db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba3cc151_bc425366","line":7,"in_reply_to":"ba3cc151_5cf6a75d","updated":"2015-07-03 11:22:02.000000000","message":"Agree, \"Switch to oslo.service\" or something like that would be better","commit_id":"5dec99c6660e4228078f92a0f662742394631369"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"87ecdc3a9380985a3d43b52df05f56a793f644ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-03 12:24:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch to oslo.incubator library"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modules eventlet_backdoor, loopingcall, periodic_task,"},{"line_number":10,"context_line":"service, sslutils, systemd, threadgroup were removed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba3cc151_f0623a3d","line":7,"updated":"2015-07-03 12:28:53.000000000","message":"\"Switch to graduated oslo.service\" sounds better for me","commit_id":"654f27319f18d0c697a27b89fdf19d289b196f3a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e380dca8bba0a1e6b7be617cf882adea0665ffd9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-03 12:24:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch to oslo.incubator library"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modules eventlet_backdoor, loopingcall, periodic_task,"},{"line_number":10,"context_line":"service, sslutils, systemd, threadgroup were removed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba3cc151_5043e6ae","line":7,"updated":"2015-07-03 12:27:08.000000000","message":"Again, there is no oslo.incubator library - this patch is using a oslo.service library.","commit_id":"654f27319f18d0c697a27b89fdf19d289b196f3a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e380dca8bba0a1e6b7be617cf882adea0665ffd9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Modules eventlet_backdoor, loopingcall, periodic_task,"},{"line_number":10,"context_line":"service, sslutils, systemd, threadgroup were removed"},{"line_number":11,"context_line":"from nova. These modules were imported from oslo.incubator"},{"line_number":12,"context_line":"library. "},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Author: Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":15,"context_line":"Depends-On: I305cf53bad6213c151395e93d656b53a8a28e1db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba3cc151_3048a2cb","line":12,"updated":"2015-07-03 12:27:08.000000000","message":"Likewise","commit_id":"654f27319f18d0c697a27b89fdf19d289b196f3a"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"96c7186bac8a6fef4d7b426e29169c3f0921f0f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modules eventlet_backdoor, loopingcall, periodic_task,"},{"line_number":10,"context_line":"service, sslutils, systemd, threadgroup were removed"},{"line_number":11,"context_line":"from nova. These modules were imported from oslo.incubator"},{"line_number":12,"context_line":"library."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Author: Marian Horban \u003cmhorban@mirantis.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba3cc151_eb848f5e","line":11,"updated":"2015-07-03 12:36:56.000000000","message":"I\u0027m afraid, you\u0027ll have to fix this line too :)","commit_id":"21289152d636ba5647a02ee9c051cac5142dcdd1"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"3c18bb56bc7ac066caa725e18147674617b9f0a9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modules eventlet_backdoor, loopingcall, periodic_task,"},{"line_number":10,"context_line":"service, sslutils, systemd, threadgroup were removed"},{"line_number":11,"context_line":"from nova. These modules were imported from oslo.incubator"},{"line_number":12,"context_line":"library."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Author: Marian Horban \u003cmhorban@mirantis.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba3cc151_2be6f743","line":11,"in_reply_to":"ba3cc151_eb848f5e","updated":"2015-07-03 12:38:56.000000000","message":"oh )))","commit_id":"21289152d636ba5647a02ee9c051cac5142dcdd1"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"e5c8bb713eca0c9a6466422efae85500c268f581","unresolved":false,"context_lines":[{"line_number":11,"context_line":"from nova. These modules were imported from oslo.service"},{"line_number":12,"context_line":"library."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Marian Horban \u003cmhorban@mirantis.com\u003e"},{"line_number":15,"context_line":"Depends-On: I305cf53bad6213c151395e93d656b53a8a28e1db"},{"line_number":16,"context_line":"Change-Id: Iaef67e16af3d69f845742f7bdcb43667bf1576ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"3a50d1a3_0b944935","line":14,"updated":"2015-07-19 06:28:21.000000000","message":"Hi, this review will fixed \nhttps://bugs.launchpad.net/nova/+bug/1450438\nDoes it need to add related-bug here?","commit_id":"79b280479c864d7c0f16e6b9fffd30662f2394c6"}],"etc/nova/nova-config-generator.conf":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"8d95f91624d3fbc0a39600a252594dfccd93333d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"namespace \u003d oslo.log"},{"line_number":14,"context_line":"namespace \u003d oslo.messaging"},{"line_number":15,"context_line":"namespace \u003d oslo.policy"},{"line_number":16,"context_line":"namespace \u003d oslo.service.eventlet_backdoor"},{"line_number":17,"context_line":"namespace \u003d oslo.service.periodic_task"},{"line_number":18,"context_line":"namespace \u003d oslo.service.sslutils"},{"line_number":19,"context_line":"namespace \u003d oslo.db"}],"source_content_type":"text/plain","patch_set":20,"id":"ba3cc151_4fb0abdd","line":16,"updated":"2015-07-07 18:15:42.000000000","message":"The oslo.service doesn\u0027t have the eventlet_backdoor entry point: https://github.com/openstack/oslo.service/blob/master/setup.cfg#L32-L34\n\nYou have to use oslo.service.service","commit_id":"0e3a7f0318974cddb8ae7098bc505afe572d6f0a"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"37bed07b92984d3443c4b27908d936ceeefee4d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"namespace \u003d oslo.log"},{"line_number":14,"context_line":"namespace \u003d oslo.messaging"},{"line_number":15,"context_line":"namespace \u003d oslo.policy"},{"line_number":16,"context_line":"namespace \u003d oslo.service.eventlet_backdoor"},{"line_number":17,"context_line":"namespace \u003d oslo.service.periodic_task"},{"line_number":18,"context_line":"namespace \u003d oslo.service.sslutils"},{"line_number":19,"context_line":"namespace \u003d oslo.db"}],"source_content_type":"text/plain","patch_set":20,"id":"ba3cc151_ed21724e","line":16,"in_reply_to":"ba3cc151_4fb0abdd","updated":"2015-07-08 06:13:35.000000000","message":"Done","commit_id":"0e3a7f0318974cddb8ae7098bc505afe572d6f0a"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"94cd684e5d00b7f388b0dfd221b49190196ab0b0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"namespace \u003d oslo.db"},{"line_number":20,"context_line":"namespace \u003d oslo.middleware"},{"line_number":21,"context_line":"namespace \u003d oslo.concurrency"},{"line_number":22,"context_line":"namespace \u003d keystonemiddleware.auth_token"}],"source_content_type":"text/plain","patch_set":22,"id":"ba3cc151_fefa3642","line":22,"updated":"2015-07-09 07:45:24.000000000","message":"this change is unrealted","commit_id":"6aa0660b96e3a2f166002e29f1a41d38940a6321"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"b542768708c13b9df1e060d138db55ccf14ff8ab","unresolved":false,"context_lines":[{"line_number":19,"context_line":"namespace \u003d oslo.db"},{"line_number":20,"context_line":"namespace \u003d oslo.middleware"},{"line_number":21,"context_line":"namespace \u003d oslo.concurrency"},{"line_number":22,"context_line":"namespace \u003d keystonemiddleware.auth_token"}],"source_content_type":"text/plain","patch_set":22,"id":"ba3cc151_f399e11f","line":22,"in_reply_to":"ba3cc151_40deb5da","updated":"2015-07-09 21:01:20.000000000","message":"Fixed.","commit_id":"6aa0660b96e3a2f166002e29f1a41d38940a6321"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"7cd921117f04b57f5ab9e8ffc708d3dbbcb4bcd9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"namespace \u003d oslo.db"},{"line_number":20,"context_line":"namespace \u003d oslo.middleware"},{"line_number":21,"context_line":"namespace \u003d oslo.concurrency"},{"line_number":22,"context_line":"namespace \u003d keystonemiddleware.auth_token"}],"source_content_type":"text/plain","patch_set":22,"id":"ba3cc151_40deb5da","line":22,"in_reply_to":"ba3cc151_fefa3642","updated":"2015-07-09 20:48:39.000000000","message":"There was no newline at end of file. Vim fixed it on his own.","commit_id":"6aa0660b96e3a2f166002e29f1a41d38940a6321"}],"nova/manager.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"0b5b729ead548eafd6ea4e3f68871e9a92f7b77a","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class Manager(base.Base, PeriodicTasks):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_c515ec49","line":69,"updated":"2015-06-19 08:36:29.000000000","message":"self might have a conf attribute. If so, you could try passing self.conf to __init__ and CONF in otherwise:\n\n    conf \u003d getattr(self, \"conf\", CONF)\n    super(PeriodicTasks, self).__init__(conf)\n\nPerhaps that would help","commit_id":"5049392a5cc45b16cbd087bb47eeaa364113ef52"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"f237fa209cdc26b07ec75f0f05fff7ef07c98740","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_89d588ba","line":68,"updated":"2015-06-22 08:59:13.000000000","message":"This function will never be executed. Please do It as in the Elena\u0027s patch: https://review.openstack.org/#/c/192999/10/neutron/manager.py","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"e336f8bd16c5ef252f1d10cbf1380d885d0a0fca","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_23d01053","line":68,"in_reply_to":"fa32b979_03238ca8","updated":"2015-06-22 10:59:42.000000000","message":"a better example: https://pastebin.com/LKHXNj0W","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"65f26a113d1e61ed360d2e4411b03657bf90b7fc","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_89bfbda9","line":68,"in_reply_to":"fa32b979_23d01053","updated":"2015-06-22 11:50:29.000000000","message":"Sergey, in these examples exist mistake.\nIn your example https://pastebin.com/LKHXNj0W, there is no call super().__init__() inside A.__init__() and B.__init__() methods. That\u0027s why not all __init__ methods are called.","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"69dc13a3500d6f5a4748ea9134c17939892de51d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_89a57d48","line":68,"in_reply_to":"fa32b979_23d01053","updated":"2015-06-22 11:56:32.000000000","message":"Sergey, nova and neutron examples are not the same. here, base.Base already has a __init__.py which takes in dbdriver parameter and the __init__ for PeriodicTasks does not. hence the helper.","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"68390a5e9ed8265eafbd3b375902f7fcf6fb0b0d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_03238ca8","line":68,"in_reply_to":"fa32b979_7a8b2169","updated":"2015-06-22 10:56:54.000000000","message":"Because the PeriodicTasks class is a mixin for the Manager.\nAn example: https://pastebin.com/u9NgAmzd","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"4618cd5167b55fa024cf671065a5cd0fdfd455ab","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_219c855c","line":68,"in_reply_to":"fa32b979_89a57d48","updated":"2015-06-22 12:46:32.000000000","message":"Guys, Thank you very much, You have opened my eyes :) Yep. The super() int the A class fixes this problem :)","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"40b9b00c44fba07f9068e475d4196e8aa4c54dc6","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_7a8b2169","line":68,"in_reply_to":"fa32b979_89d588ba","updated":"2015-06-22 09:45:17.000000000","message":"Please explain why this function will never be executed.","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"d37b13f7659ad2d96f81e3614d3300a8dae39d14","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class PeriodicTasks(periodic_task.PeriodicTasks):"},{"line_number":68,"context_line":"    def __init__(self):"},{"line_number":69,"context_line":"        super(PeriodicTasks, self).__init__(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_7d18fb75","line":68,"in_reply_to":"fa32b979_89d588ba","updated":"2015-06-22 10:09:41.000000000","message":"Sergey, this is the only way i could get it to work. please try it and let me know if the alternate specified works.","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"}],"nova/opts.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"f9cd9d10198f680ba18af26afe2836e642003254","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ssl_opts \u003d ["},{"line_number":19,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":20,"context_line":"               help\u003d\"CA certificate file to use to verify \""},{"line_number":21,"context_line":"                    \"connecting clients.\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_ac9b88c8","line":18,"updated":"2015-06-23 04:55:39.000000000","message":"These options are also implemented in the oslo_service._options module. May we reuse It?","commit_id":"d00cac57c42598952e2dc720cf970f0c8f473bd4"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c44538e420be8c19c2e7d0f6841195d96a160638","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ssl_opts \u003d ["},{"line_number":19,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":20,"context_line":"               help\u003d\"CA certificate file to use to verify \""},{"line_number":21,"context_line":"                    \"connecting clients.\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_c1d6c7f0","line":18,"in_reply_to":"fa32b979_ac9b88c8","updated":"2015-06-23 10:34:25.000000000","message":"we can add that in the next review as we will need to figure out a way to support the older entries in config file as well as the newer style (with \"oslo_service\" group)","commit_id":"d00cac57c42598952e2dc720cf970f0c8f473bd4"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"f9cd9d10198f680ba18af26afe2836e642003254","unresolved":false,"context_lines":[{"line_number":8144,"context_line":"                          block_device_info)"},{"line_number":8145,"context_line":""},{"line_number":8146,"context_line":"    @mock.patch(\u0027nova.openstack.common.fileutils.ensure_tree\u0027)"},{"line_number":8147,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":8148,"context_line":"    @mock.patch(\u0027nova.pci.manager.get_instance_pci_devs\u0027)"},{"line_number":8149,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._prepare_pci_devices_for_use\u0027)"},{"line_number":8150,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._create_domain_and_network\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_cc612caa","line":8147,"updated":"2015-06-23 04:55:39.000000000","message":"Could you move this line to the first or last position? Because, as you can see, all the elements of the list are sorted alphabetically.","commit_id":"d00cac57c42598952e2dc720cf970f0c8f473bd4"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c44538e420be8c19c2e7d0f6841195d96a160638","unresolved":false,"context_lines":[{"line_number":8144,"context_line":"                          block_device_info)"},{"line_number":8145,"context_line":""},{"line_number":8146,"context_line":"    @mock.patch(\u0027nova.openstack.common.fileutils.ensure_tree\u0027)"},{"line_number":8147,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027)"},{"line_number":8148,"context_line":"    @mock.patch(\u0027nova.pci.manager.get_instance_pci_devs\u0027)"},{"line_number":8149,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._prepare_pci_devices_for_use\u0027)"},{"line_number":8150,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.LibvirtDriver._create_domain_and_network\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_c11b27c9","line":8147,"in_reply_to":"fa32b979_cc612caa","updated":"2015-06-23 10:34:25.000000000","message":"Will do when i update this patch again. thanks","commit_id":"d00cac57c42598952e2dc720cf970f0c8f473bd4"}],"nova/wsgi.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"cbac3de7a6dad88bd304b59d59ad0e0d850961fc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class Server(service.ServiceBase):"},{"line_number":91,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    default_pool_size \u003d CONF.wsgi_default_pool_size"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_feabbad4","line":90,"updated":"2015-06-20 13:21:16.000000000","message":"Server should not be inherited from service.ServiceBase. Launcher interacts with Server via nova.service.WSGIService class(which is inherited from service.ServiceBase).","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"d7ebd004429dbf65f71d0b140e1b1ec9f4f9c21b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class Server(service.ServiceBase):"},{"line_number":91,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    default_pool_size \u003d CONF.wsgi_default_pool_size"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_dd1fc759","line":90,"in_reply_to":"fa32b979_feabbad4","updated":"2015-06-22 10:10:26.000000000","message":"There was test or ci job failure and hence i added this.","commit_id":"2269fd4b0a5f4f71233eb223e75013a8b1a40f29"}],"requirements.txt":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"bc77ba112f19bd1d54be9f5ec7afeff435ea2c0a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"oslo.rootwrap\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":44,"context_line":"oslo.messaging\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":45,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":46,"context_line":"oslo.service\u003e\u003d0.1.0"},{"line_number":47,"context_line":"rfc3986\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":48,"context_line":"oslo.middleware!\u003d2.0.0,\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":49,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1"}],"source_content_type":"text/plain","patch_set":21,"id":"ba3cc151_cda4ae4c","line":46,"updated":"2015-07-08 06:45:34.000000000","message":"I don\u0027t know, should we keep \"Apache-2.0\" comment?","commit_id":"3ea601ea6d86c31a28e4d794400ce2b90e52e2c3"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"c556b2ee7a1f9643a0d93c716e20bae11d186044","unresolved":false,"context_lines":[{"line_number":43,"context_line":"oslo.rootwrap\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":44,"context_line":"oslo.messaging\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":45,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":46,"context_line":"oslo.service\u003e\u003d0.1.0"},{"line_number":47,"context_line":"rfc3986\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":48,"context_line":"oslo.middleware!\u003d2.0.0,\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":49,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1"}],"source_content_type":"text/plain","patch_set":21,"id":"ba3cc151_18adc79a","line":46,"in_reply_to":"ba3cc151_cbe4963d","updated":"2015-07-08 21:19:34.000000000","message":"Oh, thank you for help. Because I could not understand why does it fail...","commit_id":"3ea601ea6d86c31a28e4d794400ce2b90e52e2c3"},{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"5861a30d735217a93ce2c85949ec286665117fdd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"oslo.rootwrap\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":44,"context_line":"oslo.messaging\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":45,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":46,"context_line":"oslo.service\u003e\u003d0.1.0"},{"line_number":47,"context_line":"rfc3986\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":48,"context_line":"oslo.middleware!\u003d2.0.0,\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":49,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1"}],"source_content_type":"text/plain","patch_set":21,"id":"ba3cc151_cbe4963d","line":46,"in_reply_to":"ba3cc151_cda4ae4c","updated":"2015-07-08 07:16:38.000000000","message":"Yep. According to the last response of jenkins you have to add this comment :)","commit_id":"3ea601ea6d86c31a28e4d794400ce2b90e52e2c3"}]}