)]}'
{"nova/compute/api.py":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"78b9b7350fa3bc528f000dd3244ad6f28b8e34f6","unresolved":false,"context_lines":[{"line_number":672,"context_line":"            if image_id and image_size \u003e root_gb * (1024 ** 3):"},{"line_number":673,"context_line":"                raise exception.FlavorDiskTooSmall()"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"            if int(image.get(\u0027min_disk\u0027) or 0) \u003e root_gb:"},{"line_number":676,"context_line":"                    raise exception.FlavorDiskTooSmall()"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def _get_image_defined_bdms(self, base_options, instance_type, image_meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_850b997c","line":675,"updated":"2015-06-18 09:06:58.000000000","message":"is this check needed in case when image_id is None?","commit_id":"667b81f768b8a5eaeef3cb9144c55594bed586ec"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"2ee8a39116f52d27b59eb3d0a13f3cd9a1ccc9d8","unresolved":false,"context_lines":[{"line_number":672,"context_line":"            if image_id and image_size \u003e root_gb * (1024 ** 3):"},{"line_number":673,"context_line":"                raise exception.FlavorDiskTooSmall()"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"            if int(image.get(\u0027min_disk\u0027) or 0) \u003e root_gb:"},{"line_number":676,"context_line":"                    raise exception.FlavorDiskTooSmall()"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def _get_image_defined_bdms(self, base_options, instance_type, image_meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_e34cb69f","line":675,"in_reply_to":"fa32b979_850b997c","updated":"2015-06-18 23:24:33.000000000","message":"No I think this check still stands. If image_id is None (and hence is a volume) the min_disk attribute should still be taken into account. I don\u0027t think a volume has a min_disk attribute but if it did I think it would want to be taken into account.","commit_id":"667b81f768b8a5eaeef3cb9144c55594bed586ec"}]}