)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6461107413f2ce6e989f5a8e2ed1da258f3a2529","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hard stop server support in rest api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova only support to stop a server gracefully in"},{"line_number":10,"context_line":"rest api, this patch adds hard stop server support."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifbaff7cbe383feb8403c14269392bfce823f35d2"},{"line_number":13,"context_line":"Closes-Bug: #1465956"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_142fc188","line":10,"updated":"2015-06-18 07:57:16.000000000","message":"Please add APIImpact flag into commit message https://wiki.openstack.org/wiki/API_Working_Group#Deliverables","commit_id":"5b5c980908156694d747cbee1a31095c637f59ef"}],"nova/api/openstack/compute/contrib/server_start_stop.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6461107413f2ce6e989f5a8e2ed1da258f3a2529","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _stop_server(self, req, id, body):"},{"line_number":62,"context_line":"        \"\"\"Stop an instance.\"\"\""},{"line_number":63,"context_line":"        if \u0027os-stop\u0027 in body and \u0027type\u0027 in body[\u0027os-stop\u0027]:"},{"line_number":64,"context_line":"            valid_stop_types \u003d [\u0027HARD\u0027, \u0027SOFT\u0027]"},{"line_number":65,"context_line":"            stop_type \u003d body[\u0027os-stop\u0027][\u0027type\u0027].upper()"},{"line_number":66,"context_line":"            if not valid_stop_types.count(stop_type):"},{"line_number":67,"context_line":"                msg \u003d _(\"Argument \u0027type\u0027 for stop is not HARD or SOFT\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_94d3d1d4","line":64,"updated":"2015-06-18 07:57:16.000000000","message":"Could we use validation over schema there?","commit_id":"5b5c980908156694d747cbee1a31095c637f59ef"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6461107413f2ce6e989f5a8e2ed1da258f3a2529","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                msg \u003d _(\"Argument \u0027type\u0027 for stop is not HARD or SOFT\")"},{"line_number":68,"context_line":"                LOG.error(msg)"},{"line_number":69,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            msg \u003d _(\"Missing argument \u0027type\u0027 for stop\")"},{"line_number":72,"context_line":"            LOG.error(msg)"},{"line_number":73,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f4b81d2c","line":70,"updated":"2015-06-18 07:57:16.000000000","message":"I don\u0027t think this param should be required, maybe if nothing is provided in request we should use some default value for that. As previous version of API use clean_shutdown as True by default  you could implement same logic in your patch","commit_id":"5b5c980908156694d747cbee1a31095c637f59ef"}]}