)]}'
{"nova/api/openstack/compute/contrib/services.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"4697a9a82f46831a22a6397e1f2445be46f15b6c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            host \u003d body[\u0027para\u0027][\u0027host\u0027]"},{"line_number":113,"context_line":"            service \u003d body[\u0027para\u0027][\u0027service\u0027]"},{"line_number":114,"context_line":"        except (TypeError, KeyError):"},{"line_number":115,"context_line":"            raise webob.exc.HTTPUnprocessableEntity()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FrpY%3D","line":114,"updated":"2013-01-09 18:40:54.000000000","message":"thinking in merge this when v3 api open, I have to ask: why did you added this \u0027para\u0027? sorry, but what \u0027para\u0027 means in this context?  why not update or service instead of \u0027para\u0027","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3d53a91cf1ca47b5e7c66f67d0063c839bcbf245","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        try:"},{"line_number":112,"context_line":"            host \u003d body[\u0027para\u0027][\u0027host\u0027]"},{"line_number":113,"context_line":"            service \u003d body[\u0027para\u0027][\u0027service\u0027]"},{"line_number":114,"context_line":"        except (TypeError, KeyError):"},{"line_number":115,"context_line":"            raise webob.exc.HTTPUnprocessableEntity()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fq6o%3D","line":114,"in_reply_to":"AAAAM3%2F%2FrpY%3D","updated":"2013-01-10 02:31:23.000000000","message":"when I add xml api request sample to this, I find it must need a root element in nova/tests/integrated/api_samples/os-services/service-enable-put-req.xml.tpl, so I add the \u0027para\u0027, it means parameter. \u0027service\u0027 or \u0027update\u0027 maybe make more sense.Thinking in merge this when v3 api open? So when can I update this patch? Now or after V3 Open?","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"}],"nova/tests/integrated/test_api_samples.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d14e362412b1b11a8f468e682ce2b85320040018","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"                       \u0027updated_at\u0027: datetime(2012, 9, 18, 8, 3, 38),"},{"line_number":1885,"context_line":"                       \u0027created_at\u0027: datetime(2012, 9, 18, 2, 46, 28)},"},{"line_number":1886,"context_line":"                      ]"},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"        def fake_servcie_get_all(context):"},{"line_number":1889,"context_line":"            return fake_services_list"},{"line_number":1890,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fr9I%3D","line":1887,"updated":"2013-01-09 16:42:42.000000000","message":"I would import the service list from the fake instead of duplicate it here","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"c810eee875553dcaf2c395aeaa1b07892368658d","unresolved":false,"context_lines":[{"line_number":1885,"context_line":"                       \u0027created_at\u0027: datetime(2012, 9, 18, 2, 46, 28)},"},{"line_number":1886,"context_line":"                      ]"},{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"        def fake_servcie_get_all(context):"},{"line_number":1889,"context_line":"            return fake_services_list"},{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"        def fake_service_get_by_host_binary(context, host, binary):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FsBA%3D","line":1888,"updated":"2013-01-09 16:00:30.000000000","message":"Silly stuff...(spelling errors) Please replace all entries of servcie to service","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d14e362412b1b11a8f468e682ce2b85320040018","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"    def tearDown(self):"},{"line_number":1921,"context_line":"        super(ServicesJsontest, self).tearDown()"},{"line_number":1922,"context_line":""},{"line_number":1923,"context_line":"    def test_services_list_with_host_service(self):"},{"line_number":1924,"context_line":"        \"\"\"Return a list of all agent builds.\"\"\""},{"line_number":1925,"context_line":"        response \u003d self._do_get(\u0027os-services?host\u003dhost1\u0026service\u003dnova-compute\u0027)"},{"line_number":1926,"context_line":"        self.assertEqual(response.status, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fr8U%3D","line":1923,"updated":"2013-01-09 16:42:42.000000000","message":"Usually we do general tests not specific ones, I mean, a test_services_list makes more sense here, so we can get a list with those services and not only one element","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3d53a91cf1ca47b5e7c66f67d0063c839bcbf245","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"    def tearDown(self):"},{"line_number":1921,"context_line":"        super(ServicesJsontest, self).tearDown()"},{"line_number":1922,"context_line":""},{"line_number":1923,"context_line":"    def test_services_list_with_host_service(self):"},{"line_number":1924,"context_line":"        \"\"\"Return a list of all agent builds.\"\"\""},{"line_number":1925,"context_line":"        response \u003d self._do_get(\u0027os-services?host\u003dhost1\u0026service\u003dnova-compute\u0027)"},{"line_number":1926,"context_line":"        self.assertEqual(response.status, 200)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fq6Y%3D","line":1923,"in_reply_to":"AAAAM3%2F%2Fr8U%3D","updated":"2013-01-10 02:31:23.000000000","message":"OK, I will change it. But it\u0027s just an API sample. So I\u0027m not sure whether we need add a sample for every parameter of an api interface like unit test or we can add just one most representative sample for an api.","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d14e362412b1b11a8f468e682ce2b85320040018","unresolved":false,"context_lines":[{"line_number":1924,"context_line":"        \"\"\"Return a list of all agent builds.\"\"\""},{"line_number":1925,"context_line":"        response \u003d self._do_get(\u0027os-services?host\u003dhost1\u0026service\u003dnova-compute\u0027)"},{"line_number":1926,"context_line":"        self.assertEqual(response.status, 200)"},{"line_number":1927,"context_line":"        project \u003d {\u0027binary\u0027: \u0027nova-compute\u0027, \u0027host\u0027: \u0027host1\u0027,"},{"line_number":1928,"context_line":"                   \u0027zone\u0027: \u0027nova\u0027,"},{"line_number":1929,"context_line":"                   \u0027status\u0027: \u0027disabled\u0027, \u0027state\u0027: \u0027up\u0027,"},{"line_number":1930,"context_line":"                   \u0027updated_at\u0027: \u00272012-10-29T13:42:05.000000\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fr8M%3D","line":1927,"updated":"2013-01-09 16:42:42.000000000","message":"suggestion: one element in each line, just be a little more readable and I would use subs instead of project just to make it as all the other tests in this file","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"d14e362412b1b11a8f468e682ce2b85320040018","unresolved":false,"context_lines":[{"line_number":1937,"context_line":"        response \u003d self._do_put(\u0027/os-services/enable\u0027,"},{"line_number":1938,"context_line":"                                \u0027service-enable-put-req\u0027, subs)"},{"line_number":1939,"context_line":"        self.assertEqual(response.status, 200)"},{"line_number":1940,"context_line":"        expected \u003d {\"disabled\": False,"},{"line_number":1941,"context_line":"                    \"host\": \"host1\","},{"line_number":1942,"context_line":"                    \"service\": \"nova-compute\"}"},{"line_number":1943,"context_line":"        return self._verify_response(\u0027service-enable-put-resp\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fr8A%3D","line":1940,"updated":"2013-01-09 16:42:42.000000000","message":"suggestion: I would subs instead of expected just to keep the same pattern from the other tests","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3d53a91cf1ca47b5e7c66f67d0063c839bcbf245","unresolved":false,"context_lines":[{"line_number":1937,"context_line":"        response \u003d self._do_put(\u0027/os-services/enable\u0027,"},{"line_number":1938,"context_line":"                                \u0027service-enable-put-req\u0027, subs)"},{"line_number":1939,"context_line":"        self.assertEqual(response.status, 200)"},{"line_number":1940,"context_line":"        expected \u003d {\"disabled\": False,"},{"line_number":1941,"context_line":"                    \"host\": \"host1\","},{"line_number":1942,"context_line":"                    \"service\": \"nova-compute\"}"},{"line_number":1943,"context_line":"        return self._verify_response(\u0027service-enable-put-resp\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fq54%3D","line":1940,"in_reply_to":"AAAAM3%2F%2Fr8A%3D","updated":"2013-01-10 02:31:23.000000000","message":"OK, I wrote it without comprehensive consideration.","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"c810eee875553dcaf2c395aeaa1b07892368658d","unresolved":false,"context_lines":[{"line_number":1942,"context_line":"                    \"service\": \"nova-compute\"}"},{"line_number":1943,"context_line":"        return self._verify_response(\u0027service-enable-put-resp\u0027,"},{"line_number":1944,"context_line":"                                      expected, response)"},{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"class ServicesXmltest(ServicesJsontest):"},{"line_number":1948,"context_line":"    ctype \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FsBU%3D","line":1945,"updated":"2013-01-09 16:00:30.000000000","message":"I would add a test_service_disable here as I think we should test both update scenarios.","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"3d53a91cf1ca47b5e7c66f67d0063c839bcbf245","unresolved":false,"context_lines":[{"line_number":1942,"context_line":"                    \"service\": \"nova-compute\"}"},{"line_number":1943,"context_line":"        return self._verify_response(\u0027service-enable-put-resp\u0027,"},{"line_number":1944,"context_line":"                                      expected, response)"},{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"class ServicesXmltest(ServicesJsontest):"},{"line_number":1948,"context_line":"    ctype \u003d \u0027xml\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fq6U%3D","line":1945,"in_reply_to":"AAAAM3%2F%2FsBU%3D","updated":"2013-01-10 02:31:23.000000000","message":"OK, if I can update this patch, I will add this.","commit_id":"52869dd3d2f0200ea5c4fd1be00e29425078833a"}]}