)]}'
{"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"bec72bf3593a31a45699c04d655475100bfb0ca7","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            raise exception.StorageError(reason\u003d_(\"Unable to find volume\"))"},{"line_number":514,"context_line":"        return device"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    def _get_dc_ref(self, ds_ref):"},{"line_number":517,"context_line":"        dcs \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":518,"context_line":"                \"Datacenter\", [\"name\", \"datastore\"])"},{"line_number":519,"context_line":"        while dcs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_be5ccc7d","line":516,"updated":"2015-07-15 08:28:22.000000000","message":"this is duplicate code with vmops.py, we should factor out the code for getting datastore\u0027s datacenter and reuse it","commit_id":"d12aecde92a7a7f57f84a007e8c46f1d0a0a5bd6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b5d3c5d17e3a681a8e867faba4293b3844a3a3b4","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            raise exception.StorageError(reason\u003d_(\"Unable to find volume\"))"},{"line_number":514,"context_line":"        return device"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    def _get_dc_ref(self, ds_ref):"},{"line_number":517,"context_line":"        dcs \u003d self._session._call_method(vim_util, \"get_objects\","},{"line_number":518,"context_line":"                \"Datacenter\", [\"name\", \"datastore\"])"},{"line_number":519,"context_line":"        while dcs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_e0abef1c","line":516,"in_reply_to":"9a41bdd9_be5ccc7d","updated":"2015-07-26 13:26:05.000000000","message":"Done","commit_id":"d12aecde92a7a7f57f84a007e8c46f1d0a0a5bd6"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"23dcc5d7fecadb4add02783185a83267e5f19627","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_vmware import exceptions as vexc"},{"line_number":25,"context_line":"from oslo_vmware.objects import datastore as ds_obj"},{"line_number":26,"context_line":"from oslo_vmware import vim_util as vutil"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_009f3104","line":24,"updated":"2015-09-14 12:13:59.000000000","message":"Nit: exc sounds like execute somehow","commit_id":"a72a871c1be49e165c79888563a0b7d3fbf352b3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"49b7c257b6a27f0b0d6d255a87d7f07d5df0e98f","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                              ci.original)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            # Attach the current volume to the volume_ref"},{"line_number":564,"context_line":"            self.attach_disk_to_vm(volume_ref, instance,"},{"line_number":565,"context_line":"                                   vmdk.adapter_type, vmdk.disk_type,"},{"line_number":566,"context_line":"                                   vmdk_path\u003dci.original)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_1b0ec234","line":564,"updated":"2015-09-14 12:16:02.000000000","message":"Nit: maybe we should rename this function, it reads like detach is now re-attaching the VM to the server?","commit_id":"a72a871c1be49e165c79888563a0b7d3fbf352b3"}]}