)]}'
{"nova/tests/unit/virt/libvirt/volume/test_volume.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f5ead01b2a26184d9fa80f97abcfbc49a764bc35","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class LibvirtVolumeTestCase(test.NoDBTestCase):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def setUp(self):"},{"line_number":70,"context_line":"        super(LibvirtVolumeTestCase, self).setUp()"},{"line_number":71,"context_line":"        self.executes \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_22c3318c","line":68,"updated":"2015-06-26 22:11:20.000000000","message":"Hmm, we should pull the common setup out into it\u0027s own mixin class otherwise when we extend this class, the subclass ends up running all of the tests in it\u0027s own class as duplicates.","commit_id":"a338617bb2462f85664467f50608176184bcb101"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"07f2e037e038a16c9a563bb1b3f24db96d93f118","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        \u0027nova.virt.libvirt.volume.volume.LibvirtFibreChannelVolumeDriver\u0027,"},{"line_number":284,"context_line":"    \u0027scality\u003dnova.virt.libvirt.volume.volume.LibvirtScalityVolumeDriver\u0027,"},{"line_number":285,"context_line":"    \u0027gpfs\u003dnova.virt.libvirt.volume.volume.LibvirtGPFSVolumeDriver\u0027,"},{"line_number":286,"context_line":"    \u0027quobyte\u003dnova.virt.libvirt.volume.quobyte.LibvirtQuobyteVolumeDriver\u0027,"},{"line_number":287,"context_line":"]"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a50d1a3_3bb233e6","line":286,"updated":"2015-07-27 20:38:39.000000000","message":"I presume this is the only place where we load the driver by class name and thus this is safe for us to move without affecting config or anything else.","commit_id":"311042df78fbfeac541817e2a9bb4852f0bc58ff"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ae8e988886c8ff305e80a115189f61bd24b4a551","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        \u0027nova.virt.libvirt.volume.volume.LibvirtFibreChannelVolumeDriver\u0027,"},{"line_number":284,"context_line":"    \u0027scality\u003dnova.virt.libvirt.volume.volume.LibvirtScalityVolumeDriver\u0027,"},{"line_number":285,"context_line":"    \u0027gpfs\u003dnova.virt.libvirt.volume.volume.LibvirtGPFSVolumeDriver\u0027,"},{"line_number":286,"context_line":"    \u0027quobyte\u003dnova.virt.libvirt.volume.quobyte.LibvirtQuobyteVolumeDriver\u0027,"},{"line_number":287,"context_line":"]"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a50d1a3_1f7aa388","line":286,"in_reply_to":"3a50d1a3_3bb233e6","updated":"2015-07-28 12:33:56.000000000","message":"Correct. This mapping used to be in nova.conf but we deprecated that in Kilo and removed it in Liberty, so the class names aren\u0027t exposed anywhere public anymore.","commit_id":"311042df78fbfeac541817e2a9bb4852f0bc58ff"}],"nova/virt/libvirt/volume/quobyte.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3b0a8b275cca04a8ea7d27956929733d2047d7ac","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        raise nova_exception.NovaException(msg)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class LibvirtQuobyteVolumeDriver(libvirt_volume.LibvirtBaseVolumeDriver):"},{"line_number":100,"context_line":"    \"\"\"Class implements libvirt part of volume driver for Quobyte.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __init__(self, connection):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_01c01e29","line":99,"updated":"2015-07-22 07:03:30.000000000","message":"What about to use your all moving to remove the redundant prefix used.\n\ns/LibvirtQuobyteVolumeDriver/QuobyteVolumeDriver, well actually QuobyteDriver should be enough I guess.","commit_id":"459765890526ed78bb3baadb1a8d5b06a430a879"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"10ace326e986d6bf1693c235e9ff2eb0e08c83e7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        raise nova_exception.NovaException(msg)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class LibvirtQuobyteVolumeDriver(libvirt_volume.LibvirtBaseVolumeDriver):"},{"line_number":100,"context_line":"    \"\"\"Class implements libvirt part of volume driver for Quobyte.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __init__(self, connection):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_a5ecb6f3","line":99,"in_reply_to":"3a50d1a3_01c01e29","updated":"2015-07-22 16:00:25.000000000","message":"Same comment as in the GPFS change, I don\u0027t want to rename these in this series, this is what they were already called, I\u0027m just moving things around so it\u0027s not a huge hot mess in a single module.","commit_id":"459765890526ed78bb3baadb1a8d5b06a430a879"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f838b7319f175ff144625cdb0a801e07c3f7f9b7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        raise nova_exception.NovaException(msg)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class LibvirtQuobyteVolumeDriver(libvirt_volume.LibvirtBaseVolumeDriver):"},{"line_number":100,"context_line":"    \"\"\"Class implements libvirt part of volume driver for Quobyte.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def __init__(self, connection):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_eb1fef05","line":99,"in_reply_to":"3a50d1a3_a5ecb6f3","updated":"2015-07-22 16:41:40.000000000","message":"Hum the point of the blueprint is to consolidate this area I do not think that only means moving things. But yes it could be better to do that incrementally.","commit_id":"459765890526ed78bb3baadb1a8d5b06a430a879"}],"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9671665a4fa2ee027de3894464c1548e25142937","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    cfg.ListOpt(\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":95,"context_line":"                default\u003d[],"},{"line_number":96,"context_line":"                help\u003d\u0027Protocols listed here will be accessed directly \u0027"},{"line_number":97,"context_line":"                     \u0027from QEMU. Currently supported protocols: [gluster]\u0027),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027quobyte_mount_point_base\u0027,"},{"line_number":99,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":100,"context_line":"               help\u003d\u0027Directory where the Quobyte volume is mounted on the \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_5392324d","line":97,"updated":"2015-07-15 20:38:06.000000000","message":"This should be moved.","commit_id":"ede0b8c9d40c7e5b278f02befa84cf102d39590d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9671665a4fa2ee027de3894464c1548e25142937","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    cfg.StrOpt(\u0027quobyte_mount_point_base\u0027,"},{"line_number":99,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":100,"context_line":"               help\u003d\u0027Directory where the Quobyte volume is mounted on the \u0027"},{"line_number":101,"context_line":"                    \u0027compute node\u0027),"},{"line_number":102,"context_line":"    cfg.StrOpt(\u0027quobyte_client_cfg\u0027,"},{"line_number":103,"context_line":"               help\u003d\u0027Path to a Quobyte Client configuration file.\u0027),"},{"line_number":104,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_13982a69","line":101,"updated":"2015-07-15 20:38:06.000000000","message":"ditto","commit_id":"ede0b8c9d40c7e5b278f02befa84cf102d39590d"}]}