)]}'
{"nova/virt/libvirt/volume.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5a3b58c8f3aea5fd5205398752655f0878e13cb2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"},{"line_number":110,"context_line":"                    \u0027case offload support is desired. Supported transports \u0027"},{"line_number":111,"context_line":"                    \u0027are be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx and ocs. \u0027"},{"line_number":112,"context_line":"                    \u0027Default format is transport_name.hwaddress and can be \u0027"},{"line_number":113,"context_line":"                    \u0027generated manually or via iscsiadm -m iface\u0027),"},{"line_number":114,"context_line":"                    # iser is also supported, but use LibvirtISERVolumeDriver"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_5f50f90a","line":111,"updated":"2015-07-15 18:52:27.000000000","message":"I\u0027m totally confused because this says there is a list of supported transports, so what else would someone set iscsi_iface to if not in this list?","commit_id":"3a0f99418fd2ec72fdb7292c0c2341512f879e64"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"932614e8837179adcebef1e8b1bf1c3b04bc4c34","unresolved":false,"context_lines":[{"line_number":108,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"},{"line_number":110,"context_line":"                    \u0027case offload support is desired. Supported transports \u0027"},{"line_number":111,"context_line":"                    \u0027are be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx and ocs. \u0027"},{"line_number":112,"context_line":"                    \u0027Default format is transport_name.hwaddress and can be \u0027"},{"line_number":113,"context_line":"                    \u0027generated manually or via iscsiadm -m iface\u0027),"},{"line_number":114,"context_line":"                    # iser is also supported, but use LibvirtISERVolumeDriver"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_7f329da8","line":111,"in_reply_to":"9a41bdd9_5f50f90a","updated":"2015-07-15 19:00:10.000000000","message":"After talking with anish in IRC I think I understand this better.  The docs here sort of make it more clear:\n\nhttp://docs.openstack.org/kilo/config-reference/content/iscsi-iface-config.html\n\nThe point is, iscsi_iface is a value in the form of \u003ctransport_name\u003e.\u003chwaddress\u003e where trasnport_name is one of (be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx, ocs), so you could have something like:\n\niscsi_iface\u003dbnx2i.00:05:b5:d2:a0:c2\n\nSo bnx2i is the transport_name and 00:05:b5:d2:a0:c2 is the hwaddress.\n\nI think this config option help could definitely use some more clarity here in the form of the option value \u003ctransport_name\u003e.\u003chwaddress\u003e and say that \u003ctransport_name\u003e is the list of options above, and hwaddress is the iface MAC you\u0027re talking to, with an example like I give above, \"bnx2i.00:05:b5:d2:a0:c2\".","commit_id":"3a0f99418fd2ec72fdb7292c0c2341512f879e64"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"9be5ee2d77dda1f0df50532132917bab3bbf77d8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"},{"line_number":110,"context_line":"                    \u0027case offload support is desired. Supported transports \u0027"},{"line_number":111,"context_line":"                    \u0027are be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx and ocs. \u0027"},{"line_number":112,"context_line":"                    \u0027Default format is transport_name.hwaddress and can be \u0027"},{"line_number":113,"context_line":"                    \u0027generated manually or via iscsiadm -m iface\u0027),"},{"line_number":114,"context_line":"                    # iser is also supported, but use LibvirtISERVolumeDriver"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_1f8111fb","line":111,"in_reply_to":"9a41bdd9_7f329da8","updated":"2015-07-15 19:04:17.000000000","message":"Saved me some exlpaining :) I\u0027ll update the help text here, the actual code path and documentation already mention this. \n\nWhile the choices option is being removed, there is a internal check in volume.py that makes sure that the transport provided inside the iface does indeed match one of the values from \u0027be2iscsi\u0027, \u0027bnx2i\u0027, \u0027cxgb3i\u0027, \u0027cxgb4i\u0027, \u0027qla4xxx\u0027 and \u0027ocs\u0027 so this is already covered. open-iscsi by itself does not care what you name the iface, as long as the transport chosen inside the iface file is correct. (Think of each iface file as an individual config file)","commit_id":"3a0f99418fd2ec72fdb7292c0c2341512f879e64"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"34bfa01c113e026a74bd39df6a5b6d3ed9b3c3c8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    \u0027generated manually or via iscsiadm -m iface command. \u0027"},{"line_number":114,"context_line":"                    \u0027Do not confuse the iscsi_iface paramter to be provided \u0027"},{"line_number":115,"context_line":"                    \u0027here with the transport name. iscsi_iface should match \u0027"},{"line_number":116,"context_line":"                    \u0027the iface.iscsi_ifacename parameter insice the iscsi \u0027"},{"line_number":117,"context_line":"                    \u0027file. The transport name is provided by the \u0027"},{"line_number":118,"context_line":"                    \u0027iface.transport_name parameter inside the iface file \u0027"},{"line_number":119,"context_line":"                    \u0027and must be one of the supported transports but there \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_42590234","line":116,"updated":"2015-07-15 19:22:51.000000000","message":"s/insice/inside/?","commit_id":"49bff3f85a07a19924a6d804fb5c6d279fcde78e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"34bfa01c113e026a74bd39df6a5b6d3ed9b3c3c8","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027file. The transport name is provided by the \u0027"},{"line_number":118,"context_line":"                    \u0027iface.transport_name parameter inside the iface file \u0027"},{"line_number":119,"context_line":"                    \u0027and must be one of the supported transports but there \u0027"},{"line_number":120,"context_line":"                    \u0027are no naming restrictions on the actual iface file\u0027),"},{"line_number":121,"context_line":"                    # iser is also supported, but use LibvirtISERVolumeDriver"},{"line_number":122,"context_line":"                    # instead"},{"line_number":123,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_227b9e7c","line":120,"updated":"2015-07-15 19:22:51.000000000","message":"I\u0027m still sort of confused by this text, but it\u0027s better.\n\nI was really looking for something simple, basically:\n\n\"iscsi_iface is of the form \u003ctransport_name\u003e.\u003chwaddress\u003e where \u003ctransport_name\u003e is one of (be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx, ocs) and hwaddress is the MAC of the interface.\"\n\nThen go into details about exceptions etc etc.","commit_id":"49bff3f85a07a19924a6d804fb5c6d279fcde78e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"897da312dcd6ab7f3ea0e61ece7547b699d9b3c9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    \u0027cxgb4i, qla4xxx, ocs) and \u003chwadress\u003e is the MAC address \u0027"},{"line_number":114,"context_line":"                    \u0027of the interface and can be generated via the \u0027"},{"line_number":115,"context_line":"                    \u0027iscsiadm -m iface command. Do not confuse the \u0027"},{"line_number":116,"context_line":"                    \u0027iscsi_iface paramter to be provided here with the actual \u0027"},{"line_number":117,"context_line":"                    \u0027transport name.\u0027),"},{"line_number":118,"context_line":"                    # iser is also supported, but use LibvirtISERVolumeDriver"},{"line_number":119,"context_line":"                    # instead"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_2d286f32","line":116,"updated":"2015-07-15 19:49:50.000000000","message":"s/paramter/parameter/","commit_id":"65113e1824f0b2cb111b105bc541eb1e973e4ce3"}]}