)]}'
{"nova/exception.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"397d71c5c488e1d32bc05830817142c9f06c07fb","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"class VolumeEncryptionNotSupported(Invalid):"},{"line_number":284,"context_line":"    msg_fmt \u003d _(\"Volume encryption is not supported for volume %(volume_id)s \""},{"line_number":285,"context_line":"                \"with type %(volume_type)s.\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"class InvalidKeypair(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_78497a30","line":285,"updated":"2015-07-08 18:13:43.000000000","message":"Volume type may be confusing in this context because it refers to the \u0027driver_volume_type\u0027 (e.g., iSCSI or RBD) instead of Cinder\u0027s notion of a volume type. Perhaps \u0027driver\u0027 would be a better moniker than \u0027type\u0027 to avoid any confusion.","commit_id":"beb63aef2ec2e3b2158c7af2ed1645b101c00a1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ba041b4b3072d25e0326bb9ee2def86f39947d97","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"class VolumeEncryptionNotSupported(Invalid):"},{"line_number":284,"context_line":"    msg_fmt \u003d _(\"Volume encryption is not supported for volume %(volume_id)s \""},{"line_number":285,"context_line":"                \"with type %(volume_type)s.\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"class InvalidKeypair(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f6ba2fbf","line":285,"in_reply_to":"ba3cc151_76c62a9b","updated":"2015-07-09 21:18:35.000000000","message":"I\u0027m going to reword this as:\n\n\"Volume encryption is not support for (type) volume (id).\"\n\nSo it\u0027d be like:\n\n\"Volume encryption is not support for rbd volume 1234\"","commit_id":"beb63aef2ec2e3b2158c7af2ed1645b101c00a1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a14a54758706ae2b2e92c69277f94e96d0b4a91","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"class VolumeEncryptionNotSupported(Invalid):"},{"line_number":284,"context_line":"    msg_fmt \u003d _(\"Volume encryption is not supported for volume %(volume_id)s \""},{"line_number":285,"context_line":"                \"with type %(volume_type)s.\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"class InvalidKeypair(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_76c62a9b","line":285,"in_reply_to":"ba3cc151_78497a30","updated":"2015-07-09 17:14:04.000000000","message":"Yeah, not sure.  Volume driver for iscsi is pretty straight-forward, but RBD is handled in the LibvirtNetVolumeDriver, which isn\u0027t as clear.  Maybe \u0027driver\u0027 is just what sticks with me as not exactly right, I\u0027m open to other suggestions though.  I wasn\u0027t sure exactly the best way to word this for clarity.","commit_id":"beb63aef2ec2e3b2158c7af2ed1645b101c00a1b"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"7b75c9008e95703d5ca5e8984fec0953936ccdcc","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"class VolumeEncryptionNotSupported(Invalid):"},{"line_number":284,"context_line":"    msg_fmt \u003d _(\"Volume encryption is not supported for volume %(volume_id)s \""},{"line_number":285,"context_line":"                \"with type %(volume_type)s.\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"class InvalidKeypair(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_56567b5c","line":285,"in_reply_to":"ba3cc151_f6ba2fbf","updated":"2015-07-09 21:22:59.000000000","message":"That sounds good to me.","commit_id":"beb63aef2ec2e3b2158c7af2ed1645b101c00a1b"}],"nova/volume/encryptors/cryptsetup.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d07740fe3cd6eb95272c64d646083f2585305533","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        # the case of libvirt network volume drivers."},{"line_number":40,"context_line":"        data \u003d connection_info[\u0027data\u0027]"},{"line_number":41,"context_line":"        if not data.get(\u0027device_path\u0027):"},{"line_number":42,"context_line":"            volume_id \u003d connection_info.get(\u0027serial\u0027) or data.get(\u0027volume_id\u0027)"},{"line_number":43,"context_line":"            raise exception.VolumeEncryptionNotSupported("},{"line_number":44,"context_line":"                                volume_id\u003dvolume_id,"},{"line_number":45,"context_line":"                                volume_type\u003d\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0fd8a6ee","line":42,"updated":"2015-06-20 22:13:49.000000000","message":"Probably makes more sense to check for volume_id in data first since nova is the one setting serial in connection_info (in the compute manager or block_device module).","commit_id":"6b7f7c6c2268f5535be2f7c471de0990e7dbdda1"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"397d71c5c488e1d32bc05830817142c9f06c07fb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            volume_id \u003d data.get(\u0027volume_id\u0027) or connection_info.get(\u0027serial\u0027)"},{"line_number":43,"context_line":"            raise exception.VolumeEncryptionNotSupported("},{"line_number":44,"context_line":"                                volume_id\u003dvolume_id,"},{"line_number":45,"context_line":"                                volume_type\u003d\u0027driver_volume_type\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # the device\u0027s path as given to libvirt -- e.g., /dev/disk/by-path/..."},{"line_number":48,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b82142a0","line":45,"updated":"2015-07-08 18:13:43.000000000","message":"Probably don\u0027t intend to always set the volume_type to a fixed string. Perhaps\n\n  connection_info[\u0027driver_volume_type\u0027]\n\nis intended instead?","commit_id":"beb63aef2ec2e3b2158c7af2ed1645b101c00a1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a14a54758706ae2b2e92c69277f94e96d0b4a91","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            volume_id \u003d data.get(\u0027volume_id\u0027) or connection_info.get(\u0027serial\u0027)"},{"line_number":43,"context_line":"            raise exception.VolumeEncryptionNotSupported("},{"line_number":44,"context_line":"                                volume_id\u003dvolume_id,"},{"line_number":45,"context_line":"                                volume_type\u003d\u0027driver_volume_type\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # the device\u0027s path as given to libvirt -- e.g., /dev/disk/by-path/..."},{"line_number":48,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_564e8638","line":45,"in_reply_to":"ba3cc151_b82142a0","updated":"2015-07-09 17:14:04.000000000","message":"Yes, derp - good catch. :)","commit_id":"beb63aef2ec2e3b2158c7af2ed1645b101c00a1b"}]}