)]}'
{"nova/api/openstack/wsgi.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1839658e473fbaab65402fc60a7088089ebcf3b8","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                api_version.DEFAULT_API_VERSION)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def set_legacy_v2(self, is_legacy_v2):"},{"line_number":244,"context_line":"        self.environ[ENV_LEGACY_V2] \u003d is_legacy_v2"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def is_legacy_v2(self):"},{"line_number":247,"context_line":"        return self.environ.get(ENV_LEGACY_V2, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_63717144","line":244,"updated":"2015-07-30 03:21:42.000000000","message":"This method is called from LegacyV2CompatibleWrapper only for setting True.\nSo how about just defining\n\n def set_legacy_v2(self):\n     self.environ[ENV_LEGACY_V2] \u003d True\n\n?","commit_id":"38e6861601e4fbbe63e05bc3582a860b35d6c94d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"58bacff32806fc6f341734968bbb5f1c009f2d29","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                api_version.DEFAULT_API_VERSION)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def set_legacy_v2(self, is_legacy_v2):"},{"line_number":244,"context_line":"        self.environ[ENV_LEGACY_V2] \u003d is_legacy_v2"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def is_legacy_v2(self):"},{"line_number":247,"context_line":"        return self.environ.get(ENV_LEGACY_V2, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_8324bd0e","line":244,"in_reply_to":"3a50d1a3_63717144","updated":"2015-07-30 03:27:39.000000000","message":"thanks, that make sense, as we never set this back to False.","commit_id":"38e6861601e4fbbe63e05bc3582a860b35d6c94d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7685626ab456979cf66e1b1d0a9a29b0d6993a54","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                api_version.DEFAULT_API_VERSION)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def set_legacy_v2(self):"},{"line_number":244,"context_line":"        self.environ[ENV_LEGACY_V2] \u003d True"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def is_legacy_v2(self):"},{"line_number":247,"context_line":"        return self.environ.get(ENV_LEGACY_V2, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_1f3eaada","line":244,"updated":"2015-07-30 13:13:59.000000000","message":"does anyone think this function signature is wired? it called `set_xxx` but without any argument.","commit_id":"13bab86525d4d279cb1896f2ae057a587da62d6b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"9c999827b09a8ca3ba658d5932e7a1a2134c0196","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                api_version.DEFAULT_API_VERSION)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def set_legacy_v2(self):"},{"line_number":244,"context_line":"        self.environ[ENV_LEGACY_V2] \u003d True"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def is_legacy_v2(self):"},{"line_number":247,"context_line":"        return self.environ.get(ENV_LEGACY_V2, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_605aae2c","line":244,"in_reply_to":"3a50d1a3_1f3eaada","updated":"2015-07-30 13:37:16.000000000","message":"Hi, Jeffrey, this come from Ken\u0027ichi\u0027s comment at PS7, I think it reasonable, as we never set this to False.","commit_id":"13bab86525d4d279cb1896f2ae057a587da62d6b"}],"nova/api/validation/validators.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9addfe1667721f31d12080020793d654522afcdb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \u0027maximum\u0027: self._validate_maximum,"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":"        if force_additional_properties:"},{"line_number":100,"context_line":"            validators[\u0027additionalProperties\u0027] \u003d empty_func"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        validator_cls \u003d jsonschema.validators.extend(self.validator_org,"},{"line_number":103,"context_line":"                                                     validators)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_cf55c650","line":100,"updated":"2015-07-21 05:24:28.000000000","message":"Super smart way, I much prefer this implementation :-)\n\n\"empty_func\" seems too generic. So how about renaming the argument of __init__ and noop_func like:\n\n def __init__(self, schema, relax_additional_properties_check\u003dFalse):\n     [..]\n     if relax_additional_properties_check:\n         validators[\u0027additionalProperties\u0027] \u003d noop_func\n\n?","commit_id":"f29687af6d7ec726eae2f7c7fee6b49fc38d91a6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4014e0ca11d49bb572c04212b3653ae0db0e559d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \u0027maximum\u0027: self._validate_maximum,"},{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":"        if force_additional_properties:"},{"line_number":100,"context_line":"            validators[\u0027additionalProperties\u0027] \u003d empty_func"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        validator_cls \u003d jsonschema.validators.extend(self.validator_org,"},{"line_number":103,"context_line":"                                                     validators)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_6599311f","line":100,"in_reply_to":"3a50d1a3_cf55c650","updated":"2015-07-21 06:25:49.000000000","message":"thanks, yea, it should be called as \u0027relax\u0027 not force. Thanks!","commit_id":"f29687af6d7ec726eae2f7c7fee6b49fc38d91a6"}],"nova/tests/functional/test_legacy_v3_compatible_wrapper.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2b28b6389d9780884f5abb2e9832708c6937657a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            headers\u003d{wsgi.API_VERSION_REQUEST_HEADER: \u00272.100\u0027})"},{"line_number":40,"context_line":"        self.assertNotIn(wsgi.API_VERSION_REQUEST_HEADER, response.headers)"},{"line_number":41,"context_line":"        self.assertNotIn(\u0027Vary\u0027, response.headers)"},{"line_number":42,"context_line":"        self.assertNotIn(\u0027type\u0027, response.body[\"keypair\"])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_14047612","line":42,"updated":"2015-07-29 18:45:49.000000000","message":"are we sure this is running on the v21 stack? I was expecting a bit more testing that we have this right under all circumstances than I\u0027m seeing here.","commit_id":"38e6861601e4fbbe63e05bc3582a860b35d6c94d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a4dca2a08051c99a607f31f2dfba5caae6ea60ec","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            headers\u003d{wsgi.API_VERSION_REQUEST_HEADER: \u00272.100\u0027})"},{"line_number":40,"context_line":"        self.assertNotIn(wsgi.API_VERSION_REQUEST_HEADER, response.headers)"},{"line_number":41,"context_line":"        self.assertNotIn(\u0027Vary\u0027, response.headers)"},{"line_number":42,"context_line":"        self.assertNotIn(\u0027type\u0027, response.body[\"keypair\"])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_512afe91","line":42,"in_reply_to":"3a50d1a3_14047612","updated":"2015-07-30 02:50:42.000000000","message":"thanks, this is good point.\n\nFrom the user\u0027s view, there is no different between v2 and v21 compatible stack.\n\nSo I will try to check the wsgi stack is what we expected.","commit_id":"38e6861601e4fbbe63e05bc3582a860b35d6c94d"}]}