)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"159126fb4029ba52008eb51e7ba0d548e8cd3f48","unresolved":false,"context_lines":[{"line_number":18,"context_line":"by its path."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic1b8eaec8d3f5093c6d518a305fd0d40045030c1"},{"line_number":21,"context_line":"Closes-Bug: bug/1467451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_63fcd83e","line":21,"updated":"2015-06-22 11:12:00.000000000","message":"Closes-Bug: #1467451","commit_id":"d7a7fbf239c56f53cfcf7d9823df3b011dbeafd7"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"1dbf9d4cba3f564b4954d5b0871f6961d10fc68b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"by its path."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic1b8eaec8d3f5093c6d518a305fd0d40045030c1"},{"line_number":21,"context_line":"Closes-Bug: bug/1467451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_342cc849","line":21,"in_reply_to":"fa32b979_63fcd83e","updated":"2015-06-22 12:08:19.000000000","message":"Done","commit_id":"d7a7fbf239c56f53cfcf7d9823df3b011dbeafd7"}],"nova/tests/unit/virt/hyperv/test_vmutils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0fb4de4b433c6941e28d1d58d9e2a1f21ea2750e","unresolved":false,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":"            mock_rm_virt_res.assert_called_with(mock_disk, self._FAKE_VM_PATH)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def _test_get_mounted_disk_resource_from_path(self, is_physical):"},{"line_number":561,"context_line":"        mock_disk_1 \u003d mock.MagicMock()"},{"line_number":562,"context_line":"        mock_disk_2 \u003d mock.MagicMock()"},{"line_number":563,"context_line":"        conn_attr \u003d (self._vmutils._PHYS_DISK_CONNECTION_ATTR if is_physical"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_25ad6888","line":560,"updated":"2015-08-10 17:38:16.000000000","message":"Nit: part of me wants this test change in a separate change, but maybe thats a bit too much.","commit_id":"a02deffcfab6cc9a7b0764dd36b8514f6cb1a108"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f8dfb6879d98a0f08c2cd06450351c6042c5fc43","unresolved":false,"context_lines":[{"line_number":560,"context_line":"    def _test_get_mounted_disk_resource_from_path(self, is_physical):"},{"line_number":561,"context_line":"        mock_disk_1 \u003d mock.MagicMock()"},{"line_number":562,"context_line":"        mock_disk_2 \u003d mock.MagicMock()"},{"line_number":563,"context_line":"        conn_attr \u003d (self._vmutils._PHYS_DISK_CONNECTION_ATTR if is_physical"},{"line_number":564,"context_line":"                     else self._vmutils._VIRT_DISK_CONNECTION_ATTR)"},{"line_number":565,"context_line":"        setattr(mock_disk_2, conn_attr, [self._FAKE_MOUNTED_DISK_PATH])"},{"line_number":566,"context_line":"        self._vmutils._conn.query.return_value \u003d [mock_disk_1, mock_disk_2]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_2080c0be","line":563,"updated":"2015-08-11 15:12:37.000000000","message":"Oh, so this is the big I was missing, you reference the vmutils constant, so this effectively tests this.\n\nI am not sure I like it that way, as it hides the difference between v1 and v2, but you are right, it does test it.","commit_id":"a02deffcfab6cc9a7b0764dd36b8514f6cb1a108"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f41220c59a6f25cfd80ea1ecc15a1f437cd366e5","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        self._test_get_mounted_disk_resource_from_path(is_physical\u003dTrue)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def test_get_virtual_mounted_disk_resource_from_path(self):"},{"line_number":577,"context_line":"        self._test_get_mounted_disk_resource_from_path(is_physical\u003dFalse)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    def test_get_controller_volume_paths(self):"},{"line_number":580,"context_line":"        self._prepare_mock_disk()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_7229d036","line":577,"updated":"2015-08-11 10:58:37.000000000","message":"this also tests the change in vmutilsv2, since test_vmutilsv2 extends test_vmutils.\n\nif is_physical\u003d\u003dFalse, the conn_attr is _VIRT_DISK_CONNECTION, which is changed in vmutilsv2.","commit_id":"a02deffcfab6cc9a7b0764dd36b8514f6cb1a108"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5c0b9b4bd887c733f8ceb8a7f6458770b1ae28d5","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        self._test_get_mounted_disk_resource_from_path(is_physical\u003dTrue)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    def test_get_virtual_mounted_disk_resource_from_path(self):"},{"line_number":577,"context_line":"        self._test_get_mounted_disk_resource_from_path(is_physical\u003dFalse)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    def test_get_controller_volume_paths(self):"},{"line_number":580,"context_line":"        self._prepare_mock_disk()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_fe580233","line":577,"in_reply_to":"1a4dcd0f_7229d036","updated":"2015-08-12 13:46:06.000000000","message":"And the vmutilsv2 tests extend the vmutils tests in this module, :\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/virt/hyperv/test_vmutilsv2.py#n38\n\nSo we run the same test through vmutilsv2 and that hits the overridden constant for _VIRT_DISK_CONNECTION.","commit_id":"a02deffcfab6cc9a7b0764dd36b8514f6cb1a108"}],"nova/virt/hyperv/vmutilsv2.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0fb4de4b433c6941e28d1d58d9e2a1f21ea2750e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    _ETHERNET_PORT_ALLOCATION_SETTING_DATA_CLASS \u003d \\"},{"line_number":60,"context_line":"    \u0027Msvm_EthernetPortAllocationSettingData\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    _VIRT_DISK_CONNECTION_ATTR \u003d \"HostResource\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    _AUTOMATIC_STARTUP_ACTION_NONE \u003d 2"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_25c80874","line":62,"updated":"2015-08-10 17:38:16.000000000","message":"I don\u0027t see this being tested, am I missing something?","commit_id":"a02deffcfab6cc9a7b0764dd36b8514f6cb1a108"}]}