)]}'
{"nova/network/api.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"581085bbac381c08c34004ed80c617774395ad69","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                              requested_networks, macs\u003dNone):"},{"line_number":188,"context_line":"        \"\"\"Allocates all network structures for an instance."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        :param macs: None or a set of MAC addresses that the instance"},{"line_number":191,"context_line":"            should use. macs is supplied by the hypervisor driver (contrast"},{"line_number":192,"context_line":"            with requested_networks which is user supplied)."},{"line_number":193,"context_line":"            NB: macs is ignored by nova-network."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FnhA%3D","line":190,"updated":"2013-01-13 00:18:29.000000000","message":"I know its not your fault, but I feel like if you\u0027re going to do this you should fix the other missing params as well.","commit_id":"ad5ebe9edc73b0e99d19a7d8b9322d2513bef94a"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"d2c525104e9e8e9d880e27940371107316afa437","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                              requested_networks, macs\u003dNone):"},{"line_number":188,"context_line":"        \"\"\"Allocates all network structures for an instance."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        :param macs: None or a set of MAC addresses that the instance"},{"line_number":191,"context_line":"            should use. macs is supplied by the hypervisor driver (contrast"},{"line_number":192,"context_line":"            with requested_networks which is user supplied)."},{"line_number":193,"context_line":"            NB: macs is ignored by nova-network."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FlZk%3D","line":190,"in_reply_to":"AAAAM3%2F%2FnhA%3D","updated":"2013-01-15 00:32:38.000000000","message":"I don\u0027t know what the \u0027other missing params are\u0027. In this layer there are no kwargs - its the internal API. I\u0027ve made macs\u003dNone so that hypervisors which call networking code themselves or replace manager or whatever and aren\u0027t updated don\u0027t barf on the patch. We could make it non-optional if you prefer.","commit_id":"ad5ebe9edc73b0e99d19a7d8b9322d2513bef94a"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"4927da3ef033de4e9106232ebecc3221756c6f5b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        :param macs: None or a set of MAC addresses that the instance"},{"line_number":193,"context_line":"            should use. macs is supplied by the hypervisor driver (contrast"},{"line_number":194,"context_line":"            with requested_networks which is user supplied)."},{"line_number":195,"context_line":"            NB: macs is ignored by nova-network."},{"line_number":196,"context_line":"        :returns: network info as from get_instance_nw_info() below"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        args \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FcY8%3D","line":195,"updated":"2013-01-22 12:01:15.000000000","message":"Do we have a plan  pass the macs to nova-network , store the macs passed by driver instead of  the  default random macs generated  into db table nova.virtual_interfaces , that means passing  down the macs until into method add_virtual_interface(nova/nova/network/manager.py)  . this will help the hyper-visor which can\u0027t accept  default random mac generated by utils.generate_mac_address()","commit_id":"b6b9ca1136de4b1dbb01b059d8e954dbaf0508cb"}],"nova/network/quantumv2/api.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"581085bbac381c08c34004ed80c617774395ad69","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def allocate_for_instance(self, context, instance, **kwargs):"},{"line_number":102,"context_line":"        \"\"\"Allocate all network resources for the instance."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :param macs: None or a set of MAC addresses that the instance"},{"line_number":105,"context_line":"            should use. macs is supplied by the hypervisor driver (contrast"},{"line_number":106,"context_line":"            with requested_networks which is user supplied)."},{"line_number":107,"context_line":"            NB: QuantumV2 does not yet honour mac address limits."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fng8%3D","line":104,"updated":"2013-01-13 00:18:29.000000000","message":"Ditto on fixing other params, although it feels weird to document the contents of kwargs like this.","commit_id":"ad5ebe9edc73b0e99d19a7d8b9322d2513bef94a"}]}