)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c1eb96291c80b55a478ea01a97b7b834afdcdb2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    exception.ConfigDriveInvalidValue: _(\"Invalid config_drive provided.\"),"},{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"GB_TO_MB \u003d 1024"},{"line_number":99,"context_line":"MB_TO_KB \u003d 1024"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_8d379baf","line":98,"updated":"2015-06-23 08:33:20.000000000","message":"Can you use module \u0027units\u0027 here","commit_id":"a28b5845e935bf5078a05f3ed75bdbfae1c5a66e"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d815994b3d53f8d328a682a5fe644559589d9708","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    exception.ConfigDriveInvalidValue: _(\"Invalid config_drive provided.\"),"},{"line_number":96,"context_line":"}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"GB_TO_MB \u003d 1024"},{"line_number":99,"context_line":"MB_TO_KB \u003d 1024"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_58eb9378","line":98,"in_reply_to":"fa32b979_8d379baf","updated":"2015-06-23 08:57:51.000000000","message":"Agree with sahid, please import units from oslo_utils and use constants, provided by it instead","commit_id":"a28b5845e935bf5078a05f3ed75bdbfae1c5a66e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c1eb96291c80b55a478ea01a97b7b834afdcdb2","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                image \u003d self.image_api.get(context, image_uuid)"},{"line_number":506,"context_line":"                size \u003d image.get(\"size\")"},{"line_number":507,"context_line":"                vol_size \u003d bdm.get(\u0027volume_size\u0027)"},{"line_number":508,"context_line":"                if isinstance(vol_size, int):"},{"line_number":509,"context_line":"                    if(vol_size * GB_TO_MB * MB_TO_KB \u003c size):"},{"line_number":510,"context_line":"                        msg \u003d _(\"Image size greater than volume size\")"},{"line_number":511,"context_line":"                        raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ade05fcd","line":508,"updated":"2015-06-23 08:33:20.000000000","message":"You need to use \u0027validate_integer\u0027","commit_id":"a28b5845e935bf5078a05f3ed75bdbfae1c5a66e"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d815994b3d53f8d328a682a5fe644559589d9708","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                image \u003d self.image_api.get(context, image_uuid)"},{"line_number":506,"context_line":"                size \u003d image.get(\"size\")"},{"line_number":507,"context_line":"                vol_size \u003d bdm.get(\u0027volume_size\u0027)"},{"line_number":508,"context_line":"                if isinstance(vol_size, int):"},{"line_number":509,"context_line":"                    if(vol_size * GB_TO_MB * MB_TO_KB \u003c size):"},{"line_number":510,"context_line":"                        msg \u003d _(\"Image size greater than volume size\")"},{"line_number":511,"context_line":"                        raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d8532338","line":508,"in_reply_to":"fa32b979_ade05fcd","updated":"2015-06-23 08:57:51.000000000","message":"+1 hint: utils.validate_integer()","commit_id":"a28b5845e935bf5078a05f3ed75bdbfae1c5a66e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0c1eb96291c80b55a478ea01a97b7b834afdcdb2","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                size \u003d image.get(\"size\")"},{"line_number":507,"context_line":"                vol_size \u003d bdm.get(\u0027volume_size\u0027)"},{"line_number":508,"context_line":"                if isinstance(vol_size, int):"},{"line_number":509,"context_line":"                    if(vol_size * GB_TO_MB * MB_TO_KB \u003c size):"},{"line_number":510,"context_line":"                        msg \u003d _(\"Image size greater than volume size\")"},{"line_number":511,"context_line":"                        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":512,"context_line":"            except (exception.NotFound, exception.InvalidImageRef):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_8d047b7e","line":509,"updated":"2015-06-23 08:33:20.000000000","message":"Don\u0027t we have an \"option\" when volume size set to 0 means using the size of the image?","commit_id":"a28b5845e935bf5078a05f3ed75bdbfae1c5a66e"}]}