)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c64290e1fd48ba66712f01572d0e2a56a6b7c70","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The TrustedFilter is the only in-tree scheduler filter that calls an external"},{"line_number":10,"context_line":"3rd-party service (OpenAttestation) for decision-making. Thus, the OAT service"},{"line_number":11,"context_line":"is not listed as an official Nova dependency and consequently not even gated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Since it is pretty easy to provide out-of-tree filters by amending the"},{"line_number":14,"context_line":"configuration flag scheduler_available_filters and providing a totally"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_a1b60ff7","line":11,"updated":"2015-09-23 13:26:08.000000000","message":"There are many scheduler filters that are not gated in our CI system, so that on it\u0027s own isn\u0027t a reason to remove it.  But I think the fact it requires an out of tree service makes it unique - so maybe if Intel could provide 3rd party CI we\u0027d be more OK with that?  From the mailing list it sounds like there are users of this filter.\n\nFrom this thread:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-June/067869.html\n\nIt sounds like there are ideas for an alternative here, but not fully fleshed out.  If there are users of this filter then I tend to think we should be at least proposing a way forward on an alternative to replace this.  Until then, we could require 3rd party CI for this filter since it has the external dependency.\n\nOtherwise I also don\u0027t think external dependencies are reasons to remove things from nova - there are many cases of needing to have an external dependency installed to run a certain configuration, e.g. ceph, scaleio volume backend, pretty much 85% of all of cinder and neutron, etc.","commit_id":"b0330258ae23011e82bf9be5bcf220f444c39236"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4834be6828d2cd436f86ad4436be096d3d4083c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[1] http://lists.openstack.org/pipermail/openstack-dev/2015-June/067766.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DocImpact"},{"line_number":23,"context_line":"- docs have to mention that this filter is now deprecated"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Related-Bug: #1456228"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_1896a64c","line":23,"updated":"2015-09-25 19:42:19.000000000","message":"It\u0027s not deprecated, so I\u0027d just remove this - there is no DocImpact really.  You\u0027ve already updated the nova devref as part of this change.","commit_id":"5a5e3678508cc11cd97b50405f2ab7f2b3512191"}],"nova/scheduler/filters/trusted_filter.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c64290e1fd48ba66712f01572d0e2a56a6b7c70","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return trust \u003d\u003d level"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"class TrustedFilter(filters.BaseHostFilter):"},{"line_number":254,"context_line":"    \"\"\"Trusted filter to support Trusted Compute Pools.\"\"\""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_2f0bcb2b","line":253,"updated":"2015-09-23 13:26:08.000000000","message":"Might actually be nicer to just decorate this with debtcollector.remove:\n\nhttps://github.com/openstack/debtcollector/blob/master/debtcollector/removals.py#L28\n\nThat\u0027s the oslo library used to indicate things are deprecated for removal.","commit_id":"b0330258ae23011e82bf9be5bcf220f444c39236"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af24b9e2d93bb81eff0c1527a207dd69b8d76552","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def __init__(self):"},{"line_number":257,"context_line":"        self.compute_attestation \u003d ComputeAttestation()"},{"line_number":258,"context_line":"        LOG.warning(_LW(\"The TrustedFilter is considered experimental \u0027"},{"line_number":259,"context_line":"                        \u0027by the OpenStack project because it receives much \u0027"},{"line_number":260,"context_line":"                        \u0027less testing than the rest of Nova. This may change \u0027"},{"line_number":261,"context_line":"                        \u0027in the future, but current deployers should be aware \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_bd7e8ce2","line":258,"updated":"2015-09-25 19:21:35.000000000","message":"The \" and \u0027 usage here is blowing up the world.","commit_id":"0e29b59ebccd4f28a21da88b678de1aa36695bd0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"200ef3afae171f99c9a39ddf5605e2b31e89d533","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def __init__(self):"},{"line_number":257,"context_line":"        self.compute_attestation \u003d ComputeAttestation()"},{"line_number":258,"context_line":"        LOG.warning(_LW(\u0027The TrustedFilter is considered experimental \u0027"},{"line_number":259,"context_line":"                        \u0027by the OpenStack project because it receives much \u0027"},{"line_number":260,"context_line":"                        \u0027less testing than the rest of Nova. This may change \u0027"},{"line_number":261,"context_line":"                        \u0027in the future, but current deployers should be aware \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_041dbbbc","line":258,"updated":"2015-09-28 12:37:20.000000000","message":"I hope this only happens once, I think thats true.","commit_id":"e134536d0a7a555088f1af5d75d573ed50352f1a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ee05b4dd7e2ae90b56835a048e07df1fc957181c","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def __init__(self):"},{"line_number":257,"context_line":"        self.compute_attestation \u003d ComputeAttestation()"},{"line_number":258,"context_line":"        LOG.warning(_LW(\u0027The TrustedFilter is considered experimental \u0027"},{"line_number":259,"context_line":"                        \u0027by the OpenStack project because it receives much \u0027"},{"line_number":260,"context_line":"                        \u0027less testing than the rest of Nova. This may change \u0027"},{"line_number":261,"context_line":"                        \u0027in the future, but current deployers should be aware \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_6927a864","line":258,"in_reply_to":"9a1a9d01_041dbbbc","updated":"2015-09-28 14:44:44.000000000","message":"Yup, it only runs at the scheduler start when it loads all the filters in nova.loadables","commit_id":"e134536d0a7a555088f1af5d75d573ed50352f1a"}]}