)]}'
{"nova/tests/unit/virt/hyperv/test_vmutils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6e45ee01a39ce9e0319e902f0bb9bc656607d7da","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        path \u003d self._vmutils.get_vm_scsi_controller(self._FAKE_VM_NAME)"},{"line_number":256,"context_line":"        self.assertEqual(self._FAKE_RES_PATH, path)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @mock.patch(\"nova.virt.hyperv.vmutils.VMUtils.get_attached_disks\")"},{"line_number":259,"context_line":"    def test_get_free_controller_slot(self, mock_get_attached_disks):"},{"line_number":260,"context_line":"        with mock.patch.object(self._vmutils,"},{"line_number":261,"context_line":"                               \u0027_get_disk_resource_address\u0027) as mock_get_addr:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f56c130a","line":258,"updated":"2015-08-10 16:26:00.000000000","message":"Nit: its probably easier to mock get_attached_disks and _get_disk_resource_address in the same way, unless I am missing something.\n\nBut this approach is OK, I guess.","commit_id":"7dfdeba9993366a36325fa5e8a8c13bd679110a2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6e45ee01a39ce9e0319e902f0bb9bc656607d7da","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        mock_get_attached_disks.return_value \u003d ("},{"line_number":280,"context_line":"            [mock.sentinel.drive] * constants.SCSI_CONTROLLER_SLOTS_NUMBER)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        with mock.patch.multiple(self._vmutils,"},{"line_number":283,"context_line":"                                 get_attached_disks\u003dmock_get_attached_disks,"},{"line_number":284,"context_line":"                                 _get_disk_resource_address\u003dmock_get_address):"},{"line_number":285,"context_line":"            self.assertRaises(vmutils.HyperVException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d0f9e5c9","line":282,"updated":"2015-08-10 16:26:00.000000000","message":"Nit, I prefer using @mock calls in these cases, but thats just my preference, I guess.","commit_id":"7dfdeba9993366a36325fa5e8a8c13bd679110a2"}]}