)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a2eb20fe6d91d8aadd7625d011e33398b58ebfd8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Nova conf:"},{"line_number":14,"context_line":"[vmware]"},{"line_number":15,"context_line":"vmware_ovs_integration_bridge\u003dName of integration bridge used by Open vSwitch, defaults to \u0027br-int\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib56b8a49773b933be82de04576deb832ef89a0bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAM3%2F%2FWiI%3D","line":15,"updated":"2013-01-25 22:46:41.000000000","message":"This commit message needs to say \"DocImpact\" somewhere if it affects configuration.","commit_id":"6bff0424f26d702450f8862462dbc0ccdf40cddf"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"5e7c1b401f9957f897133840e3ee03f0a1c8dd8f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vmware_ovs_integration_bridge\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opts(vmware_vif_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FmKo%3D","line":47,"updated":"2013-01-14 17:55:23.000000000","message":"For any new options being introduced for this driver, can you do it in a new option group?\n\n    [vmwareapi]\n    whatever\u003dFalse\n\nSearch for OptGroup for examples","commit_id":"4758d162122a9a607bd2b4db977d0e380897e877"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c141e37b17a37eb00466b8f48fe373dd6265d9e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vmware_ovs_integration_bridge\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opts(vmware_vif_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fhi4%3D","line":47,"in_reply_to":"AAAAM3%2F%2Fl3s%3D","updated":"2013-01-17 12:20:55.000000000","message":"Agree with Russell here, would be nice to get this into an option group for vmware options.","commit_id":"4758d162122a9a607bd2b4db977d0e380897e877"},{"author":{"_account_id":5149,"name":"Sean Chen","email":"xuchenx@gmail.com","username":"opencompute"},"change_message_id":"dbe9329f427ce03b0a4a49502c030231be29b6d1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vmware_ovs_integration_bridge\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":47,"context_line":"    ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opts(vmware_vif_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fl3s%3D","line":47,"in_reply_to":"AAAAM3%2F%2FmKo%3D","updated":"2013-01-14 20:21:52.000000000","message":"This is inline with the current xenapi_ovs_integration_bridge for xenapi, I think introducing new option group for network integration is optional, or probably should be done independently.","commit_id":"4758d162122a9a607bd2b4db977d0e380897e877"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a2eb20fe6d91d8aadd7625d011e33398b58ebfd8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"vmware_vif_opts \u003d ["},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vmware_ovs_integration_bridge\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":47,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWh8%3D","line":44,"updated":"2013-01-25 22:46:41.000000000","message":"The \u0027vmware_\u0027 prefix isn\u0027t really needed here since it\u0027s in the [vmware] option group.","commit_id":"6bff0424f26d702450f8862462dbc0ccdf40cddf"},{"author":{"_account_id":5149,"name":"Sean Chen","email":"xuchenx@gmail.com","username":"opencompute"},"change_message_id":"817e29c4abcf23a01a803f512055be46648e6aed","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"vmware_vif_opts \u003d ["},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vmware_ovs_integration_bridge\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Name of Integration Bridge used by Open vSwitch\u0027),"},{"line_number":47,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWfo%3D","line":44,"in_reply_to":"AAAAM3%2F%2FWh8%3D","updated":"2013-01-25 23:16:26.000000000","message":"maybe just integration bridge.","commit_id":"6bff0424f26d702450f8862462dbc0ccdf40cddf"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a2eb20fe6d91d8aadd7625d011e33398b58ebfd8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            vif_infos \u003d []"},{"line_number":180,"context_line":"            for (network, mapping) in network_info:"},{"line_number":181,"context_line":"                mac_address \u003d mapping[\u0027mac\u0027]"},{"line_number":182,"context_line":"                network_name \u003d network[\u0027bridge\u0027] or \\"},{"line_number":183,"context_line":"                               CONF.vmware.vmware_ovs_integration_bridge"},{"line_number":184,"context_line":"                if mapping.get(\u0027should_create_vlan\u0027):"},{"line_number":185,"context_line":"                    network_ref \u003d vmwarevif.ensure_vlan_bridge("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWhs%3D","line":182,"updated":"2013-01-25 22:46:41.000000000","message":"Is \u0027bridge\u0027 always present?  The libvirt driver uses .get() for this, so something like ...\n\n    def get_bridge_name(self, network):\n        return network.get(\u0027bridge\u0027) or CONF.vmware.ovs_bridge","commit_id":"6bff0424f26d702450f8862462dbc0ccdf40cddf"},{"author":{"_account_id":5149,"name":"Sean Chen","email":"xuchenx@gmail.com","username":"opencompute"},"change_message_id":"817e29c4abcf23a01a803f512055be46648e6aed","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            vif_infos \u003d []"},{"line_number":180,"context_line":"            for (network, mapping) in network_info:"},{"line_number":181,"context_line":"                mac_address \u003d mapping[\u0027mac\u0027]"},{"line_number":182,"context_line":"                network_name \u003d network[\u0027bridge\u0027] or \\"},{"line_number":183,"context_line":"                               CONF.vmware.vmware_ovs_integration_bridge"},{"line_number":184,"context_line":"                if mapping.get(\u0027should_create_vlan\u0027):"},{"line_number":185,"context_line":"                    network_ref \u003d vmwarevif.ensure_vlan_bridge("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FWf4%3D","line":182,"in_reply_to":"AAAAM3%2F%2FWhs%3D","updated":"2013-01-25 23:16:26.000000000","message":"I think either way is fine.","commit_id":"6bff0424f26d702450f8862462dbc0ccdf40cddf"}]}