)]}'
{"nova/virt/hyperv/vmops.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a3d4bdf7fa3af3d39f9c2c435602e4f60ea7b0c6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    \u0027instead of a disk drive\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027hyperv_vif_driver\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027nova.virt.hyperv.vif.HyperVQuantumVIFDriver\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027The Hyper-V VIF driver\u0027),"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FmGQ%3D","line":56,"updated":"2013-01-14 18:25:47.000000000","message":"Can you create a \"hyperv\" configuration OptGroup?  I think it would be nice to start putting hyperv specific options in its own configuration group.\n\n    [hyperv]\n    vif_driver\u003dwhatever\n\nI\u0027m also *really* not a fan of options that take a class path as its value.  Could it just be \"vif_driver\u003dquantum\" and then map that as necessary in the code?","commit_id":"11f9c2e28a3aa43cb5185923abc0292fb66fa3cc"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"42d78aceee6217ca777b70ec4e8f66d0329bbdc6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    \u0027instead of a disk drive\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027hyperv_vif_driver\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027nova.virt.hyperv.vif.HyperVQuantumVIFDriver\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027The Hyper-V VIF driver\u0027),"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fl4A%3D","line":56,"in_reply_to":"AAAAM3%2F%2FmEg%3D","updated":"2013-01-14 20:13:08.000000000","message":"The reason why I agree with Russell here is that refactoring of the class name and path would break config compatibility. Considering that in this case I don\u0027t see options beside \u0027nova\u0027 and \u0027vif\u0027 it\u0027s IMO a fair price to pay.\nI wouldn\u0027t agree in cases in which decoupling is a must, e.g.: the compute driver class name","commit_id":"11f9c2e28a3aa43cb5185923abc0292fb66fa3cc"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"919c99657644ddd4e021e17daa8391c3af004fe1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                    \u0027instead of a disk drive\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027hyperv_vif_driver\u0027,"},{"line_number":55,"context_line":"               default\u003d\u0027nova.virt.hyperv.vif.HyperVQuantumVIFDriver\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027The Hyper-V VIF driver\u0027),"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FmEg%3D","line":56,"in_reply_to":"AAAAM3%2F%2FmGQ%3D","updated":"2013-01-14 18:39:07.000000000","message":"I think the option group setting change is an appropriate fix. I\u0027m not sold on the other change. Russel and I have a disagreement on just how modular things should be in Nova. I\u0027m personally fine with this the way it is.","commit_id":"11f9c2e28a3aa43cb5185923abc0292fb66fa3cc"}],"nova/virt/hyperv/vmutils.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"ba19c7f37b1482d0f74d57d6ae79cd3bfbafe765","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def modify_virt_resource(self, conn, res_setting_data, target_vm):"},{"line_number":149,"context_line":"        \"\"\"Updates a VM resource.\"\"\""},{"line_number":150,"context_line":"        vs_man_svc \u003d conn.Msvm_VirtualSystemManagementService()[0]"},{"line_number":151,"context_line":"        (job, ret_val) \u003d vs_man_svc.\\"},{"line_number":152,"context_line":"                    ModifyVirtualSystemResources("},{"line_number":153,"context_line":"                        ResourceSettingData\u003d[res_setting_data.GetText_(1)],"},{"line_number":154,"context_line":"                        ComputerSystem\u003dtarget_vm.path_())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FoSs%3D","line":151,"updated":"2013-01-11 22:37:40.000000000","message":"Can you avoid the backslash?","commit_id":"9a523a080ca0d2e5647d32979bedb562adf8476e"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"19c9b4641e53a5a3c4f18133a51eaf7b2c04686c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def modify_virt_resource(self, conn, res_setting_data, target_vm):"},{"line_number":149,"context_line":"        \"\"\"Updates a VM resource.\"\"\""},{"line_number":150,"context_line":"        vs_man_svc \u003d conn.Msvm_VirtualSystemManagementService()[0]"},{"line_number":151,"context_line":"        (job, ret_val) \u003d vs_man_svc.\\"},{"line_number":152,"context_line":"                    ModifyVirtualSystemResources("},{"line_number":153,"context_line":"                        ResourceSettingData\u003d[res_setting_data.GetText_(1)],"},{"line_number":154,"context_line":"                        ComputerSystem\u003dtarget_vm.path_())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FoSY%3D","line":151,"in_reply_to":"AAAAM3%2F%2FoSs%3D","updated":"2013-01-11 22:41:44.000000000","message":"Done","commit_id":"9a523a080ca0d2e5647d32979bedb562adf8476e"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"ba19c7f37b1482d0f74d57d6ae79cd3bfbafe765","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    ModifyVirtualSystemResources("},{"line_number":153,"context_line":"                        ResourceSettingData\u003d[res_setting_data.GetText_(1)],"},{"line_number":154,"context_line":"                        ComputerSystem\u003dtarget_vm.path_())"},{"line_number":155,"context_line":"        success \u003d True"},{"line_number":156,"context_line":"        if ret_val \u003d\u003d constants.WMI_JOB_STATUS_STARTED:"},{"line_number":157,"context_line":"            success \u003d self.check_job_status(job)"},{"line_number":158,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FoS0%3D","line":155,"updated":"2013-01-11 22:37:40.000000000","message":"This variable is always overwritten so this line is useless.","commit_id":"9a523a080ca0d2e5647d32979bedb562adf8476e"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"19c9b4641e53a5a3c4f18133a51eaf7b2c04686c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    ModifyVirtualSystemResources("},{"line_number":153,"context_line":"                        ResourceSettingData\u003d[res_setting_data.GetText_(1)],"},{"line_number":154,"context_line":"                        ComputerSystem\u003dtarget_vm.path_())"},{"line_number":155,"context_line":"        success \u003d True"},{"line_number":156,"context_line":"        if ret_val \u003d\u003d constants.WMI_JOB_STATUS_STARTED:"},{"line_number":157,"context_line":"            success \u003d self.check_job_status(job)"},{"line_number":158,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FoSU%3D","line":155,"in_reply_to":"AAAAM3%2F%2FoS0%3D","updated":"2013-01-11 22:41:44.000000000","message":"Done","commit_id":"9a523a080ca0d2e5647d32979bedb562adf8476e"}]}