)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"edbfad0e76fd0d9934e64230b544cb07501dac03","unresolved":false,"context_lines":[{"line_number":3168,"context_line":"                               image_type\u003dNone):"},{"line_number":3169,"context_line":"        discard_mode \u003d CONF.libvirt.hw_disk_discard"},{"line_number":3170,"context_line":"        backend \u003d self.image_backend.backend(image_type)"},{"line_number":3171,"context_line":"        if discard_mode:"},{"line_number":3172,"context_line":"            if ((backend.MIN_LIBVIRT_DISCARD_VERSION is None) or"},{"line_number":3173,"context_line":"                    (backend.MIN_QEMU_DISCARD_VERSION is None)):"},{"line_number":3174,"context_line":"                if discard_mode \u003d\u003d \u0027ignore\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_91d07bf9","line":3171,"updated":"2015-07-05 05:33:03.000000000","message":"any reason why we cannot do lines 3172 - 3179 in the backend class when the driver starts?","commit_id":"9d7fa9e8a4b72b52930da44e1b6067af4e7b4e4c"},{"author":{"_account_id":15385,"name":"Ivan Mironov","email":"mironov@ru.ibm.com","username":"ivan_mironov"},"change_message_id":"3d8ec747b3973f2f4b25f064b24e2741a09778fd","unresolved":false,"context_lines":[{"line_number":3168,"context_line":"                               image_type\u003dNone):"},{"line_number":3169,"context_line":"        discard_mode \u003d CONF.libvirt.hw_disk_discard"},{"line_number":3170,"context_line":"        backend \u003d self.image_backend.backend(image_type)"},{"line_number":3171,"context_line":"        if discard_mode:"},{"line_number":3172,"context_line":"            if ((backend.MIN_LIBVIRT_DISCARD_VERSION is None) or"},{"line_number":3173,"context_line":"                    (backend.MIN_QEMU_DISCARD_VERSION is None)):"},{"line_number":3174,"context_line":"                if discard_mode \u003d\u003d \u0027ignore\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_55641c48","line":3171,"in_reply_to":"ba3cc151_91d07bf9","updated":"2015-07-05 14:27:09.000000000","message":"This will require passing discard_mode back from imagebackend, slightly increasing code complexity without any real benefits.\n\nI don\u0027t think that splitting this logic into two files is a good idea.","commit_id":"9d7fa9e8a4b72b52930da44e1b6067af4e7b4e4c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"edbfad0e76fd0d9934e64230b544cb07501dac03","unresolved":false,"context_lines":[{"line_number":3169,"context_line":"        discard_mode \u003d CONF.libvirt.hw_disk_discard"},{"line_number":3170,"context_line":"        backend \u003d self.image_backend.backend(image_type)"},{"line_number":3171,"context_line":"        if discard_mode:"},{"line_number":3172,"context_line":"            if ((backend.MIN_LIBVIRT_DISCARD_VERSION is None) or"},{"line_number":3173,"context_line":"                    (backend.MIN_QEMU_DISCARD_VERSION is None)):"},{"line_number":3174,"context_line":"                if discard_mode \u003d\u003d \u0027ignore\u0027:"},{"line_number":3175,"context_line":"                    discard_mode \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_11dc6b17","line":3172,"updated":"2015-07-05 05:33:03.000000000","message":"you do not need the extra brackets here","commit_id":"9d7fa9e8a4b72b52930da44e1b6067af4e7b4e4c"},{"author":{"_account_id":15385,"name":"Ivan Mironov","email":"mironov@ru.ibm.com","username":"ivan_mironov"},"change_message_id":"3d8ec747b3973f2f4b25f064b24e2741a09778fd","unresolved":false,"context_lines":[{"line_number":3169,"context_line":"        discard_mode \u003d CONF.libvirt.hw_disk_discard"},{"line_number":3170,"context_line":"        backend \u003d self.image_backend.backend(image_type)"},{"line_number":3171,"context_line":"        if discard_mode:"},{"line_number":3172,"context_line":"            if ((backend.MIN_LIBVIRT_DISCARD_VERSION is None) or"},{"line_number":3173,"context_line":"                    (backend.MIN_QEMU_DISCARD_VERSION is None)):"},{"line_number":3174,"context_line":"                if discard_mode \u003d\u003d \u0027ignore\u0027:"},{"line_number":3175,"context_line":"                    discard_mode \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_754da0c3","line":3172,"in_reply_to":"ba3cc151_11dc6b17","updated":"2015-07-05 14:27:09.000000000","message":"Done","commit_id":"9d7fa9e8a4b72b52930da44e1b6067af4e7b4e4c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"edbfad0e76fd0d9934e64230b544cb07501dac03","unresolved":false,"context_lines":[{"line_number":3170,"context_line":"        backend \u003d self.image_backend.backend(image_type)"},{"line_number":3171,"context_line":"        if discard_mode:"},{"line_number":3172,"context_line":"            if ((backend.MIN_LIBVIRT_DISCARD_VERSION is None) or"},{"line_number":3173,"context_line":"                    (backend.MIN_QEMU_DISCARD_VERSION is None)):"},{"line_number":3174,"context_line":"                if discard_mode \u003d\u003d \u0027ignore\u0027:"},{"line_number":3175,"context_line":"                    discard_mode \u003d None"},{"line_number":3176,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_31e16fd1","line":3173,"updated":"2015-07-05 05:33:03.000000000","message":"ditto","commit_id":"9d7fa9e8a4b72b52930da44e1b6067af4e7b4e4c"},{"author":{"_account_id":15385,"name":"Ivan Mironov","email":"mironov@ru.ibm.com","username":"ivan_mironov"},"change_message_id":"3d8ec747b3973f2f4b25f064b24e2741a09778fd","unresolved":false,"context_lines":[{"line_number":3170,"context_line":"        backend \u003d self.image_backend.backend(image_type)"},{"line_number":3171,"context_line":"        if discard_mode:"},{"line_number":3172,"context_line":"            if ((backend.MIN_LIBVIRT_DISCARD_VERSION is None) or"},{"line_number":3173,"context_line":"                    (backend.MIN_QEMU_DISCARD_VERSION is None)):"},{"line_number":3174,"context_line":"                if discard_mode \u003d\u003d \u0027ignore\u0027:"},{"line_number":3175,"context_line":"                    discard_mode \u003d None"},{"line_number":3176,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_35c63817","line":3173,"in_reply_to":"ba3cc151_31e16fd1","updated":"2015-07-05 14:27:09.000000000","message":"Done","commit_id":"9d7fa9e8a4b72b52930da44e1b6067af4e7b4e4c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"81f311b8235484bc901ac606c21ed5fd01c91ca1","unresolved":false,"context_lines":[{"line_number":3193,"context_line":"                             \u0027 or later is required.\u0027) %"},{"line_number":3194,"context_line":"                          {\u0027libvirt\u0027: backend.MIN_LIBVIRT_DISCARD_VERSION,"},{"line_number":3195,"context_line":"                           \u0027qemu\u0027: backend.MIN_QEMU_DISCARD_VERSION})"},{"line_number":3196,"context_line":"                    raise exception.Invalid(msg)"},{"line_number":3197,"context_line":""},{"line_number":3198,"context_line":"        image \u003d self.image_backend.image(instance,"},{"line_number":3199,"context_line":"                                         name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_d2ff7fa8","line":3196,"updated":"2015-08-05 11:08:04.000000000","message":"I really think all this logic should live in the imagebackend.py file.\n\nPass the self._host and CONFlibvirt.hw_disk_discard options into the \u0027libvirt_info\u0027 method as parameters and do the checks there.","commit_id":"7585ef7d919ea18f71022f142cfa49ab15d24454"}]}