)]}'
{"nova/compute/monitors/__init__.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ea9057d5c64c16f6a7eb50c205b593aede7b8ef5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                check_func\u003dself.check_enabled_cpu_monitor,"},{"line_number":57,"context_line":"                invoke_args\u003d(resource_tracker,)"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        self.monitors \u003d [obj for obj in cpu_plugin_mgr]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def check_enabled_cpu_monitor(self, ext):"},{"line_number":62,"context_line":"        if self.cpu_monitor_loaded is not False:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_0d0c4493","line":59,"updated":"2015-06-29 15:16:29.000000000","message":"There should be:\n\nself.monitors \u003d [ext.obj for ext in cpu_plugin_mgr]","commit_id":"d67214749dccc15832003a4b821532f8e9bbb932"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7bb4583848ec2995ffbcaf00b1065143305c6765","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                check_func\u003dself.check_enabled_cpu_monitor,"},{"line_number":57,"context_line":"                invoke_args\u003d(resource_tracker,)"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        self.monitors \u003d [obj for obj in cpu_plugin_mgr]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def check_enabled_cpu_monitor(self, ext):"},{"line_number":62,"context_line":"        if self.cpu_monitor_loaded is not False:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_bfbe97fd","line":59,"in_reply_to":"ba3cc151_0d0c4493","updated":"2015-06-29 16:50:07.000000000","message":"Doh, great catch, Alex. Thanks!","commit_id":"d67214749dccc15832003a4b821532f8e9bbb932"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"7c78ba764a81070e4564baf3de1b4832dc49ab2e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def __init__(self, resource_tracker):"},{"line_number":50,"context_line":"        self.cpu_monitor_loaded \u003d False"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        ns \u003d \u0027nova.compute.monitors.cpu\u0027"},{"line_number":53,"context_line":"        cpu_plugin_mgr \u003d enabled.EnabledExtensionManager("},{"line_number":54,"context_line":"                namespace\u003dns,"},{"line_number":55,"context_line":"                invoke_on_load\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_db4559b3","line":52,"updated":"2015-07-01 09:39:45.000000000","message":"Any reason why the namespace is based on CPU?\nShould it be more generic? \n\nI am guessing all the monitors would be under one common namespace and then based on the entry points we should be able to load different monitors?\n\nThe TODO explains it a bit, but i just thought it applies to the whole of the monitorhandler code than just the check_enabled* method?","commit_id":"b98c28183b09529eda0bbf869121795e7b3b69f4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"35aa143001dffd8b653f1715f6cebd22afd490ae","unresolved":false,"context_lines":[{"line_number":26,"context_line":"compute_monitors_opts \u003d ["},{"line_number":27,"context_line":"    cfg.MultiStrOpt(\u0027compute_available_monitors\u0027,"},{"line_number":28,"context_line":"                    deprecated_for_removal\u003dTrue,"},{"line_number":29,"context_line":"                    default\u003dNone,"},{"line_number":30,"context_line":"                    help\u003d\u0027Monitor classes available to the compute which may \u0027"},{"line_number":31,"context_line":"                         \u0027be specified more than once. This option is \u0027"},{"line_number":32,"context_line":"                         \u0027DEPRECATED and no longer used. Use setuptools entry \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_d5d90c85","line":29,"updated":"2015-07-05 13:23:19.000000000","message":"by default the value is None. So we do not need to specifically set this as None","commit_id":"5926f72ff4bc6bfc1fd158119945cbbcdc1a41fa"}],"nova/compute/monitors/cpu/virt_driver.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"d550cc417061ae8d57d0510a8b681424b9895e02","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def __init__(self, resource_tracker):"},{"line_number":37,"context_line":"        super(Monitor, self).__init__(resource_tracker)"},{"line_number":38,"context_line":"        self.source \u003d CONF.compute_driver"},{"line_number":39,"context_line":"        self.driver \u003d self.resource_tracker.driver"},{"line_number":40,"context_line":"        self._data \u003d {}"},{"line_number":41,"context_line":"        self._cpu_stats \u003d {}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_030225b4","line":39,"updated":"2015-07-09 06:55:15.000000000","message":"Minor nit: I think we should use resource_tracker.driver instead of self.resource_tracker.driver","commit_id":"b4e1f7f54b85a6d61d88eff37474a80353c83f2a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0316ce9d6bd9a073e8cb74ddaeccac51d441c4c8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def __init__(self, resource_tracker):"},{"line_number":37,"context_line":"        super(Monitor, self).__init__(resource_tracker)"},{"line_number":38,"context_line":"        self.source \u003d CONF.compute_driver"},{"line_number":39,"context_line":"        self.driver \u003d self.resource_tracker.driver"},{"line_number":40,"context_line":"        self._data \u003d {}"},{"line_number":41,"context_line":"        self._cpu_stats \u003d {}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_52baab24","line":39,"in_reply_to":"ba3cc151_030225b4","updated":"2015-07-13 19:24:18.000000000","message":"Done","commit_id":"b4e1f7f54b85a6d61d88eff37474a80353c83f2a"}]}