)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     PrashantUpadhyay \u003cprashant.upadhyay709070@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-28 17:46:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"check for volume size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added check to ensure volume size"},{"line_number":10,"context_line":"specified by user is greater than"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_00798693","line":7,"updated":"2015-06-28 19:55:52.000000000","message":"Could you please capitalize the first word?","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the image size in boot from volume"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id67d0d1d23b6a7040312643d09dcc2b24ea9e562"},{"line_number":14,"context_line":"Closes-Bug:1465947"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_204b6a5b","line":14,"updated":"2015-06-28 19:55:52.000000000","message":"Missing space and hash. It should be\n\n Closes-Bug: #1465947","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9b0e005390f1284bf7c99c49850890625a058781","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added check to ensure volume size"},{"line_number":10,"context_line":"specified by user is greater than"},{"line_number":11,"context_line":"the image size in boot from volume"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id67d0d1d23b6a7040312643d09dcc2b24ea9e562"},{"line_number":14,"context_line":"Closes-Bug: #1465947"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_2c27a3b7","line":12,"updated":"2015-06-30 11:01:31.000000000","message":"What happens if we don\u0027t check this up front? can you please describe that here?\n\n\nI assume whenever the user gets this wrong, the VM just goes into the Error state anyways, as cinder rejects the request, when we eventually call out to cinder.","commit_id":"2ce40e1622dc1511f66ddd0d0e15320d3133050c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f3266579053efd14f3c4d905d14ad0e73a4b0510","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added check to ensure volume size"},{"line_number":10,"context_line":"specified by user is greater than"},{"line_number":11,"context_line":"the image size in boot from volume"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id67d0d1d23b6a7040312643d09dcc2b24ea9e562"},{"line_number":14,"context_line":"Closes-Bug: #1465947"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_e7dd5443","line":12,"in_reply_to":"ba3cc151_2c27a3b7","updated":"2015-06-30 11:02:03.000000000","message":"Please also add this line in your commit message:\n\nAPIImpact","commit_id":"2ce40e1622dc1511f66ddd0d0e15320d3133050c"}],"nova/api/openstack/compute/plugins/v3/servers.py":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from nova import exception"},{"line_number":42,"context_line":"from nova.i18n import _"},{"line_number":43,"context_line":"from nova.i18n import _LW"},{"line_number":44,"context_line":"import nova.image"},{"line_number":45,"context_line":"from nova.image import glance"},{"line_number":46,"context_line":"from nova import objects"},{"line_number":47,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_806596e2","line":44,"updated":"2015-06-28 19:55:52.000000000","message":"It would be better to do\n\n from nova import image\n\nor\n\n from nova import image as nova_img\n\nor something like that. But please don\u0027t import the whole module paths.","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9785855f596f3b2e6fc6230276dce2c963663ed7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from nova import exception"},{"line_number":42,"context_line":"from nova.i18n import _"},{"line_number":43,"context_line":"from nova.i18n import _LW"},{"line_number":44,"context_line":"import nova.image"},{"line_number":45,"context_line":"from nova.image import glance"},{"line_number":46,"context_line":"from nova import objects"},{"line_number":47,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_2c9c83bf","line":44,"in_reply_to":"ba3cc151_806596e2","updated":"2015-06-30 10:29:31.000000000","message":"+1 for the first one.","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    @extensions.expected_errors(400)"},{"line_number":500,"context_line":"    def _validate_volume_size_with_image_size(self, context,"},{"line_number":501,"context_line":"                         block_device_mapping):"},{"line_number":502,"context_line":"        for bdm in block_device_mapping:"},{"line_number":503,"context_line":"            try:"},{"line_number":504,"context_line":"                image_uuid \u003d bdm.get(\u0027image_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_20628ad9","line":501,"updated":"2015-06-28 19:55:52.000000000","message":"Probably a PEP8 violation, this indentation looks incorrect. Did you run\n\n tox -e pep8\n\n?","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                        vol_size, \"vol_size\")"},{"line_number":513,"context_line":"                except exception.InvalidInput as ee:"},{"line_number":514,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dee.format_message())"},{"line_number":515,"context_line":"                if(vol_size * units.Gi \u003c size):"},{"line_number":516,"context_line":"                    msg \u003d _(\"Image size greater than volume size\")"},{"line_number":517,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":518,"context_line":"            except (exception.NotFound, exception.InvalidImageRef):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a0a45a08","line":515,"updated":"2015-06-28 19:55:52.000000000","message":"You don\u0027t need brackets here. \"If\" statements in Python just work without them:\n\n if vol_size * units.Gi \u003c size:","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from nova.compute import flavors"},{"line_number":40,"context_line":"from nova import exception"},{"line_number":41,"context_line":"from nova.i18n import _"},{"line_number":42,"context_line":"import nova.image"},{"line_number":43,"context_line":"from nova import objects"},{"line_number":44,"context_line":"from nova import policy"},{"line_number":45,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c0a95ee1","line":42,"updated":"2015-06-28 19:55:52.000000000","message":"It would be better to do\n\n from nova import image\n\nor\n\n from nova import image as nova_img\n\nor something like that. But please don\u0027t import the whole module paths.","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"025342b8c4e0ae2929216c523932592c733486fd","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        return requested_networks"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def _validate_volume_size_with_image_size(self, context,"},{"line_number":497,"context_line":"                         block_device_mapping):"},{"line_number":498,"context_line":"        for bdm in block_device_mapping:"},{"line_number":499,"context_line":"            try:"},{"line_number":500,"context_line":"                image_uuid \u003d bdm.get(\u0027image_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_20b92a2f","line":497,"updated":"2015-06-28 19:55:52.000000000","message":"This is exactly the same you wrote in nova/api/openstack/compute/plugins/v3/servers.py.\n\nCould you please move this functionality to some other module and reuse it in API-s without duplicating code?","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9785855f596f3b2e6fc6230276dce2c963663ed7","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        return requested_networks"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def _validate_volume_size_with_image_size(self, context,"},{"line_number":497,"context_line":"                         block_device_mapping):"},{"line_number":498,"context_line":"        for bdm in block_device_mapping:"},{"line_number":499,"context_line":"            try:"},{"line_number":500,"context_line":"                image_uuid \u003d bdm.get(\u0027image_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_2cea4310","line":497,"in_reply_to":"ba3cc151_20b92a2f","updated":"2015-06-30 10:29:31.000000000","message":"right now, we are having to do a lot of this, due to the current state of the API.\n\nmaybe move this into nova.image?","commit_id":"18820bde8acc8717eea73a33a15a5dd17843b240"}]}