)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e59a053a2d2b4a4901794b37d14b4e7ca8c04e12","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sahid \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-29 11:31:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rework can quiesce to not share \"sensitive\" informations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do not want to share with user that the version of libvirt"},{"line_number":10,"context_line":"or hypervisor type is not supported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_58bbf3c4","line":7,"updated":"2015-06-29 11:46:51.000000000","message":"you can drop the \u0027can\u0027","commit_id":"bc33bc92caf3b6bbb5c4472d0083626131ed7e19"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2d9e604388feac2bfa8a31178b40c6ccbdc93b73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sahid \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-29 11:31:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rework can quiesce to not share \"sensitive\" informations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do not want to share with user that the version of libvirt"},{"line_number":10,"context_line":"or hypervisor type is not supported."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_981dfbbf","line":7,"in_reply_to":"ba3cc151_58bbf3c4","updated":"2015-06-29 11:50:59.000000000","message":"Done","commit_id":"bc33bc92caf3b6bbb5c4472d0083626131ed7e19"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"953b30d4ac767b01f76a2deb6d44371a61da53aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rework quiesce to not share \"sensitive\" informations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do not want to share with user that the version of libvirt"},{"line_number":10,"context_line":"or hypervisor type."},{"line_number":11,"context_line":"This commit also introduces a generic exception to handle the case"},{"line_number":12,"context_line":"where the image does not provide the guest agent flag."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_9200c167","line":9,"updated":"2015-07-02 15:12:29.000000000","message":"Could you explain why?  Is it somehow a security issue?","commit_id":"a0e110eb317f16960988a6213a7be44b7bd935fe"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1e784b9b45629132a23a8fbfc2d59a7d7800a93c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rework quiesce to not share \"sensitive\" informations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do not want to share with user that the version of libvirt"},{"line_number":10,"context_line":"or hypervisor type."},{"line_number":11,"context_line":"This commit also introduces a generic exception to handle the case"},{"line_number":12,"context_line":"where the image does not provide the guest agent flag."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_b8907444","line":9,"in_reply_to":"ba3cc151_9200c167","updated":"2015-07-08 13:25:51.000000000","message":"No, I\u0027m not talking about security issue. I think the general policy is to not share  version or lib we use to the users. That will not help users at all and operators can have the choice to communicate or not tools used.","commit_id":"a0e110eb317f16960988a6213a7be44b7bd935fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"224a513601185bd15332d4efadf0fdeb125ccf1b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-09 04:04:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rework quiesce to not share \"sensitive\" informations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do not want to share with user that the version of libvirt"},{"line_number":10,"context_line":"or hypervisor type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_ef5b5b52","line":7,"updated":"2015-07-09 10:24:37.000000000","message":"if you respin informations \u003d\u003e information","commit_id":"fd6c892050a91d2303f7702ad27f07b1ee2e1837"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f83a99c10a2d78d823627765cfbeaf01d5385fb9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rework quiesce to not share \"sensitive\" informations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do not want to share with user that the version of libvirt"},{"line_number":10,"context_line":"or hypervisor type."},{"line_number":11,"context_line":"This commit also introduces a generic exception to handle the case"},{"line_number":12,"context_line":"where the image does not provide the guest agent flag."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_e369e88c","line":9,"updated":"2015-07-20 12:21:16.000000000","message":"Out of curiosity, why would we not want to share this information?\n\nI would also argue the addition of a generic exception is probably the larger change here, IMO. Up to you though.","commit_id":"fd6c892050a91d2303f7702ad27f07b1ee2e1837"}],"nova/compute/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3d50ea37ff8946c08c931675f73e7e658722d217","unresolved":false,"context_lines":[{"line_number":6326,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":6327,"context_line":""},{"line_number":6328,"context_line":"    @messaging.expected_exceptions(exception.InstanceQuiesceNotSupported,"},{"line_number":6329,"context_line":"                                   exception.NovaException,"},{"line_number":6330,"context_line":"                                   NotImplementedError)"},{"line_number":6331,"context_line":"    @wrap_exception()"},{"line_number":6332,"context_line":"    def unquiesce_instance(self, context, instance, mapping\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_2b49d35f","line":6329,"updated":"2015-08-04 11:35:41.000000000","message":"I think you missed one here.","commit_id":"96c226950534d86c3895f6973907969096ad53b1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dedf9647e97d3f0cb9803c452addedfa6a8e8482","unresolved":false,"context_lines":[{"line_number":6326,"context_line":"                timer.start(interval\u003d0.5).wait()"},{"line_number":6327,"context_line":""},{"line_number":6328,"context_line":"    @messaging.expected_exceptions(exception.InstanceQuiesceNotSupported,"},{"line_number":6329,"context_line":"                                   exception.NovaException,"},{"line_number":6330,"context_line":"                                   NotImplementedError)"},{"line_number":6331,"context_line":"    @wrap_exception()"},{"line_number":6332,"context_line":"    def unquiesce_instance(self, context, instance, mapping\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_9d170851","line":6329,"in_reply_to":"1a4dcd0f_2b49d35f","updated":"2015-08-04 12:36:19.000000000","message":"Yes it\u0027s true...","commit_id":"96c226950534d86c3895f6973907969096ad53b1"}],"nova/exception.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e59a053a2d2b4a4901794b37d14b4e7ca8c04e12","unresolved":false,"context_lines":[{"line_number":1814,"context_line":"    msg_fmt \u003d _(\u0027Quiescing is not supported in instance %(instance_id)s\u0027)"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"class QemuGuestAgentNotEnable(Invalid):"},{"line_number":1818,"context_line":"    msg_fmt \u003d _(\u0027QEMU guest agent is not enabled\u0027)"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_d8a06393","line":1817,"updated":"2015-06-29 11:46:51.000000000","message":"Please change to QemuGuestAgentNotEnabled","commit_id":"bc33bc92caf3b6bbb5c4472d0083626131ed7e19"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2d9e604388feac2bfa8a31178b40c6ccbdc93b73","unresolved":false,"context_lines":[{"line_number":1814,"context_line":"    msg_fmt \u003d _(\u0027Quiescing is not supported in instance %(instance_id)s\u0027)"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":""},{"line_number":1817,"context_line":"class QemuGuestAgentNotEnable(Invalid):"},{"line_number":1818,"context_line":"    msg_fmt \u003d _(\u0027QEMU guest agent is not enabled\u0027)"},{"line_number":1819,"context_line":""},{"line_number":1820,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_382b8fed","line":1817,"in_reply_to":"ba3cc151_d8a06393","updated":"2015-06-29 11:50:59.000000000","message":"Sure I will do, thanks for your reviews.","commit_id":"bc33bc92caf3b6bbb5c4472d0083626131ed7e19"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"22dc229accd65b9da49c938277ab6d281af78dcd","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"        img_meta_prop \u003d image_meta.get(\u0027properties\u0027, {}) if image_meta else {}"},{"line_number":1477,"context_line":"        hw_qga \u003d img_meta_prop.get(\u0027hw_qemu_guest_agent\u0027, \u0027\u0027)"},{"line_number":1478,"context_line":"        if not strutils.bool_from_string(hw_qga):"},{"line_number":1479,"context_line":"            raise exception.QemuGuestAgentNotEnabled()"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def _set_quiesced(self, context, instance, image_meta, quiesced):"},{"line_number":1482,"context_line":"        self._can_quiesce(instance, image_meta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b772487b","line":1479,"updated":"2015-07-20 06:00:42.000000000","message":"There is new exception, so we should catch it at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6225 and https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2224\n\nBut they catch NovaException also, that looks like another bug. Maybe we should have another patch remove the NovaException also.","commit_id":"fd6c892050a91d2303f7702ad27f07b1ee2e1837"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a8bb32b18a6d97e957e86487eb4e2b3fd4e42067","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"        img_meta_prop \u003d image_meta.get(\u0027properties\u0027, {}) if image_meta else {}"},{"line_number":1477,"context_line":"        hw_qga \u003d img_meta_prop.get(\u0027hw_qemu_guest_agent\u0027, \u0027\u0027)"},{"line_number":1478,"context_line":"        if not strutils.bool_from_string(hw_qga):"},{"line_number":1479,"context_line":"            raise exception.QemuGuestAgentNotEnabled()"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def _set_quiesced(self, context, instance, image_meta, quiesced):"},{"line_number":1482,"context_line":"        self._can_quiesce(instance, image_meta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_a868a9bb","line":1479,"in_reply_to":"3a50d1a3_1d26bdba","updated":"2015-07-20 07:55:55.000000000","message":"yes, I think we can utlitze the API layer to catch the exception ..","commit_id":"fd6c892050a91d2303f7702ad27f07b1ee2e1837"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"d25e029d712a486ed16c482b5289e633d6f39de5","unresolved":false,"context_lines":[{"line_number":1476,"context_line":"        img_meta_prop \u003d image_meta.get(\u0027properties\u0027, {}) if image_meta else {}"},{"line_number":1477,"context_line":"        hw_qga \u003d img_meta_prop.get(\u0027hw_qemu_guest_agent\u0027, \u0027\u0027)"},{"line_number":1478,"context_line":"        if not strutils.bool_from_string(hw_qga):"},{"line_number":1479,"context_line":"            raise exception.QemuGuestAgentNotEnabled()"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def _set_quiesced(self, context, instance, image_meta, quiesced):"},{"line_number":1482,"context_line":"        self._can_quiesce(instance, image_meta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_1d26bdba","line":1479,"in_reply_to":"3a50d1a3_b772487b","updated":"2015-07-20 07:17:54.000000000","message":"@Alex, why do not think it is a bug here? I feel nova-api will be able to catch this exception and return http 400. Am I wrong? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1111","commit_id":"fd6c892050a91d2303f7702ad27f07b1ee2e1837"}]}