)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Originally, the fixed IPs were associated, and"},{"line_number":14,"context_line":"\"virtual_interface_id\" was updated and saved to the DB at a later time."},{"line_number":15,"context_line":"This value is now sent into associate(_pool) and are tunneled down"},{"line_number":16,"context_line":"to the DB on associate, so now the value saved to the DB at"},{"line_number":17,"context_line":"association."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic37d96deba3a5ef51594733cc16091173a9655a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_50997fcf","line":16,"updated":"2015-09-08 17:41:08.000000000","message":"s/saved/is saved/","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"}],"nova/db/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d993d54d4facc9dfbd5d2cdba7098df2ca4af90b","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def fixed_ip_associate(context, address, instance_uuid, network_id\u003dNone,"},{"line_number":491,"context_line":"                       reserved\u003dFalse, allocated\u003dTrue,"},{"line_number":492,"context_line":"                       virtual_interface_id\u003dNone):"},{"line_number":493,"context_line":"    \"\"\"Associate fixed ip to instance."},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_70dece6e","line":491,"updated":"2015-06-30 15:21:38.000000000","message":"We don\u0027t need the allocated parameter here, it\u0027s implied if virtual_interface_id is passed in.","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d4662cd536b73155591a7f7882efd2cefe16508a","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def fixed_ip_associate(context, address, instance_uuid, network_id\u003dNone,"},{"line_number":491,"context_line":"                       reserved\u003dFalse, allocated\u003dTrue,"},{"line_number":492,"context_line":"                       virtual_interface_id\u003dNone):"},{"line_number":493,"context_line":"    \"\"\"Associate fixed ip to instance."},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_4b8f63cc","line":491,"in_reply_to":"ba3cc151_70dece6e","updated":"2015-08-05 18:13:52.000000000","message":"Done","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d993d54d4facc9dfbd5d2cdba7098df2ca4af90b","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"def fixed_ip_associate_pool(context, network_id, instance_uuid\u003dNone,"},{"line_number":503,"context_line":"                            host\u003dNone, allocated\u003dTrue,"},{"line_number":504,"context_line":"                            virtual_interface_id\u003dNone):"},{"line_number":505,"context_line":"    \"\"\"Find free ip in network and associate it to instance or host."},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_50e38a33","line":503,"updated":"2015-06-30 15:21:38.000000000","message":"ditto","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d4662cd536b73155591a7f7882efd2cefe16508a","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"def fixed_ip_associate_pool(context, network_id, instance_uuid\u003dNone,"},{"line_number":503,"context_line":"                            host\u003dNone, allocated\u003dTrue,"},{"line_number":504,"context_line":"                            virtual_interface_id\u003dNone):"},{"line_number":505,"context_line":"    \"\"\"Find free ip in network and associate it to instance or host."},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ebbc2f6e","line":503,"in_reply_to":"ba3cc151_50e38a33","updated":"2015-08-05 18:13:52.000000000","message":"Done","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d993d54d4facc9dfbd5d2cdba7098df2ca4af90b","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                                                instance_uuid\u003dinstance_uuid)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        params \u003d {\u0027instance_uuid\u0027: instance_uuid,"},{"line_number":1141,"context_line":"                  \u0027allocated\u0027: allocated}"},{"line_number":1142,"context_line":"        if not fixed_ip_ref.network_id:"},{"line_number":1143,"context_line":"            params[\u0027network_id\u0027] \u003d network_id"},{"line_number":1144,"context_line":"        if virtual_interface_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_50baaa0b","line":1141,"updated":"2015-06-30 15:21:38.000000000","message":"So, we should just set the allocated value depending on whether or not virtual_inteface_id is provided.","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d4662cd536b73155591a7f7882efd2cefe16508a","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                                                instance_uuid\u003dinstance_uuid)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        params \u003d {\u0027instance_uuid\u0027: instance_uuid,"},{"line_number":1141,"context_line":"                  \u0027allocated\u0027: allocated}"},{"line_number":1142,"context_line":"        if not fixed_ip_ref.network_id:"},{"line_number":1143,"context_line":"            params[\u0027network_id\u0027] \u003d network_id"},{"line_number":1144,"context_line":"        if virtual_interface_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_2e3545d9","line":1141,"in_reply_to":"ba3cc151_50baaa0b","updated":"2015-08-05 18:13:52.000000000","message":"Done","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d993d54d4facc9dfbd5d2cdba7098df2ca4af90b","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        if not fixed_ip_ref:"},{"line_number":1186,"context_line":"            raise exception.NoMoreFixedIps(net\u003dnetwork_id)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"        params \u003d {\u0027allocated\u0027: allocated}"},{"line_number":1189,"context_line":"        if fixed_ip_ref[\u0027network_id\u0027] is None:"},{"line_number":1190,"context_line":"            params[\u0027network_id\u0027] \u003d network_id"},{"line_number":1191,"context_line":"        if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_103bc29d","line":1188,"updated":"2015-06-30 15:21:38.000000000","message":"ditto","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d4662cd536b73155591a7f7882efd2cefe16508a","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        if not fixed_ip_ref:"},{"line_number":1186,"context_line":"            raise exception.NoMoreFixedIps(net\u003dnetwork_id)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"        params \u003d {\u0027allocated\u0027: allocated}"},{"line_number":1189,"context_line":"        if fixed_ip_ref[\u0027network_id\u0027] is None:"},{"line_number":1190,"context_line":"            params[\u0027network_id\u0027] \u003d network_id"},{"line_number":1191,"context_line":"        if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_6e690dbe","line":1188,"in_reply_to":"ba3cc151_103bc29d","updated":"2015-08-05 18:13:52.000000000","message":"Done","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"}],"nova/objects/fixed_ip.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7f1a69768c3abddc821c1790bd0cf6838b30ce6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # Version 1.10: Instance 1.20"},{"line_number":44,"context_line":"    # Version 1.11: Added allocated \u0026 vif_id kwargs to"},{"line_number":45,"context_line":"    #               associate(_pool)"},{"line_number":46,"context_line":"    VERSION \u003d \u00271.11\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    fields \u003d {"},{"line_number":49,"context_line":"        \u0027id\u0027: fields.IntegerField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f0609e37","line":46,"updated":"2015-06-30 15:26:29.000000000","message":"Note that you\u0027ll also need to update the versions in the other objects that have FixedIP as a sub-object, like FloatingIP:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/objects/floating_ip.py#n28","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7f1a69768c3abddc821c1790bd0cf6838b30ce6","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":152,"context_line":"    def associate(cls, context, address, instance_uuid, network_id\u003dNone,"},{"line_number":153,"context_line":"                  reserved\u003dFalse, allocated\u003dTrue, vif_id\u003dNone):"},{"line_number":154,"context_line":"        db_fixedip \u003d db.fixed_ip_associate(context, address, instance_uuid,"},{"line_number":155,"context_line":"                                           network_id\u003dnetwork_id,"},{"line_number":156,"context_line":"                                           reserved\u003dreserved,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_1093c250","line":153,"updated":"2015-06-30 15:26:29.000000000","message":"Drop the allocated parameter and name the vif_id parameter as virtual_interface_id to make the db api method signature and to match the actual field name in this object.","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d4662cd536b73155591a7f7882efd2cefe16508a","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":152,"context_line":"    def associate(cls, context, address, instance_uuid, network_id\u003dNone,"},{"line_number":153,"context_line":"                  reserved\u003dFalse, allocated\u003dTrue, vif_id\u003dNone):"},{"line_number":154,"context_line":"        db_fixedip \u003d db.fixed_ip_associate(context, address, instance_uuid,"},{"line_number":155,"context_line":"                                           network_id\u003dnetwork_id,"},{"line_number":156,"context_line":"                                           reserved\u003dreserved,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_0e8c0934","line":153,"in_reply_to":"ba3cc151_1093c250","updated":"2015-08-05 18:13:52.000000000","message":"Done","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7f1a69768c3abddc821c1790bd0cf6838b30ce6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    # Version 1.7: FixedIP \u003c\u003d version 1.7"},{"line_number":222,"context_line":"    # Version 1.8: FixedIP \u003c\u003d version 1.8"},{"line_number":223,"context_line":"    # Version 1.9: FixedIP \u003c\u003d version 1.9"},{"line_number":224,"context_line":"    # Version 1.10: FixedIP \u003c\u003d version 1.10"},{"line_number":225,"context_line":"    VERSION \u003d \u00271.10\u0027"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_d0b31ae8","line":224,"updated":"2015-06-30 15:26:29.000000000","message":"You have to update this object version also.","commit_id":"dd1e900ccf9c139023caf3fcd09e5cadf96c6082"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # Version 1.10: Instance 1.20"},{"line_number":44,"context_line":"    # Version 1.11: Instance 1.21"},{"line_number":45,"context_line":"    # Version 1.12: Instance 1.22, FloatingIPList 1.9"},{"line_number":46,"context_line":"    # Version 1.13: Added vif_id kwarg to associate(_pool), FloatingIPList 1.10"},{"line_number":47,"context_line":"    VERSION \u003d \u00271.13\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b0501bd6","line":46,"updated":"2015-09-08 17:41:08.000000000","message":"The kwarg is actually \u0027virtual_interface_id\u0027, so update this comment or rename the kwarg in the associate(_pool) methods below.  vif_id might be preferable for brevity.","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":155,"context_line":"    def associate(cls, context, address, instance_uuid, network_id\u003dNone,"},{"line_number":156,"context_line":"                  reserved\u003dFalse, virtual_interface_id\u003dNone):"},{"line_number":157,"context_line":"        kwargs \u003d {\u0027network_id\u0027: network_id,"},{"line_number":158,"context_line":"                  \u0027reserved\u0027: reserved,"},{"line_number":159,"context_line":"                  \u0027virtual_interface_id\u0027: virtual_interface_id}"},{"line_number":160,"context_line":"        db_fixedip \u003d db.fixed_ip_associate(context, address, instance_uuid,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b0fedbac","line":157,"updated":"2015-09-08 17:41:08.000000000","message":"I\u0027m not sure why you separate this out rather than just pass virtual_interface_id\u003dvirtual_interface_id to the DB API method.","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @obj_base.remotable_classmethod"},{"line_number":165,"context_line":"    def associate_pool(cls, context, network_id, instance_uuid\u003dNone,"},{"line_number":166,"context_line":"                       host\u003dNone, virtual_interface_id\u003dNone):"},{"line_number":167,"context_line":"        kwargs \u003d {\u0027instance_uuid\u0027: instance_uuid,"},{"line_number":168,"context_line":"                  \u0027host\u0027: host,"},{"line_number":169,"context_line":"                  \u0027virtual_interface_id\u0027: virtual_interface_id}"},{"line_number":170,"context_line":"        db_fixedip \u003d db.fixed_ip_associate_pool(context, network_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_1024675e","line":167,"updated":"2015-09-08 17:41:08.000000000","message":"ditto, not sure why this has to be separated out.","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":4308,"context_line":"                                         network_id\u003dnetwork[\u0027id\u0027],"},{"line_number":4309,"context_line":"                                         virtual_interface_id\u003dvif[\u0027id\u0027])"},{"line_number":4310,"context_line":""},{"line_number":4311,"context_line":"        self.assertTrue(fixed_ip[\u0027allocated\u0027])"},{"line_number":4312,"context_line":""},{"line_number":4313,"context_line":"    def test_fixed_ip_associate_not_allocated_without_vif(self):"},{"line_number":4314,"context_line":"        instance_uuid \u003d self._create_instance()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_90c63767","line":4311,"updated":"2015-09-08 17:41:08.000000000","message":"Also assert that fixed_ip[\u0027virtual_interface_id\u0027] is set and the correct value:\n\nself.assertEqual(vif[\u0027id\u0027], fixed_ip[\u0027virtual_interface_id\u0027])\n\n--\n\nIt might not be a bad idea to update one of the existing associate tests where vif_id isn\u0027t passed in and we assert that vif_id is None and allocated is False.","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":4316,"context_line":""},{"line_number":4317,"context_line":"        fixed_ip \u003d db.fixed_ip_associate(self.ctxt, address, instance_uuid)"},{"line_number":4318,"context_line":""},{"line_number":4319,"context_line":"        self.assertFalse(fixed_ip[\u0027allocated\u0027])"},{"line_number":4320,"context_line":""},{"line_number":4321,"context_line":"    def test_fixed_ip_associate_pool_invalid_uuid(self):"},{"line_number":4322,"context_line":"        instance_uuid \u003d \u0027123\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b0c33b57","line":4319,"updated":"2015-09-08 17:41:08.000000000","message":"ditto","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"}],"nova/tests/unit/network/test_manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":883,"context_line":"                              mox.IgnoreArg(),"},{"line_number":884,"context_line":"                              network_id\u003dmox.IgnoreArg(),"},{"line_number":885,"context_line":"                              reserved\u003dTrue,"},{"line_number":886,"context_line":"                              virtual_interface_id\u003dmox.IgnoreArg()"},{"line_number":887,"context_line":"                              ).AndReturn(fixed)"},{"line_number":888,"context_line":"        db.virtual_interface_get_by_instance_and_network(mox.IgnoreArg(),"},{"line_number":889,"context_line":"                mox.IgnoreArg(), mox.IgnoreArg()).AndReturn(vifs[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d0a10f97","line":886,"updated":"2015-09-08 17:41:08.000000000","message":"Seems we could do better using vifs[0][\u0027id\u0027] right?","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":917,"context_line":"                                   mox.IgnoreArg(),"},{"line_number":918,"context_line":"                                   instance_uuid\u003dmox.IgnoreArg(),"},{"line_number":919,"context_line":"                                   host\u003dNone,"},{"line_number":920,"context_line":"                                   virtual_interface_id\u003dmox.IgnoreArg()"},{"line_number":921,"context_line":"                                   ).AndReturn(fixed)"},{"line_number":922,"context_line":"        db.virtual_interface_get_by_instance_and_network(mox.IgnoreArg(),"},{"line_number":923,"context_line":"                mox.IgnoreArg(), mox.IgnoreArg()).AndReturn(vifs[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_f09e9353","line":920,"updated":"2015-09-08 17:41:08.000000000","message":"ditto using vifs[0]","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15df56ae183b5c1a4db57f3dd235de52e17218b7","unresolved":false,"context_lines":[{"line_number":1599,"context_line":"                                   mox.IgnoreArg(),"},{"line_number":1600,"context_line":"                                   instance_uuid\u003dmox.IgnoreArg(),"},{"line_number":1601,"context_line":"                                   host\u003dNone,"},{"line_number":1602,"context_line":"                                   virtual_interface_id\u003dmox.IgnoreArg()"},{"line_number":1603,"context_line":"                                   ).AndReturn(fixed)"},{"line_number":1604,"context_line":"        db.network_get(mox.IgnoreArg(),"},{"line_number":1605,"context_line":"                       mox.IgnoreArg(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_10aea781","line":1602,"updated":"2015-09-08 17:41:08.000000000","message":"Seems this could use vifs[0][\u0027id\u0027] also.","commit_id":"f592602677c1f10f531cb861b82f5c7d8690aadb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1250cd5fc3a54d84c7a258a7916b07d44e1ac539","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"                                   mox.IgnoreArg(),"},{"line_number":1599,"context_line":"                                   instance_uuid\u003dmox.IgnoreArg(),"},{"line_number":1600,"context_line":"                                   host\u003dNone,"},{"line_number":1601,"context_line":"                                   virtual_interface_id\u003dmox.IgnoreArg()"},{"line_number":1602,"context_line":"                                   ).AndReturn(fixed)"},{"line_number":1603,"context_line":"        db.network_get(mox.IgnoreArg(),"},{"line_number":1604,"context_line":"                       mox.IgnoreArg(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_a0338a12","line":1601,"updated":"2015-09-10 18:03:14.000000000","message":"Use vifs[0][\u0027id\u0027] here rather than ignoring the arg.","commit_id":"9c3a6d0db188ea737149b48c1be2399bd28a92af"}],"nova/tests/unit/objects/test_fixed_ip.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1250cd5fc3a54d84c7a258a7916b07d44e1ac539","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                             \u0027fake-uuid\u0027)"},{"line_number":165,"context_line":"        associate.assert_called_with(self.context, \u00271.2.3.4\u0027, \u0027fake-uuid\u0027,"},{"line_number":166,"context_line":"                                     network_id\u003dNone, reserved\u003dFalse,"},{"line_number":167,"context_line":"                                     virtual_interface_id\u003dNone)"},{"line_number":168,"context_line":"        self._compare(fixedip, fake_fixed_ip)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @mock.patch(\u0027nova.db.fixed_ip_associate_pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_a01aaa7a","line":167,"updated":"2015-09-10 18:03:14.000000000","message":"Would be good to have a similar test but where we actually do pass in the vif_id.","commit_id":"9c3a6d0db188ea737149b48c1be2399bd28a92af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1250cd5fc3a54d84c7a258a7916b07d44e1ac539","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        self._compare(fixedip, fake_fixed_ip)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @mock.patch(\u0027nova.db.fixed_ip_associate_pool\u0027)"},{"line_number":171,"context_line":"    def test_associate_pool(self, associate):"},{"line_number":172,"context_line":"        associate.return_value \u003d fake_fixed_ip"},{"line_number":173,"context_line":"        fixedip \u003d fixed_ip.FixedIP.associate_pool(self.context, 123,"},{"line_number":174,"context_line":"                                                  \u0027fake-uuid\u0027, \u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_40114e5c","line":171,"updated":"2015-09-10 18:03:14.000000000","message":"ditto","commit_id":"9c3a6d0db188ea737149b48c1be2399bd28a92af"}]}