)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e52d551f90b3c6849f7bbc185a2187860c79aa94","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-06 16:37:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include project_id in instance metadata."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1470179"},{"line_number":10,"context_line":"Change-Id: Idf2ea1473a545a51e1a4e50579da585d8f674f74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_23d81e1d","line":8,"updated":"2015-07-06 17:16:51.000000000","message":"You should probably include more details here on what this is doing and why it\u0027s needed.\n\nI\u0027m not exactly sure how we handle new metadata API versions, i.e. I don\u0027t think a spec is probably needed but a blueprint might be?  Not sure, this is very lightweight.\n\nI think we at least need the DocImpact tag in here so we can call out in the release notes that this is available.","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c107292ed2224685e5ea3a4d2b059d33c9a588ba","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-06 16:37:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include project_id in instance metadata."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1470179"},{"line_number":10,"context_line":"Change-Id: Idf2ea1473a545a51e1a4e50579da585d8f674f74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_83432a6c","line":8,"in_reply_to":"ba3cc151_23d81e1d","updated":"2015-07-06 17:20:11.000000000","message":"There would at least be a doc change here:\n\nhttp://docs.openstack.org/admin-guide-cloud/content/section_metadata-service.html\n\nFor the new version, hence the DocImpact.","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ebb5cc14f97bd5fc26af0b7a99727ef0416c247c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-06 16:37:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include project_id in instance metadata."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1470179"},{"line_number":10,"context_line":"Change-Id: Idf2ea1473a545a51e1a4e50579da585d8f674f74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_356851ba","line":8,"in_reply_to":"ba3cc151_83432a6c","updated":"2015-07-06 17:23:17.000000000","message":"Asking in the mailing list if a blueprint/spec is required for a new api version:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-July/068677.html","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f763cfa922f7e01dc10c45b64a3a500c4d16e739","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-08 21:59:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include project_id in instance metadata."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint instance-id-in-metadata"},{"line_number":10,"context_line":"DocImpact"},{"line_number":11,"context_line":"Closes-Bug: #1470179"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_3deabad8","line":8,"updated":"2015-07-09 20:14:14.000000000","message":"More details would be nice here.","commit_id":"334c2b3db28718a1e012f0be5ebe70da6ffcb144"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f763cfa922f7e01dc10c45b64a3a500c4d16e739","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Include project_id in instance metadata."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint instance-id-in-metadata"},{"line_number":10,"context_line":"DocImpact"},{"line_number":11,"context_line":"Closes-Bug: #1470179"},{"line_number":12,"context_line":"Change-Id: Idf2ea1473a545a51e1a4e50579da585d8f674f74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_fd8c5236","line":10,"updated":"2015-07-09 20:14:14.000000000","message":"The DocImpact tag generates a bug for the doc writers, and should have information on what the actual impact is so they don\u0027t have to hunt for it.\n\nIn this case, I think it just means updating the release notes for Liberty and updating this page:\n\nhttp://docs.openstack.org/admin-guide-cloud/content/section_metadata-service.html","commit_id":"334c2b3db28718a1e012f0be5ebe70da6ffcb144"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa1efb47dc206f960980718dc5b2542af958072e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instances sometimes need to know what project they\u0027re"},{"line_number":10,"context_line":"in in order to manage permissions or naming.  This"},{"line_number":11,"context_line":"change allows an instance to grab its instance id without"},{"line_number":12,"context_line":"needing keystone auth or other work-arounds."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements blueprint instance-id-in-metadata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba3cc151_71cb8972","line":11,"updated":"2015-07-09 21:39:26.000000000","message":"instance id or instance project_id?","commit_id":"63396cbcf14ba60ae8e531e30fe318403beca83f"}],"nova/api/metadata/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e52d551f90b3c6849f7bbc185a2187860c79aa94","unresolved":false,"context_lines":[{"line_number":69,"context_line":"FOLSOM \u003d \u00272012-08-10\u0027"},{"line_number":70,"context_line":"GRIZZLY \u003d \u00272013-04-04\u0027"},{"line_number":71,"context_line":"HAVANA \u003d \u00272013-10-17\u0027"},{"line_number":72,"context_line":"LIBERTY \u003d \u00272015-10-17\u0027"},{"line_number":73,"context_line":"OPENSTACK_VERSIONS \u003d ["},{"line_number":74,"context_line":"    FOLSOM,"},{"line_number":75,"context_line":"    GRIZZLY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_63d866f0","line":72,"updated":"2015-07-06 17:16:51.000000000","message":"nit: technically the liberty release is scheduled for 10/15:\n\nhttps://wiki.openstack.org/wiki/Liberty_Release_Schedule","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"}],"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":6955,"name":"Jan van Eldik","email":"Jan.van.Eldik@cern.ch","username":"vaneldik"},"change_message_id":"44d37fa1b7687253cf29883879414b1378209543","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        inst \u003d self.instance.obj_clone()"},{"line_number":516,"context_line":"        mdinst \u003d fake_InstanceMetadata(self.stubs, inst)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # verify that 2013-04-04 has the \u0027random\u0027 field"},{"line_number":519,"context_line":"        mdjson \u003d mdinst.lookup(\"/openstack/2015-10-17/meta_data.json\")"},{"line_number":520,"context_line":"        mddict \u003d jsonutils.loads(mdjson)"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_0d8628b9","line":518,"updated":"2015-07-01 08:13:27.000000000","message":"Please update the comment to sthg like\n\n# verify that 2015-10-17 has the \u0027project_id\u0027 field","commit_id":"f22047d34519c148dbcc87efb25b8cd2a057fe0f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e52d551f90b3c6849f7bbc185a2187860c79aa94","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def test_project_id(self):"},{"line_number":514,"context_line":"        fakes.stub_out_key_pair_funcs(self.stubs)"},{"line_number":515,"context_line":"        inst \u003d self.instance.obj_clone()"},{"line_number":516,"context_line":"        mdinst \u003d fake_InstanceMetadata(self.stubs, inst)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        # verify that 2015-10-17 has the \u0027project_id\u0027 field"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_231d7ebd","line":515,"updated":"2015-07-06 17:16:51.000000000","message":"I see that other tests are doing this but I\u0027m not sure why, seems unnecessary.  The only reason I\u0027d think is there is some kind of race in these tests, which would seem like a bug.","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e52d551f90b3c6849f7bbc185a2187860c79aa94","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        mddict \u003d jsonutils.loads(mdjson)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        self.assertIn(\"project_id\", mddict)"},{"line_number":523,"context_line":"        self.assertEqual(mddict[\"project_id\"], self.instance[\u0027project_id\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # verify that older version do not have it"},{"line_number":526,"context_line":"        mdjson \u003d mdinst.lookup(\"/openstack/2012-08-10/meta_data.json\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_e364764a","line":523,"updated":"2015-07-06 17:16:51.000000000","message":"self.instance is an object so use dot notation, self.instance.project_id.","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e52d551f90b3c6849f7bbc185a2187860c79aa94","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.assertEqual(mddict[\"project_id\"], self.instance[\u0027project_id\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # verify that older version do not have it"},{"line_number":526,"context_line":"        mdjson \u003d mdinst.lookup(\"/openstack/2012-08-10/meta_data.json\")"},{"line_number":527,"context_line":"        self.assertNotIn(\"project_id\", jsonutils.loads(mdjson))"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    def test_no_dashes_in_metadata(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_23e25ea0","line":526,"updated":"2015-07-06 17:16:51.000000000","message":"nit: I\u0027d use the havana version since that\u0027s n-1:\n\n2013-10-17","commit_id":"f8f2ff61fb04a6988e99893f521156090923f325"}]}